Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Stewart via buildroot <buildroot@buildroot.org>
Cc: Christian Stewart <christian@aperture.us>,
	Bernd Kuhls <bernd@kuhls.net>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/linux-firmware: fix missing rtl8723 bins
Date: Sat, 26 Oct 2024 16:07:51 +0200	[thread overview]
Message-ID: <20241026160751.733cd748@windsurf> (raw)
In-Reply-To: <20241026055003.69253-1-christian@aperture.us>

On Fri, 25 Oct 2024 22:50:03 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> Fix a build failure due to these changes:
> 
> Commit 2bb8fb26599302c9cbc69a5aff329a8559c91e48:
> rename rtl8723bs_config-OBDA8723.bin -> rtl_bt/rtl8723bs_config.bin
> 
> Commit 5a017996c6de64ebd7f7c60e1233a45ba04086ca:
> remove rtl_bt/rtl8723d_config.bin
> 
> https://lists.buildroot.org/pipermail/buildroot/2024-October/765934.html
> 
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
>  package/linux-firmware/linux-firmware.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, I have applied, but two things were missing from your commit
log:

1. Important: you did not specify which Buildroot commit introduced the
issue. You mentioned upstream commits (good!), but we also need to know
which Buildroot commit did the linux-firmware bump that introduced the
issue, so that we know if we should backport your fix to a stable
branch or not.

2. Less important, but nice: you did not add a reference to the
autobuilder failures being fixed.

I've fixed both issues when applying. Again: thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-10-26 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-26  5:50 [Buildroot] [PATCH v1 1/1] package/linux-firmware: fix missing rtl8723 bins Christian Stewart via buildroot
2024-10-26 14:07 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026160751.733cd748@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=christian@aperture.us \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox