[Buildroot] [PATCH v1 1/1] package/linux-firmware: fix missing rtl8723 bins

[Buildroot] [PATCH v1 1/1] package/linux-firmware: fix missing rtl8723 bins

[Christian Stewart via buildroot]

Fix a build failure due to these changes:

Commit 2bb8fb26599302c9cbc69a5aff329a8559c91e48:
rename rtl8723bs_config-OBDA8723.bin -> rtl_bt/rtl8723bs_config.bin

Commit 5a017996c6de64ebd7f7c60e1233a45ba04086ca:
remove rtl_bt/rtl8723d_config.bin

https://lists.buildroot.org/pipermail/buildroot/2024-October/765934.html

Signed-off-by: Christian Stewart <christian@aperture.us>
---
 package/linux-firmware/linux-firmware.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index b48bb80713..9ffd52dff5 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -79,8 +79,7 @@ endif
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RTL_87XX_BT),y)
 LINUX_FIRMWARE_FILES += \
 	rtl_bt/rtl8723a_fw.bin rtl_bt/rtl8723b_fw.bin \
-	rtl_bt/rtl8723bs_config-OBDA8723.bin \
-	rtl_bt/rtl8723bs_fw.bin rtl_bt/rtl8723d_config.bin \
+	rtl_bt/rtl8723bs_config.bin rtl_bt/rtl8723bs_fw.bin \
 	rtl_bt/rtl8723d_fw.bin rtl_bt/rtl8761a_fw.bin \
 	rtl_bt/rtl8761b_fw.bin rtl_bt/rtl8761b_config.bin \
 	rtl_bt/rtl8761bu_fw.bin rtl_bt/rtl8761bu_config.bin
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v1 1/1] package/linux-firmware: fix missing rtl8723 bins

[Thomas Petazzoni via buildroot]

On Fri, 25 Oct 2024 22:50:03 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:

> Fix a build failure due to these changes:
> 
> Commit 2bb8fb26599302c9cbc69a5aff329a8559c91e48:
> rename rtl8723bs_config-OBDA8723.bin -> rtl_bt/rtl8723bs_config.bin
> 
> Commit 5a017996c6de64ebd7f7c60e1233a45ba04086ca:
> remove rtl_bt/rtl8723d_config.bin
> 
> https://lists.buildroot.org/pipermail/buildroot/2024-October/765934.html
> 
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
>  package/linux-firmware/linux-firmware.mk | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, I have applied, but two things were missing from your commit
log:

1. Important: you did not specify which Buildroot commit introduced the
issue. You mentioned upstream commits (good!), but we also need to know
which Buildroot commit did the linux-firmware bump that introduced the
issue, so that we know if we should backport your fix to a stable
branch or not.

2. Less important, but nice: you did not add a reference to the
autobuilder failures being fixed.

I've fixed both issues when applying. Again: thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot