[Buildroot] [PATCH 1/1] package/popperjs: remove PopperJS package

[Buildroot] [PATCH 1/1] package/popperjs: remove PopperJS package

[Thomas Perale via buildroot]

PopperJS project is now called floating-ui and is hosted on
https://github.com/floating-ui/floating-ui this caused legacy
source code archives to be repackaged with difference directory
name which broke the sha256 hash and made the autobuild fail.

Given the package has never been bumped since its introduction the
support for that package should probably be dropped.

Fixes:
  - https://autobuild.buildroot.org/results/ab6/ab62afa6252ad986a900fbfc8b805038edc5d1d6/
  - https://autobuild.buildroot.org/results/d1a/d1a5b56b987aa178b2ca3fa0855a5bd3da896bcb/
  - https://autobuild.buildroot.org/results/962/9629da94be61a906fd113e77f0120cade521a715/
  - ...

Signed-off-by: Thomas Perale <thomas.perale@mind.be>
---
 Config.in.legacy               |  5 +++++
 package/Config.in              |  1 -
 package/popperjs/Config.in     |  6 ------
 package/popperjs/popperjs.hash |  3 ---
 package/popperjs/popperjs.mk   | 19 -------------------
 5 files changed, 5 insertions(+), 29 deletions(-)
 delete mode 100644 package/popperjs/Config.in
 delete mode 100644 package/popperjs/popperjs.hash
 delete mode 100644 package/popperjs/popperjs.mk

diff --git a/Config.in.legacy b/Config.in.legacy
index 6a1518f439..50d2776113 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,11 @@ endif
 
 comment "Legacy options removed in 2024.11"
 
+config BR2_PACKAGE_POPPERJS
+	string "PopperJS has been removed"
+	help
+	  The project has been renamed to floating-ui.
+
 config BR2_PACKAGE_IPMITOOL_PEN_REG_URI
 	string "IANA PEN registry moved to iana-assignment package"
 	help
diff --git a/package/Config.in b/package/Config.in
index 2200f16520..f3fe27a6bf 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1881,7 +1881,6 @@ endif
 	source "package/json-javascript/Config.in"
 	source "package/jszip/Config.in"
 	source "package/openlayers/Config.in"
-	source "package/popperjs/Config.in"
 	source "package/vis-network/Config.in"
 	source "package/vuejs/Config.in"
 if BR2_PACKAGE_VUEJS
diff --git a/package/popperjs/Config.in b/package/popperjs/Config.in
deleted file mode 100644
index eae963100e..0000000000
--- a/package/popperjs/Config.in
+++ /dev/null
@@ -1,6 +0,0 @@
-config BR2_PACKAGE_POPPERJS
-	bool "popperjs"
-	help
-	  Popper.js, a JavaScript Tooltip & Popover Positioning Engine.
-
-	  https://popper.js.org
diff --git a/package/popperjs/popperjs.hash b/package/popperjs/popperjs.hash
deleted file mode 100644
index a2388f5b7a..0000000000
--- a/package/popperjs/popperjs.hash
+++ /dev/null
@@ -1,3 +0,0 @@
-# Locally computed:
-sha256  83eecef51d10826faca2cd5cabb344e0bef6d4127d7e728db9e4d8308b7b15d1  popperjs-1.16.0.tar.gz
-sha256  2961310ed05cd9373a08b8191c071425a7fede0ca5d807ca38fa5f5f61c5b834  LICENSE.md
diff --git a/package/popperjs/popperjs.mk b/package/popperjs/popperjs.mk
deleted file mode 100644
index c5df302eb2..0000000000
--- a/package/popperjs/popperjs.mk
+++ /dev/null
@@ -1,19 +0,0 @@
-################################################################################
-#
-# popperjs
-#
-################################################################################
-
-POPPERJS_VERSION = 1.16.0
-POPPERJS_SITE = $(call github,popperjs,popper-core,v$(POPPERJS_VERSION))
-POPPERJS_LICENSE = MIT
-POPPERJS_LICENSE_FILES = LICENSE.md
-
-define POPPERJS_INSTALL_TARGET_CMDS
-	$(INSTALL) -m 0644 -D $(@D)/dist/umd/popper.min.js \
-		$(TARGET_DIR)/var/www/popperjs/js/popper.min.js
-	$(INSTALL) -m 0644 -D $(@D)/dist/umd/popper-utils.min.js \
-		$(TARGET_DIR)/var/www/popperjs/js/popper-utils.min.js
-endef
-
-$(eval $(generic-package))
-- 
2.46.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/popperjs: remove PopperJS package

[Thomas Petazzoni via buildroot]

Hello Thomas,

I have applied, after doing some small tweaks.

First, commit title:

	package/popperjs: remove package

(no need to repeat the package name)

On Wed, 18 Sep 2024 17:10:43 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> PopperJS project is now called floating-ui and is hosted on
> https://github.com/floating-ui/floating-ui this caused legacy
> source code archives to be repackaged with difference directory
> name which broke the sha256 hash and made the autobuild fail.
> 
> Given the package has never been bumped since its introduction the
> support for that package should probably be dropped.

I added here an indication that the person who contributed/maintained
this package dropped himself from the DEVELOPERS file in March 2024.
Which means the package was basically orphan since then.


> +config BR2_PACKAGE_POPPERJS
> +	string "PopperJS has been removed"

This should have been a "bool", not a "string".

And it should have had:

	select BR2_LEGACY

Applied with those fixes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot