Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.7.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Giulio,

On Tue, 24 Sep 2024 11:07:56 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> * add libxml2 dependency that is now mandatory
> * drop 2 local patches that have been committed.
> * add 2 patches committed upstream to fix musl build failure.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  ...-reexport-.c-Re-add-missing-includes.patch | 44 ----------------
>  ...de-junction.h-Define-macros-for-musl.patch | 51 +++++++++++++++++++
>  ...d_sqlite.c-Add-missing-sys-syscall.h.patch | 31 -----------
>  ...rt-junction-path.c-Fix-buld-for-musl.patch | 40 +++++++++++++++
>  package/nfs-utils/Config.in                   |  1 +
>  package/nfs-utils/nfs-utils.hash              |  4 +-
>  package/nfs-utils/nfs-utils.mk                |  6 +--
>  7 files changed, 97 insertions(+), 80 deletions(-)
>  delete mode 100644 package/nfs-utils/0001-reexport-fsidd-reexport-.c-Re-add-missing-includes.patch
>  create mode 100644 package/nfs-utils/0001-support-include-junction.h-Define-macros-for-musl.patch
>  delete mode 100644 package/nfs-utils/0002-support-backend_sqlite.c-Add-missing-sys-syscall.h.patch
>  create mode 100644 package/nfs-utils/0002-support-junction-path.c-Fix-buld-for-musl.patch

Thanks for your patch. However, as far as I can see, libxml2 is not a
mandatory dependency, you only need it when --enable-junctions (which
is now the default). But I believe we should keep it optional in
Buildroot for the target package (which a sub-option in Config.in), and
simply disable junctions for the host package.

Also, your patches have PATCH 1/2 and PATCH 2/2, so they will cause
some check-package warnings.

Could you rework/adjust?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot