Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.8.1

[Petr Vorel <petr.vorel@gmail.com>]

Hi Giulio,

Thanks for the update!

> * disable junction and nfsdctl by default
...
>  NFS_UTILS_CONF_OPTS = \
>  	--enable-tirpc \
>  	--enable-ipv6 \
> +	--disable-junction \
> +	--disable-nfsdctl \
>  	--without-tcp-wrappers \
>  	--with-statedir=/run/nfs \
>  	--with-rpcgen=$(HOST_DIR)/bin/rpcgen
> @@ -30,6 +32,8 @@ HOST_NFS_UTILS_CONF_OPTS = \
>  	--disable-gss \
>  	--disable-uuid \
>  	--disable-ipv6 \
> +	--disable-junction \
> +	--disable-nfsdctl \
>  	--without-tcp-wrappers \
>  	--with-statedir=/run/nfs \
>  	--disable-caps \

What was the reason to disable them? Shouldn't be at least nfsdctl enabled?

man nfsdctl(8) "control program for the Linux kernel NFS server" [1]
That sounds useful.

man nfsref(8) "manage NFS referrals"
       ...
       A junction is a file system object on an NFS server that, when an
       NFS client encounters it, triggers a referral.  Similar to a
       symlink, a junction contains one or more target locations that
       the server sends to clients in the form of an NFSv4 referral.

I'm not sure how much useful this is, but it's enabled by default. Also Debian
explicitly enables it. Do we have a good reason to disable it?

> * drop 2 local patches that have been committed.

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

[1] https://manpages.debian.org/testing/nfs-kernel-server/nfsdctl.8.en.html
[2] https://man7.org/linux/man-pages/man8/nfsref.8.html
[3] https://salsa.debian.org/kernel-team/nfs-utils/-/blob/master/debian/rules?ref_type=heads
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot