Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/criu: fix comment condition
@ 2024-10-28 12:44 Michael Nosthoff via buildroot
  2024-10-28 14:42 ` Thomas Petazzoni via buildroot
  2024-11-13  8:02 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Nosthoff via buildroot @ 2024-10-28 12:44 UTC (permalink / raw)
  To: buildroot; +Cc: Marcus Folkesson

in e97fc89e7b a dependency on host-gcc >= 7 was added but
for the comment the condition was not correctly inverted.

Fixes: e97fc89e7b ("package/protobuf-c: bump to version 1.5.0")

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
 package/criu/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/criu/Config.in b/package/criu/Config.in
index 90bb18d355..a56dbe56ff 100644
--- a/package/criu/Config.in
+++ b/package/criu/Config.in
@@ -50,4 +50,4 @@ comment "criu needs a glibc or musl toolchain w/ threads, host gcc >= 7, gcc >=
 		|| !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_18 \
 		|| BR2_TOOLCHAIN_USES_UCLIBC || !BR2_INSTALL_LIBSTDCPP \
 		|| BR2_STATIC_LIBS || !BR2_USE_WCHAR \
-		|| BR2_HOST_GCC_AT_LEAST_7
+		|| !BR2_HOST_GCC_AT_LEAST_7
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/criu: fix comment condition
  2024-10-28 12:44 [Buildroot] [PATCH] package/criu: fix comment condition Michael Nosthoff via buildroot
@ 2024-10-28 14:42 ` Thomas Petazzoni via buildroot
  2024-11-13  8:02 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-28 14:42 UTC (permalink / raw)
  To: Michael Nosthoff via buildroot; +Cc: Marcus Folkesson

On Mon, 28 Oct 2024 13:44:13 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> in e97fc89e7b a dependency on host-gcc >= 7 was added but
> for the comment the condition was not correctly inverted.
> 
> Fixes: e97fc89e7b ("package/protobuf-c: bump to version 1.5.0")
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>  package/criu/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Good catch: applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/criu: fix comment condition
  2024-10-28 12:44 [Buildroot] [PATCH] package/criu: fix comment condition Michael Nosthoff via buildroot
  2024-10-28 14:42 ` Thomas Petazzoni via buildroot
@ 2024-11-13  8:02 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-11-13  8:02 UTC (permalink / raw)
  To: Michael Nosthoff via buildroot; +Cc: Marcus Folkesson

>>>>> "Michael" == Michael Nosthoff via buildroot <buildroot@buildroot.org> writes:

 > in e97fc89e7b a dependency on host-gcc >= 7 was added but
 > for the comment the condition was not correctly inverted.

 > Fixes: e97fc89e7b ("package/protobuf-c: bump to version 1.5.0")

 > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Committed to 2024.02.x and 2024.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-13  8:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 12:44 [Buildroot] [PATCH] package/criu: fix comment condition Michael Nosthoff via buildroot
2024-10-28 14:42 ` Thomas Petazzoni via buildroot
2024-11-13  8:02 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox