* [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text
@ 2024-10-29 4:48 Scott Fan
2024-10-29 11:21 ` Thomas Petazzoni via buildroot
2024-10-29 13:58 ` [Buildroot] [PATCH v2] " Scott Fan
0 siblings, 2 replies; 7+ messages in thread
From: Scott Fan @ 2024-10-29 4:48 UTC (permalink / raw)
To: buildroot; +Cc: Scott Fan
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
package/procps-ng/Config.in | 4 ++--
package/procps-ng/procps-ng.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/procps-ng/Config.in b/package/procps-ng/Config.in
index 4afd01699b..7af0e97fb4 100644
--- a/package/procps-ng/Config.in
+++ b/package/procps-ng/Config.in
@@ -11,10 +11,10 @@ config BR2_PACKAGE_PROCPS_NG
if BR2_PACKAGE_PROCPS_NG
-config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
+config BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP
bool "Use original top layout"
help
Disable modern top layout, return to original top with
- detail cpu usage.
+ detailed cpu usage.
endif
diff --git a/package/procps-ng/procps-ng.mk b/package/procps-ng/procps-ng.mk
index 4ac82cf6f9..c5185c2c8a 100644
--- a/package/procps-ng/procps-ng.mk
+++ b/package/procps-ng/procps-ng.mk
@@ -56,7 +56,7 @@ else
PROCPS_NG_CONF_OPTS += --enable-w
endif
-ifeq ($(BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP),y)
+ifeq ($(BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP),y)
PROCPS_NG_CONF_OPTS += --disable-modern-top
endif
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text
2024-10-29 4:48 [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text Scott Fan
@ 2024-10-29 11:21 ` Thomas Petazzoni via buildroot
2024-10-29 13:34 ` Scott Fan
2024-10-29 13:58 ` [Buildroot] [PATCH v2] " Scott Fan
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-29 11:21 UTC (permalink / raw)
To: Scott Fan; +Cc: Julien Olivain, Peter Korsgaard, Romain Naour, buildroot
Hello Scott,
On Tue, 29 Oct 2024 12:48:38 +0800
Scott Fan <fancp2007@gmail.com> wrote:
> if BR2_PACKAGE_PROCPS_NG
>
> -config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
> +config BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP
Thanks for spotting this. However, since this option has made its way
to Buildroot 2024.08, I think we have no choice but to add an entry in
the Config.in.legacy file for the old option name.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text
2024-10-29 11:21 ` Thomas Petazzoni via buildroot
@ 2024-10-29 13:34 ` Scott Fan
2024-10-29 13:38 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 7+ messages in thread
From: Scott Fan @ 2024-10-29 13:34 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Julien Olivain, Peter Korsgaard, Romain Naour, buildroot
Hi Thomas,
On Tue, Oct 29, 2024 at 7:21 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Scott,
>
> On Tue, 29 Oct 2024 12:48:38 +0800
> Scott Fan <fancp2007@gmail.com> wrote:
>
> > if BR2_PACKAGE_PROCPS_NG
> >
> > -config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
> > +config BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP
>
> Thanks for spotting this. However, since this option has made its way
> to Buildroot 2024.08, I think we have no choice but to add an entry in
> the Config.in.legacy file for the old option name.
I found, no defconfig file has used this option so far.
Scott Fan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text
2024-10-29 13:34 ` Scott Fan
@ 2024-10-29 13:38 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-29 13:38 UTC (permalink / raw)
To: Scott Fan; +Cc: Julien Olivain, Peter Korsgaard, Romain Naour, buildroot
On Tue, 29 Oct 2024 21:34:18 +0800
Scott Fan <fancp2007@gmail.com> wrote:
> > Thanks for spotting this. However, since this option has made its way
> > to Buildroot 2024.08, I think we have no choice but to add an entry in
> > the Config.in.legacy file for the old option name.
> I found, no defconfig file has used this option so far.
defconfigs in Buildroot upstream are not the problem, as anyway our
upstream defconfigs are minimal so none of them will ever enable
procps-ng.
We are concerned about all the custom configurations/defconfigs that
people have created for their own projects. This is why we have
Config.in.legacy in the first place.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2] package/procps-ng: fix typos in config option and help text
2024-10-29 4:48 [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text Scott Fan
2024-10-29 11:21 ` Thomas Petazzoni via buildroot
@ 2024-10-29 13:58 ` Scott Fan
2024-10-29 14:11 ` [Buildroot] [PATCH v3] " Scott Fan
1 sibling, 1 reply; 7+ messages in thread
From: Scott Fan @ 2024-10-29 13:58 UTC (permalink / raw)
To: buildroot; +Cc: Scott Fan
The option has been renamed, so add an entry in the
Config.in.legacy file for the old option name.
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
Changes v1 -> v2:
- add an entry in the Config.in.legacy file
---
Config.in.legacy | 6 ++++++
package/procps-ng/Config.in | 4 ++--
package/procps-ng/procps-ng.mk | 2 +-
3 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index a041d4da42..a6cef174c7 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,12 @@ endif
comment "Legacy options removed in 2024.11"
+config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
+ bool "BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP has been renamed"
+ select BR2_LEGACY
+ help
+ The option has been renamed to BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP.
+
config BR2_PACKAGE_QEMU_TARGET_NIOS2
bool "qemu nios2 support has been removed"
select BR2_LEGACY
diff --git a/package/procps-ng/Config.in b/package/procps-ng/Config.in
index 4afd01699b..7af0e97fb4 100644
--- a/package/procps-ng/Config.in
+++ b/package/procps-ng/Config.in
@@ -11,10 +11,10 @@ config BR2_PACKAGE_PROCPS_NG
if BR2_PACKAGE_PROCPS_NG
-config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
+config BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP
bool "Use original top layout"
help
Disable modern top layout, return to original top with
- detail cpu usage.
+ detailed cpu usage.
endif
diff --git a/package/procps-ng/procps-ng.mk b/package/procps-ng/procps-ng.mk
index 4ac82cf6f9..c5185c2c8a 100644
--- a/package/procps-ng/procps-ng.mk
+++ b/package/procps-ng/procps-ng.mk
@@ -56,7 +56,7 @@ else
PROCPS_NG_CONF_OPTS += --enable-w
endif
-ifeq ($(BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP),y)
+ifeq ($(BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP),y)
PROCPS_NG_CONF_OPTS += --disable-modern-top
endif
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v3] package/procps-ng: fix typos in config option and help text
2024-10-29 13:58 ` [Buildroot] [PATCH v2] " Scott Fan
@ 2024-10-29 14:11 ` Scott Fan
2024-10-29 17:49 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 7+ messages in thread
From: Scott Fan @ 2024-10-29 14:11 UTC (permalink / raw)
To: buildroot; +Cc: Scott Fan
The option has been renamed, so add an entry in the
Config.in.legacy file for the old option name.
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
Changes v1 -> v2:
- add an entry in the Config.in.legacy file
Changes v2 -> v3:
- update the entry in the Config.in.legacy file
---
Config.in.legacy | 8 ++++++++
package/procps-ng/Config.in | 4 ++--
package/procps-ng/procps-ng.mk | 2 +-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index a041d4da42..30179add23 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,14 @@ endif
comment "Legacy options removed in 2024.11"
+config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
+ bool "BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP has been renamed"
+ select BR2_LEGACY
+ select BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP
+ help
+ The option has been renamed to
+ BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP.
+
config BR2_PACKAGE_QEMU_TARGET_NIOS2
bool "qemu nios2 support has been removed"
select BR2_LEGACY
diff --git a/package/procps-ng/Config.in b/package/procps-ng/Config.in
index 4afd01699b..7af0e97fb4 100644
--- a/package/procps-ng/Config.in
+++ b/package/procps-ng/Config.in
@@ -11,10 +11,10 @@ config BR2_PACKAGE_PROCPS_NG
if BR2_PACKAGE_PROCPS_NG
-config BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP
+config BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP
bool "Use original top layout"
help
Disable modern top layout, return to original top with
- detail cpu usage.
+ detailed cpu usage.
endif
diff --git a/package/procps-ng/procps-ng.mk b/package/procps-ng/procps-ng.mk
index 4ac82cf6f9..c5185c2c8a 100644
--- a/package/procps-ng/procps-ng.mk
+++ b/package/procps-ng/procps-ng.mk
@@ -56,7 +56,7 @@ else
PROCPS_NG_CONF_OPTS += --enable-w
endif
-ifeq ($(BR2_PACKAGE_PROCPS_NS_ORIGINAL_TOP),y)
+ifeq ($(BR2_PACKAGE_PROCPS_NG_ORIGINAL_TOP),y)
PROCPS_NG_CONF_OPTS += --disable-modern-top
endif
--
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH v3] package/procps-ng: fix typos in config option and help text
2024-10-29 14:11 ` [Buildroot] [PATCH v3] " Scott Fan
@ 2024-10-29 17:49 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-29 17:49 UTC (permalink / raw)
To: Scott Fan; +Cc: buildroot
On Tue, 29 Oct 2024 22:11:24 +0800
Scott Fan <fancp2007@gmail.com> wrote:
> The option has been renamed, so add an entry in the
> Config.in.legacy file for the old option name.
>
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
>
> ---
> Changes v1 -> v2:
> - add an entry in the Config.in.legacy file
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-29 17:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 4:48 [Buildroot] [PATCH] package/procps-ng: fix typos in config option and help text Scott Fan
2024-10-29 11:21 ` Thomas Petazzoni via buildroot
2024-10-29 13:34 ` Scott Fan
2024-10-29 13:38 ` Thomas Petazzoni via buildroot
2024-10-29 13:58 ` [Buildroot] [PATCH v2] " Scott Fan
2024-10-29 14:11 ` [Buildroot] [PATCH v3] " Scott Fan
2024-10-29 17:49 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox