[Buildroot] [PATCH v2 1/1] package/libpng: fix arm soft-float build

[Buildroot] [PATCH v2 1/1] package/libpng: fix arm soft-float build

[Bernd Kuhls]

Bumping libpng to 1.6.44 with buildroot commit
583bb434ffe1eec0dbf6887dd719c3f41a6253e9
causes a build failure on arm because the NEON code is only available
for softfp and hardfp ABIs, and not soft-float.

Fixes:
http://autobuild.buildroot.net/results/021/02158525203d8c7f16a4a32637d44d6c87b7f333/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Co-authored-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
v2: updated LIBPNG_CONF_OPTS (Thomas)

 package/libpng/libpng.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libpng/libpng.mk b/package/libpng/libpng.mk
index 3e7fc42d82..9761993d79 100644
--- a/package/libpng/libpng.mk
+++ b/package/libpng/libpng.mk
@@ -17,7 +17,9 @@ HOST_LIBPNG_DEPENDENCIES = host-pkgconf host-zlib
 LIBPNG_CONFIG_SCRIPTS = libpng$(LIBPNG_SERIES)-config libpng-config
 LIBPNG_CONF_OPTS = --disable-tools
 
-ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_aarch64),y)
+ifeq ($(BR2_aarch64),y)
+LIBPNG_CONF_OPTS += --enable-arm-neon
+else ifeq ($(BR2_ARM_CPU_HAS_NEON):$(BR2_ARM_SOFT_FLOAT),y:)
 LIBPNG_CONF_OPTS += --enable-arm-neon
 else
 LIBPNG_CONF_OPTS += --disable-arm-neon
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/libpng: fix arm soft-float build

[Thomas Petazzoni via buildroot]

On Mon, 28 Oct 2024 23:37:54 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Bumping libpng to 1.6.44 with buildroot commit
> 583bb434ffe1eec0dbf6887dd719c3f41a6253e9
> causes a build failure on arm because the NEON code is only available
> for softfp and hardfp ABIs, and not soft-float.
> 
> Fixes:
> http://autobuild.buildroot.net/results/021/02158525203d8c7f16a4a32637d44d6c87b7f333/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> Co-authored-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> v2: updated LIBPNG_CONF_OPTS (Thomas)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/libpng: fix arm soft-float build

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Bumping libpng to 1.6.44 with buildroot commit
 > 583bb434ffe1eec0dbf6887dd719c3f41a6253e9
 > causes a build failure on arm because the NEON code is only available
 > for softfp and hardfp ABIs, and not soft-float.

 > Fixes:
 > http://autobuild.buildroot.net/results/021/02158525203d8c7f16a4a32637d44d6c87b7f333/

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 > Co-authored-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 > v2: updated LIBPNG_CONF_OPTS (Thomas)

Committed to 2024.02.x and 2024.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/libpng: fix arm soft-float build

[Peter Korsgaard]

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:
 >> Bumping libpng to 1.6.44 with buildroot commit
 >> 583bb434ffe1eec0dbf6887dd719c3f41a6253e9
 >> causes a build failure on arm because the NEON code is only available
 >> for softfp and hardfp ABIs, and not soft-float.

 >> Fixes:
 >> http://autobuild.buildroot.net/results/021/02158525203d8c7f16a4a32637d44d6c87b7f333/

 >> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
 >> Co-authored-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 >> ---
 >> v2: updated LIBPNG_CONF_OPTS (Thomas)

 > Committed to 2024.02.x and 2024.08.x, thanks.

We unfortunately still have a number of autobuilder issues on
arm(eb). It looks like we may need to pass -mfpu=neon in CFLAGS.

Is that something you can have a look at doing?

I didn't want to hold up the 2024.02.x release and the 1.6.44 bump is
not really that important, so I've reverted it for now for 2024.02.x.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot