* [Buildroot] [PATCH v3] package/dlib: add missing dependency on wchar
@ 2024-09-28 6:42 Roy Kollen Svendsen
2024-10-29 21:14 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: Roy Kollen Svendsen @ 2024-09-28 6:42 UTC (permalink / raw)
To: buildroot; +Cc: Roy Kollen Svendsen
Fixes: https://autobuild.buildroot.org/results/f5c543bcf57181373680d0c16a1814d21b000bcf
Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
Changes v1 -> v2:
- remove slash in autobuild url to fix link in gmail
Changes v2 -> v3:
- that did not work, so add space between Fixes and Signed-off-by
package/dlib/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/dlib/Config.in b/package/dlib/Config.in
index 2419af967b..7862f8d074 100644
--- a/package/dlib/Config.in
+++ b/package/dlib/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_DLIB
bool "dlib"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_TOOLCHAIN_HAS_THREADS
+ depends on BR2_USE_WCHAR
help
Dlib is a modern C++ toolkit containing machine learning
algorithms and tools for creating complex software in C++ to
@@ -9,6 +10,7 @@ config BR2_PACKAGE_DLIB
http://dlib.net
-comment "dlib needs a toolchain w/ C++, threads"
+comment "dlib needs a toolchain w/ C++, threads, wchar"
depends on !BR2_INSTALL_LIBSTDCPP || \
- !BR2_TOOLCHAIN_HAS_THREADS
+ !BR2_TOOLCHAIN_HAS_THREADS || \
+ !BR2_USE_WCHAR
--
2.46.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v3] package/dlib: add missing dependency on wchar
2024-09-28 6:42 [Buildroot] [PATCH v3] package/dlib: add missing dependency on wchar Roy Kollen Svendsen
@ 2024-10-29 21:14 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-29 21:14 UTC (permalink / raw)
To: Roy Kollen Svendsen; +Cc: buildroot
On Sat, 28 Sep 2024 08:42:15 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
> Fixes: https://autobuild.buildroot.org/results/f5c543bcf57181373680d0c16a1814d21b000bcf
>
> Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
> ---
> Changes v1 -> v2:
> - remove slash in autobuild url to fix link in gmail
Applied to master, thanks. However, please always indicate in the
commit message since *when* the problem has started occurring, when
fixing an issue, so we know if the fix needs to be backported or not.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-29 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-28 6:42 [Buildroot] [PATCH v3] package/dlib: add missing dependency on wchar Roy Kollen Svendsen
2024-10-29 21:14 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox