From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Romain Naour via buildroot <buildroot@buildroot.org>
Cc: Romain Naour <romain.naour@smile.fr>,
James Hilliard <james.hilliard1@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/python-twisted: add missing python3-zlib dependency
Date: Thu, 31 Oct 2024 13:53:37 +0100 [thread overview]
Message-ID: <20241031135337.0303f7ae@windsurf> (raw)
In-Reply-To: <20241030221140.2520388-1-romain.naour@smile.fr>
On Wed, 30 Oct 2024 23:11:40 +0100
Romain Naour via buildroot <buildroot@buildroot.org> wrote:
> TestPythonTwisted doesn't try to import all python-twisted modules and
> doesn't detect that zlib module is imported at least by
> twisted/web/client.py and twisted/conch.
This commit log really isn't clear, especially when looking at the
patch below.
Indeed, there is already a failure *today* without any change to the
test case, and the failure is that zlib is missing in the dependency.
But in addition to adding the zlib dependency, you *also* extend the
test script by important some more modules, as if this was needed to
test the zlib dependency.
So it's not really clear to me what you're trying to say here. Could
you clarify?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-10-31 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 22:11 [Buildroot] [PATCH] package/python-twisted: add missing python3-zlib dependency Romain Naour via buildroot
2024-10-31 12:53 ` Thomas Petazzoni via buildroot [this message]
2024-11-01 14:08 ` Romain Naour via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031135337.0303f7ae@windsurf \
--to=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox