[Buildroot] [PATCH] package/python-twisted: add missing python3-zlib dependency

[Buildroot] [PATCH] package/python-twisted: add missing python3-zlib dependency

[Romain Naour via buildroot]

TestPythonTwisted doesn't try to import all python-twisted modules and
doesn't detect that zlib module is imported at least by
twisted/web/client.py and twisted/conch.

Add python3-zlib as runtime dependency.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/8199992687 (TestPythonPy3Txtorcon)

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: James Hilliard <james.hilliard1@gmail.com>
---
It's not clear if all python-twisted modules really requires zlib,
but add python3-zlib to be on the safe side.
---
 package/python-twisted/Config.in                       | 1 +
 support/testing/tests/package/sample_python_twisted.py | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/python-twisted/Config.in b/package/python-twisted/Config.in
index 84786689b7..2d2bc30972 100644
--- a/package/python-twisted/Config.in
+++ b/package/python-twisted/Config.in
@@ -7,6 +7,7 @@ config BR2_PACKAGE_PYTHON_TWISTED
 	select BR2_PACKAGE_PYTHON_HYPERLINK # runtime
 	select BR2_PACKAGE_PYTHON_ZOPE_INTERFACE # runtime
 	select BR2_PACKAGE_PYTHON_TYPING_EXTENSIONS # runtime
+	select BR2_PACKAGE_PYTHON3_ZLIB # runtime
 	help
 	  Twisted is an event-driven networking engine written in
 	  Python.
diff --git a/support/testing/tests/package/sample_python_twisted.py b/support/testing/tests/package/sample_python_twisted.py
index 47d6c5debc..b5540522fc 100644
--- a/support/testing/tests/package/sample_python_twisted.py
+++ b/support/testing/tests/package/sample_python_twisted.py
@@ -1,4 +1,5 @@
 from twisted.internet import protocol, reactor, endpoints
+from twisted.web.client import readBody  # noqa: F401
 
 
 class F(protocol.Factory):
-- 
2.45.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-twisted: add missing python3-zlib dependency

[Thomas Petazzoni via buildroot]

On Wed, 30 Oct 2024 23:11:40 +0100
Romain Naour via buildroot <buildroot@buildroot.org> wrote:

> TestPythonTwisted doesn't try to import all python-twisted modules and
> doesn't detect that zlib module is imported at least by
> twisted/web/client.py and twisted/conch.

This commit log really isn't clear, especially when looking at the
patch below.

Indeed, there is already a failure *today* without any change to the
test case, and the failure is that zlib is missing in the dependency.

But in addition to adding the zlib dependency, you *also* extend the
test script by important some more modules, as if this was needed to
test the zlib dependency.

So it's not really clear to me what you're trying to say here. Could
you clarify?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-twisted: add missing python3-zlib dependency

[Romain Naour via buildroot]

Hello Thomas,

Le 31/10/2024 à 13:53, Thomas Petazzoni a écrit :
> On Wed, 30 Oct 2024 23:11:40 +0100
> Romain Naour via buildroot <buildroot@buildroot.org> wrote:
> 
>> TestPythonTwisted doesn't try to import all python-twisted modules and
>> doesn't detect that zlib module is imported at least by
>> twisted/web/client.py and twisted/conch.
> 
> This commit log really isn't clear, especially when looking at the
> patch below.
> 
> Indeed, there is already a failure *today* without any change to the
> test case, and the failure is that zlib is missing in the dependency.
> 
> But in addition to adding the zlib dependency, you *also* extend the
> test script by important some more modules, as if this was needed to
> test the zlib dependency.
> 
> So it's not really clear to me what you're trying to say here. Could
> you clarify?

Currently the test TestPythonTwisted is *not* broken [1] since it doesn't test
all modules provided by python-twisted package.

Due to this, other runtime test like TestPythonPy3MagicWormhole or
TestPythonPy3Txtorcon are currently broken.

TestPythonTwisted should have failed due to missing zlib (hence my slight update
in sample_python_twisted.py)

[1]
https://gitlab.com/buildroot.org/buildroot/-/jobs?name=test_python_twisted.TestPythonPy3Twisted
[2] https://gitlab.com/buildroot.org/buildroot/-/jobs/8199992687
[3] https://gitlab.com/buildroot.org/buildroot/-/jobs/8199992646

Best regards,
Romain


> 
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot