[Buildroot] [PATCH 1/1] configs/pc: fix grub root device in help

[Buildroot] [PATCH 1/1] configs/pc: fix grub root device in help

[Cherniaev Andrei]

Also make docs more user-friendly

Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
---
 board/pc/grub-bios.cfg | 2 ++
 board/pc/readme.txt    | 7 +++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/board/pc/grub-bios.cfg b/board/pc/grub-bios.cfg
index bd3e3f0006..02db996dd6 100644
--- a/board/pc/grub-bios.cfg
+++ b/board/pc/grub-bios.cfg
@@ -1,3 +1,5 @@
+# After any change rebuild grub2 and the image:
+# make grub2-rebuild && make
 set default="0"
 set timeout="5"
 
diff --git a/board/pc/readme.txt b/board/pc/readme.txt
index 41aec50d36..311add1558 100644
--- a/board/pc/readme.txt
+++ b/board/pc/readme.txt
@@ -42,8 +42,11 @@ Emulation in qemu (BIOS)
 1. Edit grub-bios.cfg
 
   Since the driver will show up in the virtual machine as /dev/vda,
-  change board/pc/grub-bios.cfg to use root=/dev/vda2 instead of
-  root=/dev/sda2. Then rebuild grub2 and the image.
+  change board/pc/grub-bios.cfg to use root=/dev/vda1 instead of
+  root=/dev/sda1.
+1.1. Rebuild grub2 and the image:
+
+make grub2-rebuild && make
 
 2. Run the emulation with:
 
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] configs/pc: fix grub root device in help

[Thomas Petazzoni via buildroot]

Hello,

On Thu, 31 Oct 2024 20:04:41 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:

> Also make docs more user-friendly
> 
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>

Thanks for your contribution, I have applied the part of your patch
fixing root=/dev/sda1 and root=/dev/vda1. The rest wasn't relevant, as
it's considered general Buildroot knowledge. We're not going to repeat
in each and every configuration file which package to rebuild to get
things taken into account.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] configs/pc: fix grub root device in help

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > Hello,
 > On Thu, 31 Oct 2024 20:04:41 +0900
 > Cherniaev Andrei <dungeonlords789@naver.com> wrote:

 >> Also make docs more user-friendly
 >> 
 >> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>

 > Thanks for your contribution, I have applied the part of your patch
 > fixing root=/dev/sda1 and root=/dev/vda1. The rest wasn't relevant, as
 > it's considered general Buildroot knowledge. We're not going to repeat
 > in each and every configuration file which package to rebuild to get
 > things taken into account.

Committed to 2024.02.x and 2024.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot