Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
@ 2024-12-03  5:07 Jannik Becher
  2024-12-03  7:45 ` Thomas Petazzoni via buildroot
  2024-12-03 21:20 ` Julien Olivain
  0 siblings, 2 replies; 6+ messages in thread
From: Jannik Becher @ 2024-12-03  5:07 UTC (permalink / raw)
  To: buildroot; +Cc: thomas.petazzoni

 From b01f0e2c0cf18d25fb49eb2934b25a5e865810fe Mon Sep 17 00:00:00 2001
From: Jannik Becher <becher.jannik@gmail.com>
Date:Mon, 2 Dec 2024 19:50:09 +0100
Subject: [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2

Signed-off-by: Jannik Becher <becher.jannik@gmail.com>
---
package/igh-ethercat/igh-ethercat.hash | 2 +-
package/igh-ethercat/igh-ethercat.mk   | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/igh-ethercat/igh-ethercat.hash 
b/package/igh-ethercat/igh-ethercat.hash
index 67a152c6ae..1a772d7ea6 100644
--- a/package/igh-ethercat/igh-ethercat.hash
+++ b/package/igh-ethercat/igh-ethercat.hash
@@ -1,4 +1,4 @@
# Locally computed
-sha256 
  7e4d8f3497c0bc0b64a151c0d074349fe7614767563642d6fedb19567eafa1e1 
  igh-ethercat-f5dc109176400f540a8682a2c9ee20d411d14d61.tar
.gz
+sha256 
  3ddd1687327c9c589e3b53dc6fde2e60d76aba07e8662bf46e51807ff7815214 
  igh-ethercat-ca66cd6ae9b821bfbec6d68ee1b43da359c5894c.tar
.gz
sha256  231f7edcc7352d7734a96eef0b8030f77982678c516876fcb81e25b32d68564c 
  COPYING
sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 
  COPYING.LESSER
diff --git a/package/igh-ethercat/igh-ethercat.mk 
b/package/igh-ethercat/igh-ethercat.mk
index 5b618ab54a..0d36b6d725 100644
--- a/package/igh-ethercat/igh-ethercat.mk
+++ b/package/igh-ethercat/igh-ethercat.mk
@@ -5,6 +5,7 @@
################################################################################ 


IGH_ETHERCAT_VERSION = f5dc109176400f540a8682a2c9ee20d411d14d61
+IGH_ETHERCAT_VERSION = ca66cd6ae9b821bfbec6d68ee1b43da359c5894c
IGH_ETHERCAT_SITE = $(call 
gitlab,etherlab.org,ethercat,$(IGH_ETHERCAT_VERSION))
IGH_ETHERCAT_LICENSE = GPL-2.0 (IgH EtherCAT master), LGPL-2.1 (libraries)
IGH_ETHERCAT_LICENSE_FILES = COPYING COPYING.LESSER

-- 
2.47.1


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
  2024-12-03  5:07 [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2 Jannik Becher
@ 2024-12-03  7:45 ` Thomas Petazzoni via buildroot
  2024-12-03 21:20 ` Julien Olivain
  1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-12-03  7:45 UTC (permalink / raw)
  To: Jannik Becher; +Cc: buildroot

Hello Jannik,

On Tue, 3 Dec 2024 06:07:10 +0100
Jannik Becher <becher.jannik@gmail.com> wrote:

>  From b01f0e2c0cf18d25fb49eb2934b25a5e865810fe Mon Sep 17 00:00:00 2001
> From: Jannik Becher <becher.jannik@gmail.com>
> Date:Mon, 2 Dec 2024 19:50:09 +0100
> Subject: [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
> 
> Signed-off-by: Jannik Becher <becher.jannik@gmail.com>

Thanks a lot for your patch series, which overall looks pretty good!

However, could you resend it with "git send-email" ? Indeed it looks
like you've copy/pasted the patch contents into an e-mail, and due to
this the patches are line-wrapped, making them unapplicable.

https://git-scm.com/docs/git-send-email has the details on how to
configure it in conjunction with GMail.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
@ 2024-12-03 14:39 Jannik Becher
  0 siblings, 0 replies; 6+ messages in thread
From: Jannik Becher @ 2024-12-03 14:39 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni, Jannik Becher

Signed-off-by: Jannik Becher <becher.jannik@gmail.com>
---
 package/igh-ethercat/igh-ethercat.hash | 2 +-
 package/igh-ethercat/igh-ethercat.mk   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/igh-ethercat/igh-ethercat.hash b/package/igh-ethercat/igh-ethercat.hash
index 67a152c6ae..1a772d7ea6 100644
--- a/package/igh-ethercat/igh-ethercat.hash
+++ b/package/igh-ethercat/igh-ethercat.hash
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  7e4d8f3497c0bc0b64a151c0d074349fe7614767563642d6fedb19567eafa1e1  igh-ethercat-f5dc109176400f540a8682a2c9ee20d411d14d61.tar.gz
+sha256  3ddd1687327c9c589e3b53dc6fde2e60d76aba07e8662bf46e51807ff7815214  igh-ethercat-ca66cd6ae9b821bfbec6d68ee1b43da359c5894c.tar.gz
 sha256  231f7edcc7352d7734a96eef0b8030f77982678c516876fcb81e25b32d68564c  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LESSER
diff --git a/package/igh-ethercat/igh-ethercat.mk b/package/igh-ethercat/igh-ethercat.mk
index 5b618ab54a..0d36b6d725 100644
--- a/package/igh-ethercat/igh-ethercat.mk
+++ b/package/igh-ethercat/igh-ethercat.mk
@@ -5,6 +5,7 @@
 ################################################################################
 
 IGH_ETHERCAT_VERSION = f5dc109176400f540a8682a2c9ee20d411d14d61
+IGH_ETHERCAT_VERSION = ca66cd6ae9b821bfbec6d68ee1b43da359c5894c
 IGH_ETHERCAT_SITE = $(call gitlab,etherlab.org,ethercat,$(IGH_ETHERCAT_VERSION))
 IGH_ETHERCAT_LICENSE = GPL-2.0 (IgH EtherCAT master), LGPL-2.1 (libraries)
 IGH_ETHERCAT_LICENSE_FILES = COPYING COPYING.LESSER
-- 
2.47.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
  2024-12-03  5:07 [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2 Jannik Becher
  2024-12-03  7:45 ` Thomas Petazzoni via buildroot
@ 2024-12-03 21:20 ` Julien Olivain
  1 sibling, 0 replies; 6+ messages in thread
From: Julien Olivain @ 2024-12-03 21:20 UTC (permalink / raw)
  To: Jannik Becher; +Cc: buildroot, thomas.petazzoni

Hi Jannik,

On 03/12/2024 06:07, Jannik Becher wrote:
> From b01f0e2c0cf18d25fb49eb2934b25a5e865810fe Mon Sep 17 00:00:00 2001
> From: Jannik Becher <becher.jannik@gmail.com>
> Date:Mon, 2 Dec 2024 19:50:09 +0100
> Subject: [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
> 
> Signed-off-by: Jannik Becher <becher.jannik@gmail.com>
> ---
> package/igh-ethercat/igh-ethercat.hash | 2 +-
> package/igh-ethercat/igh-ethercat.mk   | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/igh-ethercat/igh-ethercat.hash 
> b/package/igh-ethercat/igh-ethercat.hash
> index 67a152c6ae..1a772d7ea6 100644
> --- a/package/igh-ethercat/igh-ethercat.hash
> +++ b/package/igh-ethercat/igh-ethercat.hash
> @@ -1,4 +1,4 @@
> # Locally computed
> -sha256 
>  7e4d8f3497c0bc0b64a151c0d074349fe7614767563642d6fedb19567eafa1e1 
>  igh-ethercat-f5dc109176400f540a8682a2c9ee20d411d14d61.tar
> .gz
> +sha256 
>  3ddd1687327c9c589e3b53dc6fde2e60d76aba07e8662bf46e51807ff7815214 
>  igh-ethercat-ca66cd6ae9b821bfbec6d68ee1b43da359c5894c.tar
> .gz
> sha256 
>  231f7edcc7352d7734a96eef0b8030f77982678c516876fcb81e25b32d68564c 
>  COPYING
> sha256 
>  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 
>  COPYING.LESSER
> diff --git a/package/igh-ethercat/igh-ethercat.mk 
> b/package/igh-ethercat/igh-ethercat.mk
> index 5b618ab54a..0d36b6d725 100644
> --- a/package/igh-ethercat/igh-ethercat.mk
> +++ b/package/igh-ethercat/igh-ethercat.mk
> @@ -5,6 +5,7 @@
> ################################################################################
> 
> 
> IGH_ETHERCAT_VERSION = f5dc109176400f540a8682a2c9ee20d411d14d61
> +IGH_ETHERCAT_VERSION = ca66cd6ae9b821bfbec6d68ee1b43da359c5894c

This patch adds a new version "ca66c..." but does not remove the old 
one.
Could you send an updated patch removing the old version please?

Also, the commit log one liner mention a bump to 1.6.2. The tag points 
to a
different commit. See:
https://gitlab.com/etherlab.org/ethercat/-/commits/1.6.2?ref_type=tags

Is this intended? i.e. do you need the commit
https://gitlab.com/etherlab.org/ethercat/-/commit/5802c72818df07d34469630a8943915cce738626

If yes, I suggest you add a note in the commit log about that.
If no, you could use the tag reference "1.6.2".

> IGH_ETHERCAT_SITE = $(call 
> gitlab,etherlab.org,ethercat,$(IGH_ETHERCAT_VERSION))
> IGH_ETHERCAT_LICENSE = GPL-2.0 (IgH EtherCAT master), LGPL-2.1 
> (libraries)
> IGH_ETHERCAT_LICENSE_FILES = COPYING COPYING.LESSER
> 
> --
> 2.47.1
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
@ 2024-12-04 15:53 Jannik Becher
  2024-12-05 19:52 ` Julien Olivain
  0 siblings, 1 reply; 6+ messages in thread
From: Jannik Becher @ 2024-12-04 15:53 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni, Julien Olivain, Jannik Becher

Signed-off-by: Jannik Becher <becher.jannik@gmail.com>
---
 package/igh-ethercat/igh-ethercat.hash | 2 +-
 package/igh-ethercat/igh-ethercat.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/igh-ethercat/igh-ethercat.hash b/package/igh-ethercat/igh-ethercat.hash
index 67a152c6ae..0c3a8bb07d 100644
--- a/package/igh-ethercat/igh-ethercat.hash
+++ b/package/igh-ethercat/igh-ethercat.hash
@@ -1,4 +1,4 @@
 # Locally computed
-sha256  7e4d8f3497c0bc0b64a151c0d074349fe7614767563642d6fedb19567eafa1e1  igh-ethercat-f5dc109176400f540a8682a2c9ee20d411d14d61.tar.gz
+sha256  844e9846a30b8bed0ae7f1e9a70b724b8980a21ef61c2bdf8fa219c9745c1958  igh-ethercat-1.6.2.tar.gz
 sha256  231f7edcc7352d7734a96eef0b8030f77982678c516876fcb81e25b32d68564c  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LESSER
diff --git a/package/igh-ethercat/igh-ethercat.mk b/package/igh-ethercat/igh-ethercat.mk
index 5b618ab54a..374f8891e5 100644
--- a/package/igh-ethercat/igh-ethercat.mk
+++ b/package/igh-ethercat/igh-ethercat.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-IGH_ETHERCAT_VERSION = f5dc109176400f540a8682a2c9ee20d411d14d61
+IGH_ETHERCAT_VERSION = 1.6.2
 IGH_ETHERCAT_SITE = $(call gitlab,etherlab.org,ethercat,$(IGH_ETHERCAT_VERSION))
 IGH_ETHERCAT_LICENSE = GPL-2.0 (IgH EtherCAT master), LGPL-2.1 (libraries)
 IGH_ETHERCAT_LICENSE_FILES = COPYING COPYING.LESSER
-- 
2.47.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2
  2024-12-04 15:53 Jannik Becher
@ 2024-12-05 19:52 ` Julien Olivain
  0 siblings, 0 replies; 6+ messages in thread
From: Julien Olivain @ 2024-12-05 19:52 UTC (permalink / raw)
  To: Jannik Becher; +Cc: buildroot, Thomas Petazzoni

Hi Jannik,

On 04/12/2024 16:53, Jannik Becher wrote:
> Signed-off-by: Jannik Becher <becher.jannik@gmail.com>

Thanks for this updated patches.

I applied the series to the branch "next". I did minor rework:
I fixed the package hash and also removed the package patch (which was
included in this new release).

> ---
>  package/igh-ethercat/igh-ethercat.hash | 2 +-
>  package/igh-ethercat/igh-ethercat.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/igh-ethercat/igh-ethercat.hash 
> b/package/igh-ethercat/igh-ethercat.hash
> index 67a152c6ae..0c3a8bb07d 100644
> --- a/package/igh-ethercat/igh-ethercat.hash
> +++ b/package/igh-ethercat/igh-ethercat.hash
> @@ -1,4 +1,4 @@
>  # Locally computed
> -sha256  
> 7e4d8f3497c0bc0b64a151c0d074349fe7614767563642d6fedb19567eafa1e1  
> igh-ethercat-f5dc109176400f540a8682a2c9ee20d411d14d61.tar.gz
> +sha256  
> 844e9846a30b8bed0ae7f1e9a70b724b8980a21ef61c2bdf8fa219c9745c1958  
> igh-ethercat-1.6.2.tar.gz
>  sha256  
> 231f7edcc7352d7734a96eef0b8030f77982678c516876fcb81e25b32d68564c  
> COPYING
>  sha256  
> dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  
> COPYING.LESSER
> diff --git a/package/igh-ethercat/igh-ethercat.mk 
> b/package/igh-ethercat/igh-ethercat.mk
> index 5b618ab54a..374f8891e5 100644
> --- a/package/igh-ethercat/igh-ethercat.mk
> +++ b/package/igh-ethercat/igh-ethercat.mk
> @@ -4,7 +4,7 @@
>  #
>  
> ################################################################################
> 
> -IGH_ETHERCAT_VERSION = f5dc109176400f540a8682a2c9ee20d411d14d61
> +IGH_ETHERCAT_VERSION = 1.6.2
>  IGH_ETHERCAT_SITE = $(call 
> gitlab,etherlab.org,ethercat,$(IGH_ETHERCAT_VERSION))
>  IGH_ETHERCAT_LICENSE = GPL-2.0 (IgH EtherCAT master), LGPL-2.1 
> (libraries)
>  IGH_ETHERCAT_LICENSE_FILES = COPYING COPYING.LESSER
> --
> 2.47.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-05 19:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03  5:07 [Buildroot] [PATCH 1/2] package/igh-ethercat: bump version to 1.6.2 Jannik Becher
2024-12-03  7:45 ` Thomas Petazzoni via buildroot
2024-12-03 21:20 ` Julien Olivain
  -- strict thread matches above, loose matches on Subject: below --
2024-12-03 14:39 Jannik Becher
2024-12-04 15:53 Jannik Becher
2024-12-05 19:52 ` Julien Olivain

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox