Re: [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Thomas,

On Mon, 16 Dec 2024 18:48:29 +0100
Thomas Bonnefille <thomas.bonnefille@bootlin.com> wrote:

> GCC14 removed the implicit int support.
> This commit adds a patch to libsha1 to fix an implicit int declaration
> as recommended.
> 
> Link: https://gcc.gnu.org/gcc-14/porting_to.html
> 
> Fixes:
>     http://autobuild.buildroot.net/results/87dc9ba9690cbb6a82875734ce9cb8dbaf878e46/
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

Thanks for the new iteration! It fixes the issues I pointed out, but I
have more questions/comments.

> +Fixes:
> +
> +  test.c:14:8: error: type defaults to ‘int’ in declaration of ‘num_test’ [-Wimplicit-int]
> +     14 | static num_test;
> +        |        ^~~~~~~~
> +
> +Upstream: https://github.com/pseiderer/libsha1/commit/d449f26f782be91b3847f88ed2bd937582a575b6

This should ideally...

> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>

... go here, i.e right after Peter's SoB, but before yours, as it's an
information added by you.

But more importantly: https://github.com/pseiderer/libsha1/ isn't
"upstream". Upstream for this package is
https://github.com/dottedmag/libsha1. So we're interested in seeing
the change having been submitted or accepted by the real upstream, not
just a commit in some "random" Github repository (even though Peter
Seiderer is a well known Buildroot contributor!)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot