From: Thomas Bonnefille via buildroot <buildroot@buildroot.org>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org, "Miquèl Raynal" <miquel.raynal@bootlin.com>
Subject: Re: [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1
Date: Mon, 16 Dec 2024 21:56:04 +0100 [thread overview]
Message-ID: <D6DFB2M8HLES.RY7H0ZIZNUBO@bootlin.com> (raw)
In-Reply-To: <20241216213605.17b86ffb@windsurf>
On Mon Dec 16, 2024 at 9:36 PM CET, Thomas Petazzoni wrote:
> Hello Thomas,
Hello Thomas,
Thank you for the review !
> On Mon, 16 Dec 2024 18:48:29 +0100
> ...
> > +
> > +Upstream: https://github.com/pseiderer/libsha1/commit/d449f26f782be91b3847f88ed2bd937582a575b6
>
> This should ideally...
>
> > +
> > +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> ... go here, i.e right after Peter's SoB, but before yours, as it's an
> information added by you.
Ack
> But more importantly: https://github.com/pseiderer/libsha1/ isn't
> "upstream". Upstream for this package is
> https://github.com/dottedmag/libsha1. So we're interested in seeing
> the change having been submitted or accepted by the real upstream, not
> just a commit in some "random" Github repository (even though Peter
> Seiderer is a well known Buildroot contributor!)
Ok so a link to the pull-request is probably better here according to BR
documentation.
(https://github.com/dottedmag/libsha1/pull/1)
However, in this case the PR may not be merged soon given the date of
the last commit applied to the upstream package.
> Thanks!
>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-12-16 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 17:48 [Buildroot] [PATCH v2] package/libsha1: Fix gcc14 compilation in libsha1 Thomas Bonnefille
2024-12-16 20:36 ` Thomas Petazzoni via buildroot
2024-12-16 20:56 ` Thomas Bonnefille via buildroot [this message]
2024-12-16 22:10 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D6DFB2M8HLES.RY7H0ZIZNUBO@bootlin.com \
--to=buildroot@buildroot.org \
--cc=miquel.raynal@bootlin.com \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox