[Buildroot] [PATCH] package/quickjs: fix typo in prefix

[Buildroot] [PATCH] package/quickjs: fix typo in prefix

[Thomas Bonnefille]

The quickjs Makefile expects the variable PREFIX to be set [1] but
prefix is set instead.
Without this parameter quickjs is installed to /usr/local by default [2]
instead of /usr as requested.
This commit fixed this error.

[1]: https://github.com/bellard/quickjs/blob/master/Makefile#L383
[2]: https://github.com/bellard/quickjs/blob/master/Makefile#L43

Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
---
 package/quickjs/quickjs.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/quickjs/quickjs.mk b/package/quickjs/quickjs.mk
index e745923b87bff3cdeb2f872264be5e65466020cf..2bd9da1392cb853e57492253c6202a65187fb81e 100644
--- a/package/quickjs/quickjs.mk
+++ b/package/quickjs/quickjs.mk
@@ -29,7 +29,7 @@ define QUICKJS_INSTALL_STAGING_CMDS
 		EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
 		DESTDIR=$(STAGING_DIR) \
 		STRIP=/bin/true \
-		prefix=/usr \
+		PREFIX=/usr \
 		install
 endef
 
@@ -39,7 +39,7 @@ define QUICKJS_INSTALL_TARGET_CMDS
 		EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
 		DESTDIR=$(TARGET_DIR) \
 		STRIP=/bin/true \
-		prefix=/usr \
+		PREFIX=/usr \
 		install
 endef
 

---
base-commit: ed9da089449c53519be02204f97c3452abba5cc3
change-id: 20241211-fix_quickjs_prefix-28a1837f0d65

Best regards,
-- 
Thomas Bonnefille <thomas.bonnefille@bootlin.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quickjs: fix typo in prefix

[Julien Olivain]

On 16/12/2024 22:30, Thomas Bonnefille wrote:
> The quickjs Makefile expects the variable PREFIX to be set [1] but
> prefix is set instead.
> Without this parameter quickjs is installed to /usr/local by default 
> [2]
> instead of /usr as requested.
> This commit fixed this error.
> 
> [1]: https://github.com/bellard/quickjs/blob/master/Makefile#L383
> [2]: https://github.com/bellard/quickjs/blob/master/Makefile#L43
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

Applied to master, thanks.

> ---
>  package/quickjs/quickjs.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/quickjs/quickjs.mk b/package/quickjs/quickjs.mk
> index 
> e745923b87bff3cdeb2f872264be5e65466020cf..2bd9da1392cb853e57492253c6202a65187fb81e 
> 100644
> --- a/package/quickjs/quickjs.mk
> +++ b/package/quickjs/quickjs.mk
> @@ -29,7 +29,7 @@ define QUICKJS_INSTALL_STAGING_CMDS
>  		EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
>  		DESTDIR=$(STAGING_DIR) \
>  		STRIP=/bin/true \
> -		prefix=/usr \
> +		PREFIX=/usr \
>  		install
>  endef
> 
> @@ -39,7 +39,7 @@ define QUICKJS_INSTALL_TARGET_CMDS
>  		EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
>  		DESTDIR=$(TARGET_DIR) \
>  		STRIP=/bin/true \
> -		prefix=/usr \
> +		PREFIX=/usr \
>  		install
>  endef
> 
> 
> ---
> base-commit: ed9da089449c53519be02204f97c3452abba5cc3
> change-id: 20241211-fix_quickjs_prefix-28a1837f0d65
> 
> Best regards,
> --
> Thomas Bonnefille <thomas.bonnefille@bootlin.com>
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quickjs: fix typo in prefix

[Thomas Petazzoni via buildroot]

Hello Thomas,

On Mon, 16 Dec 2024 22:30:52 +0100
Thomas Bonnefille <thomas.bonnefille@bootlin.com> wrote:

> The quickjs Makefile expects the variable PREFIX to be set [1] but
> prefix is set instead.

... by Buildroot's quickjs.mk.

> Without this parameter quickjs is installed to /usr/local by default [2]
> instead of /usr as requested.
> This commit fixed this error.

s/fixed/fixes/

Also, you want to add:

Fixes: https://gitlab.com/buildroot.org/buildroot/-/issues/15

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/quickjs: fix typo in prefix

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Bonnefille <thomas.bonnefille@bootlin.com> writes:

 > The quickjs Makefile expects the variable PREFIX to be set [1] but
 > prefix is set instead.
 > Without this parameter quickjs is installed to /usr/local by default [2]
 > instead of /usr as requested.
 > This commit fixed this error.

 > [1]: https://github.com/bellard/quickjs/blob/master/Makefile#L383
 > [2]: https://github.com/bellard/quickjs/blob/master/Makefile#L43

 > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

Committed to 2024.11.x (this was broken by commit 814f9f17d5c3, so
2024.02.x is not affected), thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot