[Buildroot] [PATCH] package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

[Buildroot] [PATCH] package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

[Thomas Petazzoni via buildroot]

qt6quicktimeline has qt6declative in its dependencies, but does not
select BR2_PACKAGE_QT6DECLARATIVE. It does select
BR2_PACKAGE_QT6DECLARATIVE_QUICK, but this option "depends on"
BR2_PACKAGE_QT6DECLARATIVE, and does not select it.

Fixes:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT6DECLARATIVE_QUICK
  Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE [=n]
  Selected by [y]:
  - BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]

reported by kconfig.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/qt6/qt6quicktimeline/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/qt6/qt6quicktimeline/Config.in b/package/qt6/qt6quicktimeline/Config.in
index 4dcf0e1452..466aab23c8 100644
--- a/package/qt6/qt6quicktimeline/Config.in
+++ b/package/qt6/qt6quicktimeline/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT6QUICKTIMELINE
 	bool "qt6quicktimeline"
+	select BR2_PACKAGE_QT6DECLARATIVE
 	select BR2_PACKAGE_QT6DECLARATIVE_QUICK
 	help
 	  This package corresponds to the Qt Quick Timeline module:
-- 
2.47.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

[Thomas Petazzoni via buildroot]

Hello Roy,

On Mon, 6 Jan 2025 23:07:46 +0100
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> How can I recreate the warning reported by kconfig?

Like this:

$ cat > .config <<EOF
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6QUICKTIMELINE=y
EOF
$ make olddefconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT6DECLARATIVE_QUICK
  Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE [=n]
  Selected by [y]:
  - BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]
#
# configuration written to /home/thomas/projets/buildroot/.config
#

Basically, just enable qt6 and qt6quicktimeline. You can even do it
from menuconfig, and then when you exit menuconfig, you will see the
kconfig warning.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

[Julien Olivain]

On 06/01/2025 22:06, Thomas Petazzoni via buildroot wrote:
> qt6quicktimeline has qt6declative in its dependencies, but does not
> select BR2_PACKAGE_QT6DECLARATIVE. It does select
> BR2_PACKAGE_QT6DECLARATIVE_QUICK, but this option "depends on"
> BR2_PACKAGE_QT6DECLARATIVE, and does not select it.
> 
> Fixes:
> 
> WARNING: unmet direct dependencies detected for 
> BR2_PACKAGE_QT6DECLARATIVE_QUICK
>   Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE 
> [=n]
>   Selected by [y]:
>   - BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]
> 
> reported by kconfig.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/qt6/qt6quicktimeline: add missing select BR2_PACKAGE_QT6DECLARATIVE

[Roy Kollen Svendsen]

[-- Attachment #1.1: Type: text/plain, Size: 1192 bytes --]

Thanks. Now I got the warning, and it disappeared after applying your patch.


man. 6. jan. 2025 kl. 23:19 skrev Thomas Petazzoni <
thomas.petazzoni@bootlin.com>:

> Hello Roy,
>
> On Mon, 6 Jan 2025 23:07:46 +0100
> Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
>
> > How can I recreate the warning reported by kconfig?
>
> Like this:
>
> $ cat > .config <<EOF
> BR2_arm=y
> BR2_cortex_a9=y
> BR2_ARM_ENABLE_VFP=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> BR2_PACKAGE_QT6=y
> BR2_PACKAGE_QT6QUICKTIMELINE=y
> EOF
> $ make olddefconfig
> WARNING: unmet direct dependencies detected for
> BR2_PACKAGE_QT6DECLARATIVE_QUICK
>   Depends on [n]: BR2_PACKAGE_QT6 [=y] && BR2_PACKAGE_QT6DECLARATIVE [=n]
>   Selected by [y]:
>   - BR2_PACKAGE_QT6QUICKTIMELINE [=y] && BR2_PACKAGE_QT6 [=y]
> #
> # configuration written to /home/thomas/projets/buildroot/.config
> #
>
> Basically, just enable qt6 and qt6quicktimeline. You can even do it
> from menuconfig, and then when you exit menuconfig, you will see the
> kconfig warning.
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 1806 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot