[Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Akhilesh Nema]

Release notes:
https://github.com/besser82/libxcrypt/releases/tag/v4.4.37

Signed-off-by: Akhilesh Nema <nemaakhilesh@gmail.com>

---
Changes v1 -> v2:
  - Add host-pkgconf dependency (suggested by Julien)

---
 package/libxcrypt/Config.in      | 1 +
 package/libxcrypt/libxcrypt.hash | 4 ++--
 package/libxcrypt/libxcrypt.mk   | 4 +++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/package/libxcrypt/Config.in b/package/libxcrypt/Config.in
index 38c75b5e63..508e1a43cd 100644
--- a/package/libxcrypt/Config.in
+++ b/package/libxcrypt/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBXCRYPT
 	bool "libxcrypt"
 	depends on BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_HOST_PKGCONF
 	help
 	  libxcrypt is a modern library for one-way hashing
 	  of passwords. It supports a wide variety of both
diff --git a/package/libxcrypt/libxcrypt.hash b/package/libxcrypt/libxcrypt.hash
index 9bcf119077..45e2df6d4f 100644
--- a/package/libxcrypt/libxcrypt.hash
+++ b/package/libxcrypt/libxcrypt.hash
@@ -1,5 +1,5 @@
-# From https://github.com/besser82/libxcrypt/releases/download/v4.4.36/libxcrypt-4.4.36.tar.xz.sha256sum
-sha256  e5e1f4caee0a01de2aee26e3138807d6d3ca2b8e67287966d1fefd65e1fd8943  libxcrypt-4.4.36.tar.xz
+# From https://github.com/besser82/libxcrypt/releases/download/v4.4.37/libxcrypt-4.4.37.tar.xz.sha256sum
+sha256  902aa2976f959b5ebe55679b1722b8479f8f13cd4ce2ef432b0a84ae298fffd0  libxcrypt-4.4.37.tar.xz
 
 # Locally calculated
 sha256  f9b48b0bc67a92b752780710aa774cf08b62ec2ebaa3f4aebd00069fba6effd2  LICENSING
diff --git a/package/libxcrypt/libxcrypt.mk b/package/libxcrypt/libxcrypt.mk
index 60901988ac..d96d1661a8 100644
--- a/package/libxcrypt/libxcrypt.mk
+++ b/package/libxcrypt/libxcrypt.mk
@@ -4,11 +4,13 @@
 #
 ################################################################################
 
-LIBXCRYPT_VERSION = 4.4.36
+LIBXCRYPT_VERSION = 4.4.37
 LIBXCRYPT_SITE = https://github.com/besser82/libxcrypt/releases/download/v$(LIBXCRYPT_VERSION)
 LIBXCRYPT_SOURCE = libxcrypt-$(LIBXCRYPT_VERSION).tar.xz
 LIBXCRYPT_LICENSE = LGPL-2.1+
 LIBXCRYPT_LICENSE_FILES = LICENSING COPYING.LIB
+LIBXCRYPT_DEPENDENCIES = host-pkgconf
+HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf
 LIBXCRYPT_INSTALL_STAGING = YES
 
 # Some warnings turn into errors with some sensitive compilers
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Thomas Petazzoni via buildroot]

On Sun, 12 Jan 2025 14:31:42 -0800
Akhilesh Nema <nemaakhilesh@gmail.com> wrote:

> diff --git a/package/libxcrypt/Config.in b/package/libxcrypt/Config.in
> index 38c75b5e63..508e1a43cd 100644
> --- a/package/libxcrypt/Config.in
> +++ b/package/libxcrypt/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_LIBXCRYPT
>  	bool "libxcrypt"
>  	depends on BR2_TOOLCHAIN_USES_GLIBC
> +	select BR2_PACKAGE_HOST_PKGCONF

We really don't enforce selecting this option, so I'd rather see it not
done, than done inconsistently between packages.

> +LIBXCRYPT_DEPENDENCIES = host-pkgconf
> +HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf

I'm actually surprised by the dependency on host-pkgconf. host-pkgconf
is normally used to detect dependencies, but libxcrypt has no
dependencies other than the toolchain. So why is it needed now?
Explanations in your commit log would be very useful.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Julien Olivain]

Hi Thomas, Akhilesh,

On 13/01/2025 15:34, Thomas Petazzoni via buildroot wrote:
> On Sun, 12 Jan 2025 14:31:42 -0800
> Akhilesh Nema <nemaakhilesh@gmail.com> wrote:
> 
>> diff --git a/package/libxcrypt/Config.in b/package/libxcrypt/Config.in
>> index 38c75b5e63..508e1a43cd 100644
>> --- a/package/libxcrypt/Config.in
>> +++ b/package/libxcrypt/Config.in
>> @@ -1,6 +1,7 @@
>>  config BR2_PACKAGE_LIBXCRYPT
>>  	bool "libxcrypt"
>>  	depends on BR2_TOOLCHAIN_USES_GLIBC
>> +	select BR2_PACKAGE_HOST_PKGCONF
> 
> We really don't enforce selecting this option, so I'd rather see it not
> done, than done inconsistently between packages.
> 
>> +LIBXCRYPT_DEPENDENCIES = host-pkgconf
>> +HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf
> 
> I'm actually surprised by the dependency on host-pkgconf. host-pkgconf
> is normally used to detect dependencies, but libxcrypt has no
> dependencies other than the toolchain. So why is it needed now?
> Explanations in your commit log would be very useful.

As Akhilesh pointed out in the v1 thread, this was an upstream issue:
https://github.com/besser82/libxcrypt/issues/198

Hopefully, this was quickly fixed upstream. There is already a
new version:
https://github.com/besser82/libxcrypt/releases/tag/v4.4.38

So we could just skip this 4.4.37 version, and bump directly
to 4.4.38 (and not add the dependencies).

Akhilesh: could make sure to test this new bump with at least
a "utils/test-pkg -a -p libxcrypt" please? (or add in a comment
the test you did).

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Akhilesh Nema]

[-- Attachment #1.1: Type: text/plain, Size: 1978 bytes --]

Hi Everyone,

On Tue, Jan 14, 2025 at 10:18 AM Julien Olivain <ju.o@free.fr> wrote:

> Hi Thomas, Akhilesh,
>
> On 13/01/2025 15:34, Thomas Petazzoni via buildroot wrote:
> > On Sun, 12 Jan 2025 14:31:42 -0800
> > Akhilesh Nema <nemaakhilesh@gmail.com> wrote:
> >
> >> diff --git a/package/libxcrypt/Config.in b/package/libxcrypt/Config.in
> >> index 38c75b5e63..508e1a43cd 100644
> >> --- a/package/libxcrypt/Config.in
> >> +++ b/package/libxcrypt/Config.in
> >> @@ -1,6 +1,7 @@
> >>  config BR2_PACKAGE_LIBXCRYPT
> >>      bool "libxcrypt"
> >>      depends on BR2_TOOLCHAIN_USES_GLIBC
> >> +    select BR2_PACKAGE_HOST_PKGCONF
> >
> > We really don't enforce selecting this option, so I'd rather see it not
> > done, than done inconsistently between packages.
> >
> >> +LIBXCRYPT_DEPENDENCIES = host-pkgconf
> >> +HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf
> >
> > I'm actually surprised by the dependency on host-pkgconf. host-pkgconf
> > is normally used to detect dependencies, but libxcrypt has no
> > dependencies other than the toolchain. So why is it needed now?
> > Explanations in your commit log would be very useful.
>
> As Akhilesh pointed out in the v1 thread, this was an upstream issue:
> https://github.com/besser82/libxcrypt/issues/198
>
> Hopefully, this was quickly fixed upstream. There is already a
> new version:
> https://github.com/besser82/libxcrypt/releases/tag/v4.4.38
>
> So we could just skip this 4.4.37 version, and bump directly
> to 4.4.38 (and not add the dependencies).
>
> Akhilesh: could make sure to test this new bump with at least
> a "utils/test-pkg -a -p libxcrypt" please? (or add in a comment
> the test you did).
>
> Best regards,
>
> Julien.
>

Thank you so much for the review.  I have submitted a 4.4.38 bump patch
along with the test-pkg results.
-
https://patchwork.ozlabs.org/project/buildroot/patch/20250115034020.792083-1-nemaakhilesh@gmail.com/

Thanks
Akhilesh

[-- Attachment #1.2: Type: text/html, Size: 3020 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Akhilesh Nema]

Release notes:
https://github.com/besser82/libxcrypt/releases/tag/v4.4.37

Signed-off-by: Akhilesh Nema <nemaakhilesh@gmail.com>
---
 package/libxcrypt/libxcrypt.hash | 4 ++--
 package/libxcrypt/libxcrypt.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libxcrypt/libxcrypt.hash b/package/libxcrypt/libxcrypt.hash
index 9bcf119077..45e2df6d4f 100644
--- a/package/libxcrypt/libxcrypt.hash
+++ b/package/libxcrypt/libxcrypt.hash
@@ -1,5 +1,5 @@
-# From https://github.com/besser82/libxcrypt/releases/download/v4.4.36/libxcrypt-4.4.36.tar.xz.sha256sum
-sha256  e5e1f4caee0a01de2aee26e3138807d6d3ca2b8e67287966d1fefd65e1fd8943  libxcrypt-4.4.36.tar.xz
+# From https://github.com/besser82/libxcrypt/releases/download/v4.4.37/libxcrypt-4.4.37.tar.xz.sha256sum
+sha256  902aa2976f959b5ebe55679b1722b8479f8f13cd4ce2ef432b0a84ae298fffd0  libxcrypt-4.4.37.tar.xz
 
 # Locally calculated
 sha256  f9b48b0bc67a92b752780710aa774cf08b62ec2ebaa3f4aebd00069fba6effd2  LICENSING
diff --git a/package/libxcrypt/libxcrypt.mk b/package/libxcrypt/libxcrypt.mk
index 60901988ac..c16b3baa74 100644
--- a/package/libxcrypt/libxcrypt.mk
+++ b/package/libxcrypt/libxcrypt.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBXCRYPT_VERSION = 4.4.36
+LIBXCRYPT_VERSION = 4.4.37
 LIBXCRYPT_SITE = https://github.com/besser82/libxcrypt/releases/download/v$(LIBXCRYPT_VERSION)
 LIBXCRYPT_SOURCE = libxcrypt-$(LIBXCRYPT_VERSION).tar.xz
 LIBXCRYPT_LICENSE = LGPL-2.1+
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Julien Olivain]

Hi Akhilesh,

Thanks for this patch.

On 09/01/2025 02:18, Akhilesh Nema wrote:
> Release notes:
> https://github.com/besser82/libxcrypt/releases/tag/v4.4.37
> 
> Signed-off-by: Akhilesh Nema <nemaakhilesh@gmail.com>

[...]

> -LIBXCRYPT_VERSION = 4.4.36
> +LIBXCRYPT_VERSION = 4.4.37

When testing this new version with the command:

     utils/test-pkg -a -p libxcrypt

it seems all builds are now failing. The failures seems related
to the release archive autoconf "configure" script which was
generated with a newer pkgconf, which includes commit [1].

This means new dependencies might be needed, such as:

LIBXCRYPT_DEPENDENCIES = host-pkgconf
HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf

Could you confirm this analysis and send an updated patch please?
Could you also add the explanation in the commit log why those
new dependencies are needed?

Best regards,

Julien.

[1] 
https://github.com/pkgconf/pkgconf/commit/c583d49a3780c71c0d20a662a7cf562f6d01c171
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libxcrypt: bump version to 4.4.37

[Akhilesh Nema]

[-- Attachment #1.1: Type: text/plain, Size: 1195 bytes --]

Hi Julien,

On Sat, Jan 11, 2025 at 5:19 AM Julien Olivain <ju.o@free.fr> wrote:


> When testing this new version with the command:
>
>      utils/test-pkg -a -p libxcrypt
>
> it seems all builds are now failing. The failures seems related
> to the release archive autoconf "configure" script which was
> generated with a newer pkgconf, which includes commit [1].
>
> This means new dependencies might be needed, such as:
>
> LIBXCRYPT_DEPENDENCIES = host-pkgconf
> HOST_LIBXCRYPT_DEPENDENCIES = host-pkgconf
>
> Could you confirm this analysis and send an updated patch please?
> Could you also add the explanation in the commit log why those
> new dependencies are needed?
>
>
> https://github.com/pkgconf/pkgconf/commit/c583d49a3780c71c0d20a662a7cf562f6d01c171


Thank you for investigating the package build failure and providing a
solution.

The configuration error occurred due to the generated aclocal.m4 triggering
an error when pkg-config was not found.

This issue has also been reported at:
https://github.com/besser82/libxcrypt/issues/198#issue-2764045470

I will prepare and submit an updated patch with the suggested fix.

Thanks
Akhilesh

[-- Attachment #1.2: Type: text/html, Size: 1847 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot