Re: [Buildroot] [PATCH v9 2/6] package/{gobject-introspection, libglib2}: bump to {1.82.0, 2.82.4}

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Fiona Klute <fiona.klute@gmx.de>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	James Hilliard <james.hilliard1@gmail.com>,
	Marcus Hoffmann <buildroot@bubu1.eu>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v9 2/6] package/{gobject-introspection, libglib2}: bump to {1.82.0, 2.82.4}
Date: Tue, 4 Feb 2025 09:31:56 +0100	[thread overview]
Message-ID: <20250204093156.3a738f5f@windsurf> (raw)
In-Reply-To: <20250120211707.2381182-3-fiona.klute@gmx.de>

Hello Fiona,

As discussed yesterday on IRC, I'm planning on working on this topic
today. I already have a few questions, see below. More might come later.

On Mon, 20 Jan 2025 22:17:03 +0100
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> +# Bootstrap is only needed if building with introspection. Building
> +# with introspection for the target requires introspection to be
> +# enabled for host-libglib2, so checking if host introspection is to
> +# be built is sufficient.
> +ifeq ($(BR2_PACKAGE_HOST_GOBJECT_INTROSPECTION),y)
> +include package/libglib2/libglib2-bootstrap/libglib2-bootstrap.mk
> +endif

We generally include .mk files unconditionally, so I'll drop this
conditional include, and make it unconditional.

Note: please do not resend new iterations with fixes for now: I'm
applying the patches locally and adjusting things. If all goes well,
I'll be able to merge them today.

If you're on IRC at some point, feel free to provide the feedback
directly on IRC.

Thanks for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot