Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute via buildroot <buildroot@buildroot.org>
Cc: Fiona Klute <fiona.klute@gmx.de>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	James Hilliard <james.hilliard1@gmail.com>,
	Marcus Hoffmann <buildroot@bubu1.eu>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v9 0/6] libglib2 2.82 series with bootstrap
Date: Tue, 4 Feb 2025 16:33:03 +0100	[thread overview]
Message-ID: <20250204163303.0c57a2a1@windsurf> (raw)
In-Reply-To: <20250120211707.2381182-1-fiona.klute@gmx.de>

Hello Fiona,

On Mon, 20 Jan 2025 22:17:01 +0100
Fiona Klute via buildroot <buildroot@buildroot.org> wrote:

> Since 2.79.0 libglib2 needs to be bootstrapped without introspection
> support before gobject-introspection can be built, the added
> libglib2-bootstrap sub-package takes care of that. See NEWS:

You will not believe, but I've merged your series! First of all, thanks
a LOT for your work on this topic and your persistence. It's really
great to have someone who was brave enough to tackle this quite
complicated topic and push it to completion. Kudos to you for this!

Compared to your patch series, here is what I did:

- Added a fix for the network-manager package that was not building
  with toolchains using < 4.20 kernel headers. This was not initially
  related to your series, but since I tested your work with
  NetworkManager, I encountered the build issue.

- Added a fix for the Python SDBus NetworkManager test, which was
  failing because of the above issue.

- Added a new test case based on the info you have provided in your
  cover letter to test i11n with NetworkManager. I have assigned you as
  the maintainer of this test in the DEVELOPERS file. I hope this is OK
  for you of course.

I did one minor change in the libglib2.mk file also, I'll reply
separately to it.

Since your series contains a fairly significant update to libglib2, it
would be good to keep an eye on the autobuilders in the coming days for
potentially fallouts from this version bump (affecting other packages).

Once again, kudos and thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-02-04 15:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 21:17 [Buildroot] [PATCH v9 0/6] libglib2 2.82 series with bootstrap Fiona Klute via buildroot
2025-01-20 21:17 ` [Buildroot] [PATCH v9 1/6] package/json-glib: bump to version 1.10.6 Fiona Klute via buildroot
2025-01-20 21:17 ` [Buildroot] [PATCH v9 2/6] package/{gobject-introspection, libglib2}: bump to {1.82.0, 2.82.4} Fiona Klute via buildroot
2025-02-04  8:31   ` Thomas Petazzoni via buildroot
2025-01-20 21:17 ` [Buildroot] [PATCH v9 3/6] package/gobject-introspection: works with musl now Fiona Klute via buildroot
2025-01-20 21:17 ` [Buildroot] [PATCH v9 4/6] package/python-gobject: allow build with musl Fiona Klute via buildroot
2025-01-20 21:17 ` [Buildroot] [PATCH v9 5/6] package/python-gobject: bump to version 3.50.0 Fiona Klute via buildroot
2025-01-20 21:17 ` [Buildroot] [PATCH v9 6/6] package/network-manager: add optional dependency on gobject-introspection Fiona Klute via buildroot
2025-02-04 15:33 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250204163303.0c57a2a1@windsurf \
    --to=buildroot@buildroot.org \
    --cc=buildroot@bubu1.eu \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=fiona.klute@gmx.de \
    --cc=fontaine.fabrice@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox