[Buildroot] [PATCH] package/usbutils: select libiconv if needed

[Buildroot] [PATCH] package/usbutils: select libiconv if needed

[Sébastien Szymanski]

iconv.h is always included by usbmisc.c so select BR2_PACKAGE_LIBICONV
if !BR2_ENABLE_LOCALE

Fixes:
 http://autobuild.buildroot.net/results/d7d/d7dedb754804242d020d1a0d34dd95c7c1074710//
 http://autobuild.buildroot.net/results/bca/bca14ce4fe05f087e1d8821670ba3165e9820a7f//
 http://autobuild.buildroot.net/results/665/665c064bf28a325a8bc4d9fe16f453be48472e57//
 http://autobuild.buildroot.net/results/b54/b543a3713949571b04dbd9c94f063fa0a186765b//
 http://autobuild.buildroot.net/results/6ea/6ea6cde91c2c6c49f56a08f37fef0c134eda40a0//

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 package/usbutils/Config.in   | 1 +
 package/usbutils/usbutils.mk | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/package/usbutils/Config.in b/package/usbutils/Config.in
index a38eb2f2e50446334e326d47b9eedbe25023700c..7e7029bbfec6c6acc2b592c9156ed23de25bb330 100644
--- a/package/usbutils/Config.in
+++ b/package/usbutils/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_USBUTILS
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
 	depends on BR2_PACKAGE_HAS_UDEV # needs hwdb
+	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_LIBUSB
 	help
 	  USB enumeration utilities
diff --git a/package/usbutils/usbutils.mk b/package/usbutils/usbutils.mk
index 48301fbb9fd1d2b2d23d071bfb6193b16ea749c3..10939813608c2c79b958c6d4d7a0f6f0f20a7625 100644
--- a/package/usbutils/usbutils.mk
+++ b/package/usbutils/usbutils.mk
@@ -11,6 +11,11 @@ USBUTILS_DEPENDENCIES = host-pkgconf libusb udev
 USBUTILS_LICENSE = GPL-2.0+ (utils) GPL-2.0 or GPL-3.0 (lsusb.py)
 USBUTILS_LICENSE_FILES = LICENSES/GPL-2.0-only.txt LICENSES/GPL-3.0-only.txt
 
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+USBUTILS_DEPENDENCIES += libiconv
+USBUTILS_LDFLAGS += -liconv
+endif
+
 # Nice lsusb.py script only if there's python 3.x
 ifeq ($(BR2_PACKAGE_PYTHON3),)
 define USBUTILS_REMOVE_PYTHON

---
base-commit: b03098645f7473389f878fdf610def79e371cf45
change-id: 20250203-usbutils-libiconv-55fbd2778cef

Best regards,
-- 
Sébastien Szymanski <sebastien.szymanski@armadeus.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/usbutils: select libiconv if needed

[Thomas Petazzoni via buildroot]

On Tue, 04 Feb 2025 09:38:52 +0100
Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:

> iconv.h is always included by usbmisc.c so select BR2_PACKAGE_LIBICONV
> if !BR2_ENABLE_LOCALE

Have you been able to figure out since when this problem started
occurring, so we can understand whether the fix needs to be backported
to a stable branch or not?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/usbutils: select libiconv if needed

[Sébastien Szymanski]

On 2/4/25 3:47 PM, Thomas Petazzoni wrote:
> On Tue, 04 Feb 2025 09:38:52 +0100
> Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:
> 
>> iconv.h is always included by usbmisc.c so select BR2_PACKAGE_LIBICONV
>> if !BR2_ENABLE_LOCALE
> 
> Have you been able to figure out since when this problem started
> occurring, so we can understand whether the fix needs to be backported
> to a stable branch or not?

There is one failed build for the same reason for usbutils-015 [0]. On 
2024.02, we have usbutils-017 so it can be backported there I guess.

[0] 
http://autobuild.buildroot.net/results/a8e/a8e1961d91006fb6d99c0aaf3488a98af73e9143//

Regards,

> 
> Thanks!
> 
> Thomas


-- 
Sébastien Szymanski, Armadeus Systems
Software engineer
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/usbutils: select libiconv if needed

[Thomas Petazzoni]

On Tue, 4 Feb 2025 16:01:13 +0100
Sébastien Szymanski <sebastien.szymanski@armadeus.com> wrote:

> There is one failed build for the same reason for usbutils-015 [0]. On 
> 2024.02, we have usbutils-017 so it can be backported there I guess.
> 
> [0] 
> http://autobuild.buildroot.net/results/a8e/a8e1961d91006fb6d99c0aaf3488a98af73e9143//

A better commit message is then:

"Since upstream commit 7c7fed30f7553b551fce3151fe315cf69e602065, which
first appeared in usbutils version 007, iconv is used when available.
Since then, the package has been failing to build when libiconv needs
to be provided by a library external to the C library. This commit
fixes that by ..."

This way, we clearly retrace the origin of the problem, instead of
"guessing".

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot