Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/bmap-writer: add initial package
@ 2025-01-02 13:18 Ayoub Zaki
  0 siblings, 0 replies; 4+ messages in thread
From: Ayoub Zaki @ 2025-01-02 13:18 UTC (permalink / raw)
  To: buildroot; +Cc: Ayoub Zaki

Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
---
 DEVELOPERS                           |  3 +++
 package/Config.in                    |  1 +
 package/bmap-writer/Config.in        | 17 +++++++++++++++++
 package/bmap-writer/Config.in.host   | 10 ++++++++++
 package/bmap-writer/bmap-writer.hash |  3 +++
 package/bmap-writer/bmap-writer.mk   | 13 +++++++++++++
 6 files changed, 47 insertions(+)
 create mode 100644 package/bmap-writer/Config.in
 create mode 100644 package/bmap-writer/Config.in.host
 create mode 100644 package/bmap-writer/bmap-writer.hash
 create mode 100644 package/bmap-writer/bmap-writer.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 381bc9f490..2e66e3d8a7 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -3447,3 +3447,6 @@ F:	package/quazip/
 F:	package/shapelib/
 F:	package/simple-mail/
 F:	package/tinc/
+
+N:	Ayoub Zaki <ayoub.zaki@embetrix.com>
+F:	package/bmap-writer/
diff --git a/package/Config.in b/package/Config.in
index 17f458eee8..3b4af5f7eb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -215,6 +215,7 @@ menu "Filesystem and flash utilities"
 	source "package/aufs-util/Config.in"
 	source "package/autofs/Config.in"
 	source "package/bmap-tools/Config.in"
+	source "package/bmap-writer/Config.in"
 	source "package/btrfs-progs/Config.in"
 	source "package/cifs-utils/Config.in"
 	source "package/cpio/Config.in"
diff --git a/package/bmap-writer/Config.in b/package/bmap-writer/Config.in
new file mode 100644
index 0000000000..d65eda918c
--- /dev/null
+++ b/package/bmap-writer/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_BMAP_WRITER
+	bool "bmap-writer"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR
+	select BR2_PACKAGE_LIBARCHIVE
+	select BR2_PACKAGE_LIBXML2
+	help
+	  bmap-writer is a command-line utility designed to efficiently write
+	  disk images to storage devices using block mapping (BMAP). It serves
+	  as a lightweight alternative to the Yocto BMAP tool, specifically for
+	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
+	  does not require Python, and focuses solely on writing an image.
+
+	  https://github.com/embetrix/bmap-writer
+
+comment "bmap-writer needs a toolchain w/ C++, wchar"
+	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/bmap-writer/Config.in.host b/package/bmap-writer/Config.in.host
new file mode 100644
index 0000000000..d5bfd62f0a
--- /dev/null
+++ b/package/bmap-writer/Config.in.host
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_HOST_BMAP_WRITER
+	bool "host bmap-writer"
+	help
+	  bmap-writer is a command-line utility designed to efficiently write
+	  disk images to storage devices using block mapping (BMAP). It serves
+	  as a lightweight alternative to the Yocto BMAP tool, specifically for
+	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
+	  does not require Python, and focuses solely on writing an image.
+
+	  https://github.com/embetrix/bmap-writer
diff --git a/package/bmap-writer/bmap-writer.hash b/package/bmap-writer/bmap-writer.hash
new file mode 100644
index 0000000000..c59c7a91cb
--- /dev/null
+++ b/package/bmap-writer/bmap-writer.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  94fda8420fa82256bfd01a76dff18ae23c6be9be03cb641f9845164e9326de60  bmap-writer-0.0.3.tar.gz
+sha256  8b1ba204bb69a0ade2bfcf65ef294a920f6bb361b317dba43c7ef29d96332b9b  LICENSE
diff --git a/package/bmap-writer/bmap-writer.mk b/package/bmap-writer/bmap-writer.mk
new file mode 100644
index 0000000000..bbe4eb1078
--- /dev/null
+++ b/package/bmap-writer/bmap-writer.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# bmap-writer
+#
+################################################################################
+
+BMAP_WRITER_VERSION = 0.0.3
+BMAP_WRITER_SITE = $(call github,embetrix,bmap-writer,$(BMAP_WRITER_VERSION))
+BMAP_WRITER_LICENSE = GPL-3.0
+BMAP_WRITER_LICENSE_FILES = LICENSE
+BMAP_WRITER_DEPENDENCIES = host-pkgconf libarchive libxml2
+
+$(eval $(cmake-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v2] package/bmap-writer: add initial package
@ 2025-01-02 13:33 Ayoub Zaki
  2025-01-06  8:12 ` Ayoub Zaki
  2025-02-05 10:12 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Ayoub Zaki @ 2025-01-02 13:33 UTC (permalink / raw)
  To: buildroot; +Cc: Ayoub Zaki

Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
---
 DEVELOPERS                           |  3 +++
 package/Config.in                    |  1 +
 package/bmap-writer/Config.in        | 17 +++++++++++++++++
 package/bmap-writer/Config.in.host   | 10 ++++++++++
 package/bmap-writer/bmap-writer.hash |  3 +++
 package/bmap-writer/bmap-writer.mk   | 13 +++++++++++++
 6 files changed, 47 insertions(+)
 create mode 100644 package/bmap-writer/Config.in
 create mode 100644 package/bmap-writer/Config.in.host
 create mode 100644 package/bmap-writer/bmap-writer.hash
 create mode 100644 package/bmap-writer/bmap-writer.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 381bc9f490..2e66e3d8a7 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -3447,3 +3447,6 @@ F:	package/quazip/
 F:	package/shapelib/
 F:	package/simple-mail/
 F:	package/tinc/
+
+N:	Ayoub Zaki <ayoub.zaki@embetrix.com>
+F:	package/bmap-writer/
diff --git a/package/Config.in b/package/Config.in
index 17f458eee8..3b4af5f7eb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -215,6 +215,7 @@ menu "Filesystem and flash utilities"
 	source "package/aufs-util/Config.in"
 	source "package/autofs/Config.in"
 	source "package/bmap-tools/Config.in"
+	source "package/bmap-writer/Config.in"
 	source "package/btrfs-progs/Config.in"
 	source "package/cifs-utils/Config.in"
 	source "package/cpio/Config.in"
diff --git a/package/bmap-writer/Config.in b/package/bmap-writer/Config.in
new file mode 100644
index 0000000000..d65eda918c
--- /dev/null
+++ b/package/bmap-writer/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_BMAP_WRITER
+	bool "bmap-writer"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR
+	select BR2_PACKAGE_LIBARCHIVE
+	select BR2_PACKAGE_LIBXML2
+	help
+	  bmap-writer is a command-line utility designed to efficiently write
+	  disk images to storage devices using block mapping (BMAP). It serves
+	  as a lightweight alternative to the Yocto BMAP tool, specifically for
+	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
+	  does not require Python, and focuses solely on writing an image.
+
+	  https://github.com/embetrix/bmap-writer
+
+comment "bmap-writer needs a toolchain w/ C++, wchar"
+	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/bmap-writer/Config.in.host b/package/bmap-writer/Config.in.host
new file mode 100644
index 0000000000..d5bfd62f0a
--- /dev/null
+++ b/package/bmap-writer/Config.in.host
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_HOST_BMAP_WRITER
+	bool "host bmap-writer"
+	help
+	  bmap-writer is a command-line utility designed to efficiently write
+	  disk images to storage devices using block mapping (BMAP). It serves
+	  as a lightweight alternative to the Yocto BMAP tool, specifically for
+	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
+	  does not require Python, and focuses solely on writing an image.
+
+	  https://github.com/embetrix/bmap-writer
diff --git a/package/bmap-writer/bmap-writer.hash b/package/bmap-writer/bmap-writer.hash
new file mode 100644
index 0000000000..c59c7a91cb
--- /dev/null
+++ b/package/bmap-writer/bmap-writer.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  94fda8420fa82256bfd01a76dff18ae23c6be9be03cb641f9845164e9326de60  bmap-writer-0.0.3.tar.gz
+sha256  8b1ba204bb69a0ade2bfcf65ef294a920f6bb361b317dba43c7ef29d96332b9b  LICENSE
diff --git a/package/bmap-writer/bmap-writer.mk b/package/bmap-writer/bmap-writer.mk
new file mode 100644
index 0000000000..bbe4eb1078
--- /dev/null
+++ b/package/bmap-writer/bmap-writer.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# bmap-writer
+#
+################################################################################
+
+BMAP_WRITER_VERSION = 0.0.3
+BMAP_WRITER_SITE = $(call github,embetrix,bmap-writer,$(BMAP_WRITER_VERSION))
+BMAP_WRITER_LICENSE = GPL-3.0
+BMAP_WRITER_LICENSE_FILES = LICENSE
+BMAP_WRITER_DEPENDENCIES = host-pkgconf libarchive libxml2
+
+$(eval $(cmake-package))
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/bmap-writer: add initial package
  2025-01-02 13:33 [Buildroot] [PATCH v2] package/bmap-writer: add initial package Ayoub Zaki
@ 2025-01-06  8:12 ` Ayoub Zaki
  2025-02-05 10:12 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Ayoub Zaki @ 2025-01-06  8:12 UTC (permalink / raw)
  To: buildroot

Hello,

Please let me know if there are any further steps I need to take or 
additional input required to move forward with this patch.

Thank you!


On 02.01.25 14:33, Ayoub Zaki wrote:
> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>
> ---
>   DEVELOPERS                           |  3 +++
>   package/Config.in                    |  1 +
>   package/bmap-writer/Config.in        | 17 +++++++++++++++++
>   package/bmap-writer/Config.in.host   | 10 ++++++++++
>   package/bmap-writer/bmap-writer.hash |  3 +++
>   package/bmap-writer/bmap-writer.mk   | 13 +++++++++++++
>   6 files changed, 47 insertions(+)
>   create mode 100644 package/bmap-writer/Config.in
>   create mode 100644 package/bmap-writer/Config.in.host
>   create mode 100644 package/bmap-writer/bmap-writer.hash
>   create mode 100644 package/bmap-writer/bmap-writer.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 381bc9f490..2e66e3d8a7 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -3447,3 +3447,6 @@ F:	package/quazip/
>   F:	package/shapelib/
>   F:	package/simple-mail/
>   F:	package/tinc/
> +
> +N:	Ayoub Zaki <ayoub.zaki@embetrix.com>
> +F:	package/bmap-writer/
> diff --git a/package/Config.in b/package/Config.in
> index 17f458eee8..3b4af5f7eb 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -215,6 +215,7 @@ menu "Filesystem and flash utilities"
>   	source "package/aufs-util/Config.in"
>   	source "package/autofs/Config.in"
>   	source "package/bmap-tools/Config.in"
> +	source "package/bmap-writer/Config.in"
>   	source "package/btrfs-progs/Config.in"
>   	source "package/cifs-utils/Config.in"
>   	source "package/cpio/Config.in"
> diff --git a/package/bmap-writer/Config.in b/package/bmap-writer/Config.in
> new file mode 100644
> index 0000000000..d65eda918c
> --- /dev/null
> +++ b/package/bmap-writer/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_BMAP_WRITER
> +	bool "bmap-writer"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_USE_WCHAR
> +	select BR2_PACKAGE_LIBARCHIVE
> +	select BR2_PACKAGE_LIBXML2
> +	help
> +	  bmap-writer is a command-line utility designed to efficiently write
> +	  disk images to storage devices using block mapping (BMAP). It serves
> +	  as a lightweight alternative to the Yocto BMAP tool, specifically for
> +	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
> +	  does not require Python, and focuses solely on writing an image.
> +
> +	  https://github.com/embetrix/bmap-writer
> +
> +comment "bmap-writer needs a toolchain w/ C++, wchar"
> +	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/bmap-writer/Config.in.host b/package/bmap-writer/Config.in.host
> new file mode 100644
> index 0000000000..d5bfd62f0a
> --- /dev/null
> +++ b/package/bmap-writer/Config.in.host
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_HOST_BMAP_WRITER
> +	bool "host bmap-writer"
> +	help
> +	  bmap-writer is a command-line utility designed to efficiently write
> +	  disk images to storage devices using block mapping (BMAP). It serves
> +	  as a lightweight alternative to the Yocto BMAP tool, specifically for
> +	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
> +	  does not require Python, and focuses solely on writing an image.
> +
> +	  https://github.com/embetrix/bmap-writer
> diff --git a/package/bmap-writer/bmap-writer.hash b/package/bmap-writer/bmap-writer.hash
> new file mode 100644
> index 0000000000..c59c7a91cb
> --- /dev/null
> +++ b/package/bmap-writer/bmap-writer.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  94fda8420fa82256bfd01a76dff18ae23c6be9be03cb641f9845164e9326de60  bmap-writer-0.0.3.tar.gz
> +sha256  8b1ba204bb69a0ade2bfcf65ef294a920f6bb361b317dba43c7ef29d96332b9b  LICENSE
> diff --git a/package/bmap-writer/bmap-writer.mk b/package/bmap-writer/bmap-writer.mk
> new file mode 100644
> index 0000000000..bbe4eb1078
> --- /dev/null
> +++ b/package/bmap-writer/bmap-writer.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# bmap-writer
> +#
> +################################################################################
> +
> +BMAP_WRITER_VERSION = 0.0.3
> +BMAP_WRITER_SITE = $(call github,embetrix,bmap-writer,$(BMAP_WRITER_VERSION))
> +BMAP_WRITER_LICENSE = GPL-3.0
> +BMAP_WRITER_LICENSE_FILES = LICENSE
> +BMAP_WRITER_DEPENDENCIES = host-pkgconf libarchive libxml2
> +
> +$(eval $(cmake-package))

Mit freundlichen Grüßen / Kind regards

-- 
Ayoub Zaki
Embedded Systems Consultant

Vaihinger Straße 2/1
D-71634 Ludwigsburg

Mobile   : +4917662901545
Email    : ayoub.zaki@embetrix.com
Homepage : https://embetrix.com
VAT No.  : DE313902634

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH v2] package/bmap-writer: add initial package
  2025-01-02 13:33 [Buildroot] [PATCH v2] package/bmap-writer: add initial package Ayoub Zaki
  2025-01-06  8:12 ` Ayoub Zaki
@ 2025-02-05 10:12 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-02-05 10:12 UTC (permalink / raw)
  To: Ayoub Zaki; +Cc: buildroot

Hello,

On Thu,  2 Jan 2025 14:33:58 +0100
Ayoub Zaki <ayoub.zaki@embetrix.com> wrote:

> Signed-off-by: Ayoub Zaki <ayoub.zaki@embetrix.com>

Thanks for your patch. I applied it, but I had to fix a number of
things. See below my different comments.

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 381bc9f490..2e66e3d8a7 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -3447,3 +3447,6 @@ F:	package/quazip/
>  F:	package/shapelib/
>  F:	package/simple-mail/
>  F:	package/tinc/
> +
> +N:	Ayoub Zaki <ayoub.zaki@embetrix.com>
> +F:	package/bmap-writer/

This file is alphabetically sorted, but you had added this entry at the
end of the file, which isn't good.

> diff --git a/package/bmap-writer/Config.in b/package/bmap-writer/Config.in
> new file mode 100644
> index 0000000000..d65eda918c
> --- /dev/null
> +++ b/package/bmap-writer/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_BMAP_WRITER
> +	bool "bmap-writer"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_USE_WCHAR
> +	select BR2_PACKAGE_LIBARCHIVE
> +	select BR2_PACKAGE_LIBXML2
> +	help
> +	  bmap-writer is a command-line utility designed to efficiently write
> +	  disk images to storage devices using block mapping (BMAP). It serves
> +	  as a lightweight alternative to the Yocto BMAP tool, specifically for
> +	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
> +	  does not require Python, and focuses solely on writing an image.

These lines were too long. This is reported by "make check-package", so
I rewrapped them.

> +	  https://github.com/embetrix/bmap-writer
> +
> +comment "bmap-writer needs a toolchain w/ C++, wchar"
> +	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/bmap-writer/Config.in.host b/package/bmap-writer/Config.in.host
> new file mode 100644
> index 0000000000..d5bfd62f0a
> --- /dev/null
> +++ b/package/bmap-writer/Config.in.host
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_HOST_BMAP_WRITER
> +	bool "host bmap-writer"
> +	help
> +	  bmap-writer is a command-line utility designed to efficiently write
> +	  disk images to storage devices using block mapping (BMAP). It serves
> +	  as a lightweight alternative to the Yocto BMAP tool, specifically for
> +	  embedded systems. Unlike the Yocto BMAP tool, bmap-writer is C++ based,
> +	  does not require Python, and focuses solely on writing an image.

Same: lines too long.

Also, this file was not included anywhere, so it was useless. I added
the necessary include logic in package/Config.in.host.

> diff --git a/package/bmap-writer/bmap-writer.mk b/package/bmap-writer/bmap-writer.mk
> new file mode 100644
> index 0000000000..bbe4eb1078
> --- /dev/null
> +++ b/package/bmap-writer/bmap-writer.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# bmap-writer
> +#
> +################################################################################
> +
> +BMAP_WRITER_VERSION = 0.0.3
> +BMAP_WRITER_SITE = $(call github,embetrix,bmap-writer,$(BMAP_WRITER_VERSION))
> +BMAP_WRITER_LICENSE = GPL-3.0
> +BMAP_WRITER_LICENSE_FILES = LICENSE
> +BMAP_WRITER_DEPENDENCIES = host-pkgconf libarchive libxml2

Missing

HOST_BMAP_WRITER_DEPENDENCIES

> +
> +$(eval $(cmake-package))

Missing

$(eval $(host-cmake-package))

(which means you really didn't test the host version of the package).

I've applied after fixing those different issues. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-05 10:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-02 13:33 [Buildroot] [PATCH v2] package/bmap-writer: add initial package Ayoub Zaki
2025-01-06  8:12 ` Ayoub Zaki
2025-02-05 10:12 ` Thomas Petazzoni via buildroot
  -- strict thread matches above, loose matches on Subject: below --
2025-01-02 13:18 Ayoub Zaki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox