Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/swipl: fix build without C++ compiler
@ 2025-02-05 11:26 Peter Korsgaard
  2025-02-05 11:49 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2025-02-05 11:26 UTC (permalink / raw)
  To: buildroot; +Cc: Julien Olivain

Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef

Some of the optional packages in swipl are written in C++, so CMake thinks a
C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF.  Add
-DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without C++:

-- Check for working CXX compiler: /usr/bin/true
-- Check for working CXX compiler: /usr/bin/true - works

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/swipl/swipl.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/swipl/swipl.mk b/package/swipl/swipl.mk
index ef9aedcd2d..e29b8d8f46 100644
--- a/package/swipl/swipl.mk
+++ b/package/swipl/swipl.mk
@@ -36,7 +36,8 @@ SWIPL_CONF_OPTS = \
 	-DQSORT_R_GNU=1 \
 	-DSWIPL_NATIVE_FRIEND=$(HOST_SWIPL_SRCDIR) \
 	-DSWIPL_PACKAGES=OFF \
-	-DUSE_TCMALLOC=OFF
+	-DUSE_TCMALLOC=OFF \
+	-DCMAKE_CXX_COMPILER=true
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 SWIPL_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/swipl: fix build without C++ compiler
  2025-02-05 11:26 [Buildroot] [PATCH] package/swipl: fix build without C++ compiler Peter Korsgaard
@ 2025-02-05 11:49 ` Thomas Petazzoni
  2025-02-05 11:55   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2025-02-05 11:49 UTC (permalink / raw)
  To: Peter Korsgaard; +Cc: buildroot, Julien Olivain

On Wed,  5 Feb 2025 12:26:18 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

> Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef
> 
> Some of the optional packages in swipl are written in C++, so CMake thinks a
> C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF.  Add
> -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without C++:
> 
> -- Check for working CXX compiler: /usr/bin/true
> -- Check for working CXX compiler: /usr/bin/true - works
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/swipl/swipl.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, but you need to specify since when this problem started
occurring, so that whoever is going to evaluate this patch for backport
to our LTS branch will know what to do :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/swipl: fix build without C++ compiler
  2025-02-05 11:49 ` Thomas Petazzoni
@ 2025-02-05 11:55   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-02-05 11:55 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot, Julien Olivain

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Wed,  5 Feb 2025 12:26:18 +0100
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> Fixes http://autobuild.buildroot.net/results/b24a96b999676990995a466686fe1eacf6cddfef
 >> 
 >> Some of the optional packages in swipl are written in C++, so CMake thinks a
 >> C++ compiler is needed even though we build with -DSWIPL_PACKAGES=OFF.  Add
 >> -DCMAKE_CXX_COMPILER=true to satisfy this check even in setups without C++:
 >> 
 >> -- Check for working CXX compiler: /usr/bin/true
 >> -- Check for working CXX compiler: /usr/bin/true - works
 >> 
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> ---
 >> package/swipl/swipl.mk | 3 ++-
 >> 1 file changed, 2 insertions(+), 1 deletion(-)

 > Thanks, but you need to specify since when this problem started
 > occurring, so that whoever is going to evaluate this patch for backport
 > to our LTS branch will know what to do :-)

Argh, will resend.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-05 11:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 11:26 [Buildroot] [PATCH] package/swipl: fix build without C++ compiler Peter Korsgaard
2025-02-05 11:49 ` Thomas Petazzoni
2025-02-05 11:55   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox