Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/elfutils: enable zstd support for host package
@ 2024-12-07 20:28 Sergey Matyukevich
  2025-02-05 15:20 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 3+ messages in thread
From: Sergey Matyukevich @ 2024-12-07 20:28 UTC (permalink / raw)
  To: buildroot; +Cc: Sergey Matyukevich

Buildroot fails to build Linux kernel configurations where BTF support
is enabled together with zstd compression of debugging information.
The reason is in host-elfutils zstd support being explicitly disabled.
So enable zstd support in host-elfutils by default to fix such builds.

Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
---

v1 -> v2: rebase and update commit message

I already tried to send this patch back in August. But it looks like it
might have slipped through cracks. So I rebased and re-tested for v2.

 package/elfutils/elfutils.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/elfutils/elfutils.mk b/package/elfutils/elfutils.mk
index 8738af7751..1a1aca37b3 100644
--- a/package/elfutils/elfutils.mk
+++ b/package/elfutils/elfutils.mk
@@ -12,7 +12,7 @@ ELFUTILS_LICENSE = GPL-2.0+ or LGPL-3.0+ (library)
 ELFUTILS_LICENSE_FILES = COPYING COPYING-GPLV2 COPYING-LGPLV3
 ELFUTILS_CPE_ID_VALID = YES
 ELFUTILS_DEPENDENCIES = host-pkgconf zlib $(TARGET_NLS_DEPENDENCIES)
-HOST_ELFUTILS_DEPENDENCIES = host-pkgconf host-zlib host-bzip2 host-xz
+HOST_ELFUTILS_DEPENDENCIES = host-pkgconf host-zlib host-bzip2 host-xz host-zstd
 
 # We patch configure.ac
 ELFUTILS_AUTORECONF = YES
@@ -26,7 +26,7 @@ ELFUTILS_CONF_OPTS += \
 HOST_ELFUTILS_CONF_OPTS = \
 	--with-bzlib \
 	--with-lzma \
-	--without-zstd \
+	--with-zstd \
 	--disable-demangler \
 	--disable-progs
 
-- 
2.47.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/elfutils: enable zstd support for host package
  2024-12-07 20:28 [Buildroot] [PATCH v2] package/elfutils: enable zstd support for host package Sergey Matyukevich
@ 2025-02-05 15:20 ` Thomas Petazzoni via buildroot
  2025-02-09  7:47   ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-02-05 15:20 UTC (permalink / raw)
  To: Sergey Matyukevich; +Cc: buildroot

On Sat,  7 Dec 2024 23:28:52 +0300
Sergey Matyukevich <geomatsi@gmail.com> wrote:

> Buildroot fails to build Linux kernel configurations where BTF support
> is enabled together with zstd compression of debugging information.
> The reason is in host-elfutils zstd support being explicitly disabled.
> So enable zstd support in host-elfutils by default to fix such builds.
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---

Applied to master, thanks. I'm not a big fan of unconditionally adding
zstd support, as it adds build time, but we don't really have a simple
good way to make it optional, and other compression algos are already
unconditionally enabled.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/elfutils: enable zstd support for host package
  2025-02-05 15:20 ` Thomas Petazzoni via buildroot
@ 2025-02-09  7:47   ` Peter Korsgaard
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2025-02-09  7:47 UTC (permalink / raw)
  To: Thomas Petazzoni via buildroot; +Cc: Sergey Matyukevich, Thomas Petazzoni

>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:

 > On Sat,  7 Dec 2024 23:28:52 +0300
 > Sergey Matyukevich <geomatsi@gmail.com> wrote:

 >> Buildroot fails to build Linux kernel configurations where BTF support
 >> is enabled together with zstd compression of debugging information.
 >> The reason is in host-elfutils zstd support being explicitly disabled.
 >> So enable zstd support in host-elfutils by default to fix such builds.
 >> 
 >> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
 >> ---

 > Applied to master, thanks. I'm not a big fan of unconditionally adding
 > zstd support, as it adds build time, but we don't really have a simple
 > good way to make it optional, and other compression algos are already
 > unconditionally enabled.

Committed to 2024.02.x and 2024.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-09  7:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-07 20:28 [Buildroot] [PATCH v2] package/elfutils: enable zstd support for host package Sergey Matyukevich
2025-02-05 15:20 ` Thomas Petazzoni via buildroot
2025-02-09  7:47   ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox