From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Guillaume Chaye <guillaume.chaye@zeetim.com>
Cc: buildroot@buildroot.org, Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH 1/1] support/download/dl-wrapper: add basic support for smb file download using curl
Date: Sat, 19 Apr 2025 15:59:49 +0200 [thread overview]
Message-ID: <20250419155949.1b1f897e@windsurf> (raw)
In-Reply-To: <20250415164958.213674-1-guillaume.chaye@zeetim.com>
Hello Guillaume,
On Tue, 15 Apr 2025 12:50:01 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:
> This patch introduces a simpler approach to downloading files over the SMB protocol by using `curl` instead of `smbget`.
>
> Please let me know if you prefer this method, or if you'd prefer the other implementation.
Could you describe a bit the use-case?
Overall, if curl is able to retrieve files via SMB, I guess this patch
is the simplest solution, compared to your other patch that uses smbget.
Note that this needs a better commit log: explanation of the use-case,
no reference to the "other implementation", and text wrapped to 80
columns.
Also, I'm pretty sure updating the Buildroot manual is needed to
document this additional site method.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2025-04-19 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 16:50 [Buildroot] [PATCH 1/1] support/download/dl-wrapper: add basic support for smb file download using curl Guillaume Chaye
2025-04-19 13:59 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250419155949.1b1f897e@windsurf \
--to=buildroot@buildroot.org \
--cc=guillaume.chaye@zeetim.com \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox