[Buildroot] [PATCH 1/1] support/download/dl-wrapper: add basic support for smb file download using curl

[Buildroot] [PATCH 1/1] support/download/dl-wrapper: add basic support for smb file download using curl

[Guillaume Chaye]

Hi,

This patch introduces a simpler approach to downloading files over the SMB protocol by using `curl` instead of `smbget`.

Please let me know if you prefer this method, or if you'd prefer the other implementation.

Thanks,
Guillaume

Signed-off-by: Guillaume Chaye <guillaume.chaye@zeetim.com>
---
 package/pkg-generic.mk      | 2 +-
 support/download/dl-wrapper | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index f22b6e981a..95ff9135bd 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -1260,7 +1260,7 @@ else ifeq ($$($(2)_SITE_METHOD),hg)
 DL_TOOLS_DEPENDENCIES += hg
 else ifeq ($$($(2)_SITE_METHOD),cvs)
 DL_TOOLS_DEPENDENCIES += cvs
-else ifneq ($(filter ftp ftps,$$($(2)_SITE_METHOD)),)
+else ifneq ($(filter ftp ftps smb,$$($(2)_SITE_METHOD)),)
 DL_TOOLS_DEPENDENCIES += curl
 endif # SITE_METHOD
 
diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
index 5445aad5a7..b70c8edbd9 100755
--- a/support/download/dl-wrapper
+++ b/support/download/dl-wrapper
@@ -96,7 +96,7 @@ main() {
         backend="${backend_urlencode%|*}"
         case "${backend}" in
             git|svn|cvs|bzr|file|scp|hg|sftp) ;;
-            ftp|ftps) backend="curl" ;;
+            ftp|ftps|smb) backend="curl" ;;
             *) backend="wget" ;;
         esac
         uri=${uri#*+}
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/download/dl-wrapper: add basic support for smb file download using curl

[Thomas Petazzoni via buildroot]

Hello Guillaume,

On Tue, 15 Apr 2025 12:50:01 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:

> This patch introduces a simpler approach to downloading files over the SMB protocol by using `curl` instead of `smbget`.
> 
> Please let me know if you prefer this method, or if you'd prefer the other implementation.

Could you describe a bit the use-case?

Overall, if curl is able to retrieve files via SMB, I guess this patch
is the simplest solution, compared to your other patch that uses smbget.

Note that this needs a better commit log: explanation of the use-case,
no reference to the "other implementation", and text wrapped to 80
columns.

Also, I'm pretty sure updating the Buildroot manual is needed to
document this additional site method.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot