Re: [Buildroot] [PATCH 2/9] package/libcamera: fix documentation being built even if disabled

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Quentin Schulz <foss+buildroot@0leil.net>
Cc: buildroot@buildroot.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [Buildroot] [PATCH 2/9] package/libcamera: fix documentation being built even if disabled
Date: Sat, 19 Apr 2025 22:26:24 +0200	[thread overview]
Message-ID: <20250419222624.238f31c4@windsurf> (raw)
In-Reply-To: <20250404-libcamera-0-5-0-v1-2-e2ca9d029aeb@cherry.de>

On Fri, 04 Apr 2025 18:47:33 +0200
Quentin Schulz <foss+buildroot@0leil.net> wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> We currently disable building the documentation via the "documentation"
> feature, but it is enabled nonetheless by meson if sphinx-build-3 is
> found on the host.
> 
> This makes sure it doesn't happen by making the sphinx-build-3 check
> only happen when the "documentation" feature is "auto" or "enabled",
> which isn't the case for Buildroot.
> 
> The bug seems to have been introduced in v0.0.1 release.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>  ...t-automatically-build-documentation-if-sp.patch | 42 ++++++++++++++++++++++
>  1 file changed, 42 insertions(+)

Applied to master, thanks. However, you got some feedback from upstream
that requested some changes in order for the patch to get merged. Do
you think you will have the chance to follow-up with upstream? (Or
maybe you did and I didn't see it?)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot