Re: [Buildroot] [PATCH 3/9] package/libcamera: fix crash on Rockchip with kernels before 6.4

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Quentin Schulz <foss+buildroot@0leil.net>
Cc: buildroot@buildroot.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Marcus Folkesson <marcus.folkesson@gmail.com>,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [Buildroot] [PATCH 3/9] package/libcamera: fix crash on Rockchip with kernels before 6.4
Date: Sat, 19 Apr 2025 22:26:48 +0200	[thread overview]
Message-ID: <20250419222648.109fca9d@windsurf> (raw)
In-Reply-To: <20250404-libcamera-0-5-0-v1-3-e2ca9d029aeb@cherry.de>

On Fri, 04 Apr 2025 18:47:34 +0200
Quentin Schulz <foss+buildroot@0leil.net> wrote:

> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> libcamera migrated to use an ioctl for detecting frame sizes which is
> only available in kernels 6.4 and later. If it doesn't exist, default
> frame sizes are used. However the min and max resolutions supported by
> the pipeline weren't initialized for kernels where that ioctl isn't
> available and ended up creating invalid configuration that later
> crashed.
> 
> The introducing commit was part of the v0.4.0 release.
> 
> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>  ...amera-rkisp1-Eliminate-hard-coded-resizer.patch | 110 +++++++++++++++++++++
>  1 file changed, 110 insertions(+)

I didn't merged this one for now, as the feedback from upstream isn't
very clear, and it doesn't seem like it has been merged yet. Could you
clarify this?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot