Re: [Buildroot] [PATCH v2 14/18] package/qoriq-mc-binary: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Vladimir,

On Fri, 28 Mar 2025 20:04:22 +0200
Vladimir Oltean <olteanv@gmail.com> wrote:

> Add a package which deploys the NXP MC (Management Complex) firmware
> to the target. This is necessary for NXP DPAA2 SoCs (LS1088A, LS2080A,
> LS2088A, LX2160A).

[...]

Thanks for the patch, which I have applied, after doing one small
change, see below.

> +QORIQ_MC_BINARY_VERSION = 10.39.0
> +QORIQ_MC_BINARY_SITE = $(call github,nxp-qoriq,qoriq-mc-binary,mc_release_$(QORIQ_MC_BINARY_VERSION))
> +QORIQ_MC_BINARY_LICENSE = NXP Binary EULA
> +QORIQ_MC_BINARY_LICENSE_FILES = LICENSE
> +QORIQ_MC_BINARY_INSTALL_IMAGES = YES
> +ifeq ($(BR2_PACKAGE_QORIQ_MC_BINARY_TARGET_INSTALL_PATH),)
> +QORIQ_MC_BINARY_INSTALL_TARGET = NO
> +endif

This condition would never be true, because
$(BR2_PACKAGE_QORIQ_MC_BINARY_TARGET_INSTALL_PATH) is never empty. Even
when the Kconfig option is left empty,
$(BR2_PACKAGE_QORIQ_MC_BINARY_TARGET_INSTALL_PATH) value is "", which
is why we have qstrip.

> +QORIQ_MC_BINARY_PLATFORM = $(call qstrip,$(BR2_QORIQ_MC_BINARY_PLATFORM))
> +QORIQ_MC_BINARY_SUBDIR = $(call qstrip,$(BR2_QORIQ_MC_BINARY_SUBDIR))
> +QORIQ_MC_BINARY_BIN = mc_$(QORIQ_MC_BINARY_PLATFORM)_$(QORIQ_MC_BINARY_VERSION).itb
> +QORIQ_MC_BINARY_INSTALL_PATH = $(call qstrip,$(BR2_PACKAGE_QORIQ_MC_BINARY_TARGET_INSTALL_PATH))

So I moved this condition here, testing on QORIQ_MC_BINARY_INSTALL_PATH
instead, which achieves correct behavior.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot