Re: [Buildroot] [PATCH v2 16/18] package/qoriq-restool: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: buildroot@buildroot.org, Ioana Ciornei <ciorneiioana@gmail.com>,
	Brandon Maier <Brandon.Maier@collins.com>,
	Vincent Jardin <vjardin@free.fr>, Julien Olivain <ju.o@free.fr>,
	Romain Naour <romain.naour@smile.fr>,
	Akhilesh Nema <nemaakhilesh@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 16/18] package/qoriq-restool: new package
Date: Tue, 22 Apr 2025 23:36:49 +0200	[thread overview]
Message-ID: <20250422233649.5574293c@windsurf> (raw)
In-Reply-To: <20250328180427.3434693-17-olteanv@gmail.com>

Hello Vlad,

On Fri, 28 Mar 2025 20:04:24 +0200
Vladimir Oltean <olteanv@gmail.com> wrote:

> Introduce a package for the restool program, which permits the user to
> modify the network configuration of the DPAA2 subsystem and create one
> that is adequate to their use case.
> 
> We integrate the master branch, which is the lf-6.12.3-1.0.0 tag plus
> commit 14a9058c772b ("manpage: it should be optional"). It was pointed
> out on previous patch submissions that the "make install" target also
> converts man pages from Markdown to groff using pandoc, and apart from
> the fact that Buildroot doesn't want manpages, pandoc is also too heavy
> to drag into the build system. So that feedback was considered valid and
> the patch is included here via upstream.
> 
> Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
> Reviewed-by: Vincent Jardin <vjardin@free.fr>
> ---
> v1->v2: integrate a patch from Vincent

I wanted to apply this, but unfortunately, the C code fails badly to
compile on ARM 32-bit:

mc_v10/fsl_mc_cmd.h:56:42: error: right shift count >= width of type [-Werror=shift-count-overflow]
   56 |                 (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
      |                                          ^~

(lots of similar issues)

dpmac_commands.c: In function ‘print_dpmac_counters’:
dpmac_commands.c:330:31: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
  330 |                 printf("%s: %lu\n", dpaa2_mac_counters[i].name, counter_value);

Seems like it's probably never been built for 32-bit targets. If you
only use it on ARM64, one option is "depends on BR2_aarch64".
Otherwise, those issues need to be addressed.

Minimal reproducer:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_QORIQ_RESTOOL=y
# BR2_TARGET_ROOTFS_TAR is not set

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot