Re: [Buildroot] [PATCH v4 2/3] package/grout: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Maxime,

Thanks for your patch! I have applied it, after doing a number of
changes, see below.

On Thu,  3 Apr 2025 17:39:49 +0200
Maxime Leroy <maxime@leroys.fr> wrote:

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 1c84f95943..1cbbf829c5 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2384,6 +2384,9 @@ F:	package/libtraceevent/
>  F:	package/libtracefs
>  F:	package/linux-tools/linux-tool-rtla.mk.in
>  
> +N:	Maxime Leroy <maxime@leroys.fr>
> +F:	package/grout

                     ^^ Nit: missing final slash.


> diff --git a/package/grout/Config.in b/package/grout/Config.in
> new file mode 100644
> index 0000000000..a39c3283eb
> --- /dev/null
> +++ b/package/grout/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_GROUT
> +	bool "grout"
> +	depends on BR2_ENABLE_LOCALE

I really wasn't sure about this dependency, because that doesn't
guarantee you that a UTF-8 locale is present, only that the toolchain
has locale support, which is different. So I dropped this dependency.

However, you had forgotten to replicate the dependencies of the options
you select, so I had to add:

+       depends on BR2_PACKAGE_DPDK_ARCH_SUPPORTS # dpdk
+       depends on BR2_TOOLCHAIN_HAS_THREADS # dpdk
+       depends on BR2_USE_MMU # dpdk, numactl, libecoli, util-linux-smartcols, libcap
+       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # dpdk
+       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19 # dpdk
+       depends on BR2_TOOLCHAIN_USES_GLIBC # dpdk
+       depends on BR2_TOOLCHAIN_HAS_ATOMIC # numactl
+       depends on !BR2_STATIC_LIBS # libecoli
+       depends on BR2_USE_WCHAR # libecoli

> +	select BR2_PACKAGE_DPDK
> +	select BR2_PACKAGE_LIBEVENT
> +	select BR2_PACKAGE_NUMACTL
> +	select BR2_PACKAGE_LIBECOLI
> +	select BR2_PACKAGE_UTIL_LINUX
> +	select BR2_PACKAGE_UTIL_LINUX_LIBSMARTCOLS

libcap was missing here, it is required by grout, so I added:

+       select BR2_PACKAGE_LIBCAP

(at the proper location to preserve alphabetic ordering)

> +	help
> +	  Graph router based on DPDK
> +
> +	  NOTE: grout needs a working UTF-8 locale (BR2_GENERATE_LOCALE)

The Config.in comment about the dependencies was missing, so I added
this:

+comment "grout needs a glibc toolchain w/ dynamic library, threads, wchar, gcc >= 4.9, headers >= 4.19"
+       depends on BR2_USE_MMU
+       depends on BR2_PACKAGE_DPDK_ARCH_SUPPORTS
+       depends on BR2_TOOLCHAIN_HAS_ATOMIC
+       depends on !BR2_TOOLCHAIN_HAS_THREADS || \
+               !BR2_TOOLCHAIN_USES_GLIBC || \
+               !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+               !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19

> diff --git a/package/grout/grout.mk b/package/grout/grout.mk
> new file mode 100644
> index 0000000000..a75af27978
> --- /dev/null
> +++ b/package/grout/grout.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# grout
> +#
> +################################################################################
> +
> +GROUT_VERSION = 0.9.0

Since 0.9.1 was out, I used this one instead.

> +GROUT_SITE = https://github.com/DPDK/grout/archive/refs/tags
> +GROUT_SOURCE = v$(GROUT_VERSION).tar.gz

I used the github macro instead, because you're anyway using the
auto-generated tarball:

+GROUT_SITE = $(call github,DPDK,grout,v$(GROUT_VERSION))

> +GROUT_LICENSE = BSD-3-Clause
> +GROUT_LICENSE_FILES = LICENSE
> +
> +# Avoid using buildroot commit hash
> +GROUT_CONF_ENV += GROUT_VERSION=$(GROUT_VERSION)
> +
> +GROUT_DEPENDENCIES = \
> +	host-pkgconf \
> +	dpdk \

I added libcap here.

> +	libevent \
> +	numactl \
> +	libecoli \
> +	util-linux
> +
> +$(eval $(meson-package))

Applied with all those changes, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot