Re: [Buildroot] [PATCH v4 2/3] package/grout: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Maxime,

On Fri, 25 Apr 2025 10:19:12 +0200
Maxime Leroy <maxime@leroys.fr> wrote:

> Grout needs to have UTF-8 local present to run, else it doesn't
> properly start.

Problem is that BR2_ENABLE_LOCALE doesn't tell you an UTF-8 locale is
available. We have no mechanism right now in Buildroot to enforce
having a UTF-8 locale. It could be added separately.

> > +       depends on BR2_PACKAGE_DPDK_ARCH_SUPPORTS # dpdk
> > +       depends on BR2_TOOLCHAIN_HAS_THREADS # dpdk
> > +       depends on BR2_USE_MMU # dpdk, numactl, libecoli, util-linux-smartcols, libcap
> > +       depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # dpdk
> > +       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19 # dpdk
> > +       depends on BR2_TOOLCHAIN_USES_GLIBC # dpdk
> > +       depends on BR2_TOOLCHAIN_HAS_ATOMIC # numactl
> > +       depends on !BR2_STATIC_LIBS # libecoli
> > +       depends on BR2_USE_WCHAR # libecoli  
> 
> Thanks. I am not very familiar about dependencies with buildroot.
> I was planning to change 'select on' to depends on 'DPDK' on a V4 serie.

Using a "depends on" for DPDK could have made sense indeed. But the
other libraries need to be "select"ed, and therefore you anyway need to
inherit their "depends on".

> I thought having a dependencies with DPDK, will be enough to inherit
> of this one.

Nope, that a Kconfig limitation. If you "select" something, you don't
inherit the "depends on" of the thing you select.

> In fact, libcap dependencies was introduced with grout 9.1 released.
> It was not needed for grout 9.0. Thanks for the upgrade.

Ah indeed, that explains it! Thanks for clarifying.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot