[Buildroot] [PATCH 1/1] Revert "package/mesa3d: Gallium VC4 driver depends on NEON"

[Buildroot] [PATCH 1/1] Revert "package/mesa3d: Gallium VC4 driver depends on NEON"

[Gaël PORTAY]

This reverts commit a5cdb54ed78b136c83dd44aebfa27f715cda5ea3.

The Gallium VC4 driver does not require NEON[1]; Gallium V3D does.

This removes the depends on BR2_ARM_CPU_HAS_NEON config to build Gallium
VC4 on Raspberry Pi, Raspberry Pi Zero and Compute Module.

Note: kmscube with OpenGLES and Gallium/VC4 runs on Raspberry Pi B+ Rev
1.2.

	# uname -a
	Linux buildroot 6.12.20 #1 Fri Apr 25 02:54:03 CEST 2025 armv6l GNU/Linux

	# cat /sys/firmware/devicetree/base/model
	Raspberry Pi Model B Plus Rev 1.2#

	# dmesg
	(...)
	[   39.817806] rpi-gpiomem 20200000.gpiomem: window base 0x20200000 size 0x00001000
	[   39.837139] rpi-gpiomem 20200000.gpiomem: initialised 1 regions as /dev/gpiomem
	[   40.693845] Console: switching to colour dummy device 80x30
	[   40.717223] vc4-drm soc:gpu: bound 20400000.hvs (ops vc4_hvs_ops [vc4])
	[   40.793911] vc4-drm soc:gpu: bound 20400000.hvs (ops vc4_hvs_ops [vc4])
	[   40.824330] Registered IR keymap rc-cec
	[   40.828596] rc rc0: vc4-hdmi as /devices/platform/soc/20902000.hdmi/rc/rc0
	[   40.844139] input: vc4-hdmi as /devices/platform/soc/20902000.hdmi/rc/rc0/input0
	[   40.873434] input: vc4-hdmi HDMI Jack as /devices/platform/soc/20902000.hdmi/sound/card0/input1
	[   40.895848] vc4-drm soc:gpu: bound 20902000.hdmi (ops vc4_hdmi_ops [vc4])
	[   40.914034] vc4-drm soc:gpu: bound 20004000.txp (ops vc4_txp_ops [vc4])
	[   40.921843] vc4-drm soc:gpu: bound 20206000.pixelvalve (ops vc4_crtc_ops [vc4])
	[   40.943543] vc4-drm soc:gpu: bound 20207000.pixelvalve (ops vc4_crtc_ops [vc4])
	[   40.951969] vc4-drm soc:gpu: bound 20807000.pixelvalve (ops vc4_crtc_ops [vc4])
	[   40.983322] vc4-drm soc:gpu: bound 20c00000.v3d (ops vc4_v3d_ops [vc4])
	[   41.010210] [drm] Initialized vc4 0.0.0 for soc:gpu on minor 0
	[   41.151906] Console: switching to colour frame buffer device 240x67
	[   41.223414] vc4-drm soc:gpu: [drm] fb0: vc4drmfb frame buffer device

	# kmscube
	Using display 0x1f12530 with EGL version 1.4
	===================================
	EGL information:
	  version: "1.4"
	  vendor: "Mesa Project"
	  client extensions: "EGL_EXT_client_extensions EGL_EXT_device_base EGL_EXT_device_enumeration EGL_EXT_device_query EGL_EXT_platform_base EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_EXT_platform_device EGL_EXT_explicit_device EGL_MESA_platform_gbm EGL_KHR_platform_gbm EGL_MESA_platform_surfaceless"
	  display extensions: "EGL_ANDROID_blob_cache EGL_ANDROID_native_fence_sync EGL_EXT_buffer_age EGL_EXT_image_dma_buf_import EGL_EXT_image_dma_buf_import_modifiers EGL_KHR_cl_event2 EGL_KHR_config_attribs EGL_KHR_context_flush_control EGL_KHR_create_context EGL_KHR_create_context_no_error EGL_KHR_fence_sync EGL_KHR_get_all_proc_addresses EGL_KHR_gl_colorspace EGL_KHR_gl_renderbuffer_image EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_image EGL_KHR_image_base EGL_KHR_image_pixmap EGL_KHR_no_config_context EGL_KHR_reusable_sync EGL_KHR_surfaceless_context EGL_EXT_pixel_format_float EGL_KHR_wait_sync EGL_MESA_configless_context EGL_MESA_drm_image EGL_MESA_gl_interop EGL_MESA_image_dma_buf_export EGL_MESA_query_driver "
	===================================
	OpenGL ES 2.x information:
	  version: "OpenGL ES 2.0 Mesa 24.0.9"
	  shading language version: "OpenGL ES GLSL ES 1.0.16"
	  vendor: "Broadcom"
	  renderer: "VC4 V3D 2.1"
	  extensions: "GL_EXT_blend_minmax GL_EXT_multi_draw_arrays GL_EXT_texture_compression_s3tc GL_EXT_texture_compression_dxt1 GL_EXT_texture_format_BGRA8888 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth24 GL_OES_element_index_uint GL_OES_fbo_render_mipmap GL_OES_mapbuffer GL_OES_rgb8_rgba8 GL_OES_stencil8 GL_OES_texture_npot GL_OES_vertex_half_float GL_OES_EGL_image GL_OES_depth_texture GL_AMD_performance_monitor GL_OES_packed_depth_stencil GL_OES_get_program_binary GL_APPLE_texture_max_level GL_EXT_discard_framebuffer GL_EXT_read_format_bgra GL_NV_pack_subimage GL_NV_texture_barrier GL_EXT_frag_depth GL_NV_fbo_color_attachments GL_OES_EGL_image_external GL_OES_EGL_sync GL_OES_vertex_array_object GL_ANGLE_pack_reverse_row_order GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_EXT_unpack_subimage GL_NV_draw_buffers GL_NV_read_buffer GL_NV_read_depth GL_NV_read_depth_stencil GL_NV_read_stencil GL_APPLE_sync GL_EXT_draw_buffers GL_EXT_map_buffer_range GL_KHR_debug GL_KHR_texture_compression_astc_ldr GL_NV_generate_mipmap_sRGB GL_NV_pixel_buffer_object GL_OES_required_internalformat GL_OES_surfaceless_context GL_EXT_debug_label GL_EXT_separate_shader_objects GL_EXT_compressed_ETC1_RGB8_sub_texture GL_EXT_draw_elements_base_vertex GL_EXT_texture_border_clamp GL_KHR_context_flush_control GL_OES_draw_elements_base_vertex GL_OES_texture_border_clamp GL_KHR_no_error GL_KHR_texture_compression_astc_sliced_3d GL_EXT_texture_compression_s3tc_srgb GL_KHR_parallel_shader_compile GL_MESA_tile_raster_order GL_MESA_sampler_objects GL_MESA_bgra "
	===================================
	Rendered 120 frames in 2.000020 sec (59.999400 fps)

[1]: https://gitlab.freedesktop.org/mesa/mesa/-/commit/932ed9c00b99e6ec92146ec9e820f546cf3e6551

Signed-off-by: Gaël PORTAY <gael.portay+rtone@gmail.com>
---
Hello,

I have tested it on Raspberry Pi 1 only to run OpenGLES things (kmscube,
qt gui examples).

Regards,
Gaël PORTAY
 package/mesa3d/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 0412998214..dd016c8b0f 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -257,7 +257,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_V3D
 
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4
 	bool "Gallium vc4 driver"
-	depends on (BR2_arm && BR2_ARM_CPU_HAS_NEON) || BR2_aarch64
+	depends on BR2_arm || BR2_aarch64
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 || !BR2_PACKAGE_XORG7 # libxshmfence
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_VC4
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/mesa3d: Gallium VC4 driver depends on NEON"

[Thomas Petazzoni via buildroot]

Hello Gaël,

On Fri, 25 Apr 2025 04:06:34 +0200
Gaël PORTAY <gael.portay+rtone@gmail.com> wrote:

> This reverts commit a5cdb54ed78b136c83dd44aebfa27f715cda5ea3.

This commit points to it resolving a build failure. How reverting the
commit will continue to fix the build issue? Or do you say that the
build issue does not exist?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Revert "package/mesa3d: Gallium VC4 driver depends on NEON"

[Thomas Petazzoni via buildroot]

Hello Gaël,

On Fri, 25 Apr 2025 04:06:34 +0200
Gaël PORTAY <gael.portay+rtone@gmail.com> wrote:

> This reverts commit a5cdb54ed78b136c83dd44aebfa27f715cda5ea3.

This commit points to it resolving a build failure. How reverting the
commit will continue to fix the build issue? Or do you say that the
build issue does not exist?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot