[Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Joseph Zikusooka (ZIK)]

This is a temporary workaround to address build issues with host-m4 when using GCC 15, as encountered on
the recently released Fedora 42. The issue stems from stricter compiler behavior introduced in recent
versions of GCC.

A proper fix has already been committed upstream and will be included in the next release of GNU m4:
https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=a22c9802dd7e724eaefb21dc21d84ac2d3a49c89

Until that version is available in buildroot, this patch ensures continued compatibility and successful
builds.

More context:
https://lists.buildroot.org/pipermail/buildroot/2025-April/776922.html

Signed-off-by: Joseph Zikusooka (ZIK) <zik@jambula.net>
---
 package/m4/m4.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/m4/m4.mk b/package/m4/m4.mk
index 39ad898b10..ab8e194b06 100644
--- a/package/m4/m4.mk
+++ b/package/m4/m4.mk
@@ -10,4 +10,6 @@ M4_SITE = $(BR2_GNU_MIRROR)/m4
 M4_LICENSE = GPL-3.0+
 M4_LICENSE_FILES = COPYING
 
+HOST_M4_CONF_ENV = CFLAGS="$(HOST_CFLAGS) -std=gnu17"
+
 $(eval $(host-autotools-package))
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Luca Ceresoli via buildroot]

Hello Joseph,

thanks for your patch!

On Sat,  3 May 2025 14:43:39 +0300
"Joseph Zikusooka (ZIK)" <josephzik@gmail.com> wrote:

> This is a temporary workaround to address build issues with host-m4 when using GCC 15, as encountered on
> the recently released Fedora 42. The issue stems from stricter compiler behavior introduced in recent
> versions of GCC.
> 
> A proper fix has already been committed upstream and will be included in the next release of GNU m4:
> https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=a22c9802dd7e724eaefb21dc21d84ac2d3a49c89
> 
> Until that version is available in buildroot, this patch ensures continued compatibility and successful
> builds.
> 
> More context:
> https://lists.buildroot.org/pipermail/buildroot/2025-April/776922.html
> 
> Signed-off-by: Joseph Zikusooka (ZIK) <zik@jambula.net>

The patch diff is identical to v1, thus you could have copied the
Tested-by tags you got.

Anyway:

[Tested v1, but v2 has the same diff]
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Also, adding a changelog after the '---' line is useful.

E.g.:

Changes in v2:
- reworded commit message (no diff changes)

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Joseph Zikusooka (ZIK)]

This is a temporary workaround to address build issues with host-m4 when using GCC 15, as encountered on
the recently released Fedora 42. The issue stems from stricter compiler behavior introduced in recent
versions of GCC.

A proper fix has already been committed upstream and will be included in the next release of GNU m4:
https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=a22c9802dd7e724eaefb21dc21d84ac2d3a49c89

Until that version is available in buildroot, this patch ensures continued compatibility and successful
builds.

More context:
https://lists.buildroot.org/pipermail/buildroot/2025-April/776922.html

Signed-off-by: Joseph Zikusooka (ZIK) <zik@jambula.net>
Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
[Tested v1, but v2 has the same diff]

---
Changes v1 -> v2:
  - reworded commit message (no diff changes)

 package/m4/m4.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/m4/m4.mk b/package/m4/m4.mk
index 39ad898b10..ab8e194b06 100644
--- a/package/m4/m4.mk
+++ b/package/m4/m4.mk
@@ -10,4 +10,6 @@ M4_SITE = $(BR2_GNU_MIRROR)/m4
 M4_LICENSE = GPL-3.0+
 M4_LICENSE_FILES = COPYING
 
+HOST_M4_CONF_ENV = CFLAGS="$(HOST_CFLAGS) -std=gnu17"
+
 $(eval $(host-autotools-package))
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Julien Olivain]

Hi Joseph,

On 03/05/2025 15:52, Joseph Zikusooka (ZIK) wrote:
> This is a temporary workaround to address build issues with host-m4 
> when using GCC 15, as encountered on
> the recently released Fedora 42. The issue stems from stricter compiler 
> behavior introduced in recent
> versions of GCC.
> 
> A proper fix has already been committed upstream and will be included 
> in the next release of GNU m4:
> https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=a22c9802dd7e724eaefb21dc21d84ac2d3a49c89
> 
> Until that version is available in buildroot, this patch ensures 
> continued compatibility and successful
> builds.
> 
> More context:
> https://lists.buildroot.org/pipermail/buildroot/2025-April/776922.html
> 
> Signed-off-by: Joseph Zikusooka (ZIK) <zik@jambula.net>

I applied this patch to master. I reworded the commit log and
applied the workaround only when host gcc-15 is detected. See:
https://gitlab.com/buildroot.org/buildroot/-/commit/7a07a9d155b8f601d68f07ee0ed1dc8d48907644

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Joseph Zikusooka]

[-- Attachment #1.1: Type: text/plain, Size: 1162 bytes --]

Thanks!

On Sun, May 4, 2025, 8:45 PM Julien Olivain <ju.o@free.fr> wrote:

> Hi Joseph,
>
> On 03/05/2025 15:52, Joseph Zikusooka (ZIK) wrote:
> > This is a temporary workaround to address build issues with host-m4
> > when using GCC 15, as encountered on
> > the recently released Fedora 42. The issue stems from stricter compiler
> > behavior introduced in recent
> > versions of GCC.
> >
> > A proper fix has already been committed upstream and will be included
> > in the next release of GNU m4:
> >
> https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=a22c9802dd7e724eaefb21dc21d84ac2d3a49c89
> >
> > Until that version is available in buildroot, this patch ensures
> > continued compatibility and successful
> > builds.
> >
> > More context:
> > https://lists.buildroot.org/pipermail/buildroot/2025-April/776922.html
> >
> > Signed-off-by: Joseph Zikusooka (ZIK) <zik@jambula.net>
>
> I applied this patch to master. I reworded the commit log and
> applied the workaround only when host gcc-15 is detected. See:
>
> https://gitlab.com/buildroot.org/buildroot/-/commit/7a07a9d155b8f601d68f07ee0ed1dc8d48907644
>
> Best regards,
>
> Julien.
>

[-- Attachment #1.2: Type: text/html, Size: 2110 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/m4: fix build failure with gcc 15

[Arnout Vandecappelle via buildroot]

On 03/05/2025 15:52, Joseph Zikusooka (ZIK) wrote:
> This is a temporary workaround to address build issues with host-m4 when using GCC 15, as encountered on
> the recently released Fedora 42. The issue stems from stricter compiler behavior introduced in recent
> versions of GCC.
> 
> A proper fix has already been committed upstream and will be included in the next release of GNU m4:
> https://git.savannah.gnu.org/cgit/m4.git/commit/?h=branch-1.4&id=a22c9802dd7e724eaefb21dc21d84ac2d3a49c89
> 
> Until that version is available in buildroot, this patch ensures continued compatibility and successful
> builds.
> 
> More context:
> https://lists.buildroot.org/pipermail/buildroot/2025-April/776922.html
> 
> Signed-off-by: Joseph Zikusooka (ZIK) <zik@jambula.net>
> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> [Tested v1, but v2 has the same diff]

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> 
> ---
> Changes v1 -> v2:
>    - reworded commit message (no diff changes)
> 
>   package/m4/m4.mk | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/package/m4/m4.mk b/package/m4/m4.mk
> index 39ad898b10..ab8e194b06 100644
> --- a/package/m4/m4.mk
> +++ b/package/m4/m4.mk
> @@ -10,4 +10,6 @@ M4_SITE = $(BR2_GNU_MIRROR)/m4
>   M4_LICENSE = GPL-3.0+
>   M4_LICENSE_FILES = COPYING
>   
> +HOST_M4_CONF_ENV = CFLAGS="$(HOST_CFLAGS) -std=gnu17"
> +
>   $(eval $(host-autotools-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot