[Buildroot] [PATCH] support/dependencies/dependencies.sh: awk is needed by Buildroot

[Buildroot] [PATCH] support/dependencies/dependencies.sh: awk is needed by Buildroot

[Thomas Petazzoni via buildroot]

A basic Fedora 42 container does not have 'awk' installed, but it is
needed by Buildroot. First by check-host-python3.sh:

support/dependencies/check-host-python3.sh: line 6: awk: command not found
support/dependencies/check-host-python3.sh: line 19: awk: command not found
support/dependencies/check-host-python3.sh: line 19: awk: command not found

but then even building host-expat assumes awk is available:

config.status: creating Makefile
./config.status: line 1404: awk: command not found
config.status: creating expat.pc
./config.status: line 1404: awk: command not found

Since it's a pretty basic tool, make it part of the tools checked by
dependencies.sh. One minor annoyance is that check-host-python3.sh is
executed *before* dependencies.sh does its thing, so when 'awk' is not
available, we end up seeing:

support/dependencies/check-host-python3.sh: line 6: awk: command not found
support/dependencies/check-host-python3.sh: line 19: awk: command not found
support/dependencies/check-host-python3.sh: line 19: awk: command not found
which: no awk in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
You must install 'awk' on your build machine
make: *** [support/dependencies/dependencies.mk:27: dependencies] Error 1

It would be nice to have the awk check *before* it gets used in
check-host-python3.sh, but that's a topic for another patch.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 docs/manual/prerequisite.adoc        | 1 +
 support/dependencies/dependencies.sh | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/manual/prerequisite.adoc b/docs/manual/prerequisite.adoc
index 5d3aa297a9..9ccc30cca0 100644
--- a/docs/manual/prerequisite.adoc
+++ b/docs/manual/prerequisite.adoc
@@ -38,6 +38,7 @@ between distributions).
 ** +file+ (must be in +/usr/bin/file+)
 ** +bc+
 ** +findutils+
+**  awk
 
 * Source fetching tools:
 ** +wget+
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index fb0defd0c9..2843e3c5d5 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -154,7 +154,7 @@ fi
 
 # Check that a few mandatory programs are installed
 missing_progs="no"
-for prog in perl tar wget cpio unzip rsync bc cmp find xargs ${DL_TOOLS} ; do
+for prog in perl tar wget cpio unzip rsync bc cmp find xargs awk ${DL_TOOLS} ; do
 	if ! which $prog > /dev/null ; then
 		echo "You must install '$prog' on your build machine";
 		missing_progs="yes"
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] support/dependencies/dependencies.sh: awk is needed by Buildroot

[Baruch Siach via buildroot]

Hi Tomas,

On Wed, May 07 2025, Thomas Petazzoni via buildroot wrote:
[...]
> diff --git a/docs/manual/prerequisite.adoc b/docs/manual/prerequisite.adoc
> index 5d3aa297a9..9ccc30cca0 100644
> --- a/docs/manual/prerequisite.adoc
> +++ b/docs/manual/prerequisite.adoc
> @@ -38,6 +38,7 @@ between distributions).
>  ** +file+ (must be in +/usr/bin/file+)
>  ** +bc+
>  ** +findutils+
> +**  awk

Any reason to make text formatting for this item different than all
other listed packages?

baruch

>  
>  * Source fetching tools:
>  ** +wget+
> diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
> index fb0defd0c9..2843e3c5d5 100755
> --- a/support/dependencies/dependencies.sh
> +++ b/support/dependencies/dependencies.sh
> @@ -154,7 +154,7 @@ fi
>  
>  # Check that a few mandatory programs are installed
>  missing_progs="no"
> -for prog in perl tar wget cpio unzip rsync bc cmp find xargs ${DL_TOOLS} ; do
> +for prog in perl tar wget cpio unzip rsync bc cmp find xargs awk ${DL_TOOLS} ; do
>  	if ! which $prog > /dev/null ; then
>  		echo "You must install '$prog' on your build machine";
>  		missing_progs="yes"

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] support/dependencies/dependencies.sh: awk is needed by Buildroot

[Thomas Petazzoni via buildroot]

Hello Baruch,

On Thu, 08 May 2025 07:19:57 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> [...]
> > diff --git a/docs/manual/prerequisite.adoc b/docs/manual/prerequisite.adoc
> > index 5d3aa297a9..9ccc30cca0 100644
> > --- a/docs/manual/prerequisite.adoc
> > +++ b/docs/manual/prerequisite.adoc
> > @@ -38,6 +38,7 @@ between distributions).
> >  ** +file+ (must be in +/usr/bin/file+)
> >  ** +bc+
> >  ** +findutils+
> > +**  awk  
> 
> Any reason to make text formatting for this item different than all
> other listed packages?

Obviously no reason, but here is my excuse: my Emacs apparently has
some AsciiDoc mode, so instead of showing +findutils+, it was showing
findutils without + signs around, but in a blue color. So I didn't
really realize I should use +awk+. Yes, I should have reviewed the diff :-)

Thanks a lot for spotting, I have sent a v2.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot