[Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option

[Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option

[Olivier Benjamin via buildroot]

Add support for a psplash configure option:
  --enable-img-fullscreen, via BR2_PACKAGE_PSPLASH_FULL_SCREEN

The Buildroot option will default to 'n' to be compatible with
the previous behaviour, as it was disabled by default in psplash.

Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
---
 package/psplash/Config.in  | 6 ++++++
 package/psplash/psplash.mk | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/package/psplash/Config.in b/package/psplash/Config.in
index 61162fa583..ca39cd0ee3 100644
--- a/package/psplash/Config.in
+++ b/package/psplash/Config.in
@@ -47,6 +47,12 @@ config BR2_PACKAGE_PSPLASH_STARTUP_MSG
 	help
 	  Enable text banner output on startup.
 
+config BR2_PACKAGE_PSPLASH_FULL_SCREEN
+	bool "use fullscreen mode"
+	default n
+	help
+	  Enable displaying the psplash image in fullscreen mode.
+
 endif
 
 comment "psplash needs a toolchain w/ wchar"
diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
index 62268e778b..bb249e7de8 100644
--- a/package/psplash/psplash.mk
+++ b/package/psplash/psplash.mk
@@ -31,6 +31,12 @@ else
 PSPLASH_CONF_OPTS += --disable-startup-msg
 endif
 
+ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
+PSPLASH_CONF_OPTS += --enable-img-fullscreen
+else
+PSPLASH_CONF_OPTS += --disable-img-fullscreen
+endif
+
 PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE))
 
 ifneq ($(PSPLASH_IMAGE),)
-- 
2.48.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option

[Julien Olivain]

Hi Olivier,

On 07/05/2025 13:40, Olivier Benjamin via buildroot wrote:
> Add support for a psplash configure option:
>   --enable-img-fullscreen, via BR2_PACKAGE_PSPLASH_FULL_SCREEN
> 
> The Buildroot option will default to 'n' to be compatible with
> the previous behaviour, as it was disabled by default in psplash.
> 
> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>

Applied to master, thanks.

I also see that psplash upstream received few updates, including
gcc15/C23 fixes: https://git.yoctoproject.org/psplash/log/
As a suggestion, could you send a bump to the latest commit please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option

[Olivier Benjamin via buildroot]

On 5/9/25 15:27, Julien Olivain wrote:
> Hi Olivier,
> 
> On 07/05/2025 13:40, Olivier Benjamin via buildroot wrote:
>> Add support for a psplash configure option:
>>   --enable-img-fullscreen, via BR2_PACKAGE_PSPLASH_FULL_SCREEN
>>
>> The Buildroot option will default to 'n' to be compatible with
>> the previous behaviour, as it was disabled by default in psplash.
>>
>> Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
> 
> Applied to master, thanks.
> 
thanks for the super quick turn-around!
> I also see that psplash upstream received few updates, including
> gcc15/C23 fixes: https://git.yoctoproject.org/psplash/log/
> As a suggestion, could you send a bump to the latest commit please?
> 
I'll take a look
> Best regards,
> 
> Julien.
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
Olivier Benjamin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option

[Thomas Petazzoni via buildroot]

Hello,

On Wed,  7 May 2025 13:40:41 +0200
Olivier Benjamin <olivier.benjamin@bootlin.com> wrote:

> diff --git a/package/psplash/Config.in b/package/psplash/Config.in
> index 61162fa583..ca39cd0ee3 100644
> --- a/package/psplash/Config.in
> +++ b/package/psplash/Config.in
> @@ -47,6 +47,12 @@ config BR2_PACKAGE_PSPLASH_STARTUP_MSG
>  	help
>  	  Enable text banner output on startup.
>  
> +config BR2_PACKAGE_PSPLASH_FULL_SCREEN
> +	bool "use fullscreen mode"
> +	default n

"default n" is useless, as it's... the default.

> diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
> index 62268e778b..bb249e7de8 100644
> --- a/package/psplash/psplash.mk
> +++ b/package/psplash/psplash.mk
> @@ -31,6 +31,12 @@ else
>  PSPLASH_CONF_OPTS += --disable-startup-msg
>  endif
>  
> +ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
> +PSPLASH_CONF_OPTS += --enable-img-fullscreen
> +else
> +PSPLASH_CONF_OPTS += --disable-img-fullscreen
> +endif

The explicit --enable-<foo> is apparently causing problems, due to bugs
in the upstream configure.ac:

  https://gitlab.com/buildroot.org/buildroot/-/issues/112

Could you have a look?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/psplash: add support for fullscreen config option

[Olivier Benjamin via buildroot]

On 5/12/25 14:07, Thomas Petazzoni via buildroot wrote:
> Hello,
> 
> On Wed,  7 May 2025 13:40:41 +0200
> Olivier Benjamin <olivier.benjamin@bootlin.com> wrote:
> 
>> diff --git a/package/psplash/Config.in b/package/psplash/Config.in
>> index 61162fa583..ca39cd0ee3 100644
>> --- a/package/psplash/Config.in
>> +++ b/package/psplash/Config.in
>> @@ -47,6 +47,12 @@ config BR2_PACKAGE_PSPLASH_STARTUP_MSG
>>   	help
>>   	  Enable text banner output on startup.
>>   
>> +config BR2_PACKAGE_PSPLASH_FULL_SCREEN
>> +	bool "use fullscreen mode"
>> +	default n
> 
> "default n" is useless, as it's... the default.
> 
Very fair, I'll drop this
>> diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
>> index 62268e778b..bb249e7de8 100644
>> --- a/package/psplash/psplash.mk
>> +++ b/package/psplash/psplash.mk
>> @@ -31,6 +31,12 @@ else
>>   PSPLASH_CONF_OPTS += --disable-startup-msg
>>   endif
>>   
>> +ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
>> +PSPLASH_CONF_OPTS += --enable-img-fullscreen
>> +else
>> +PSPLASH_CONF_OPTS += --disable-img-fullscreen
>> +endif
> 
> The explicit --enable-<foo> is apparently causing problems, due to bugs
> in the upstream configure.ac:
> 
>    https://gitlab.com/buildroot.org/buildroot/-/issues/112
> 
> Could you have a look?
> 
Ah, that is odd.. I'll check it out, thanks for the review!
> Thanks!
> 
> Thomas

-- 
Olivier Benjamin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot