[Buildroot] [PATCH] Fix building with Linux 6.14

[Buildroot] [PATCH] Fix building with Linux 6.14

[Giulio Benetti]

Add local patch pending upstream to fix build failure with Linux 6.14.

Fixes:
https://autobuild.buildroot.org/results/065b9afc1c6f9f5561547b12171269adc8c12275

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 .../0002-Fix-build-with-Linux-6.14.patch      | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch

diff --git a/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch b/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch
new file mode 100644
index 0000000000..a05a760d22
--- /dev/null
+++ b/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch
@@ -0,0 +1,33 @@
+From 0363681349f683050bc9a265db8310e8c4eb6534 Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <giulio.benetti@benettiengineering.com>
+Date: Thu, 15 May 2025 22:32:48 +0200
+Subject: [PATCH] Fix build with Linux 6.14
+
+Commit:
+https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7a53af85d3bbdbe06cd47b81a6d99a04dc0a3963
+adds argument "unsigned int link_id" to get_tx_power(), so let's add it to
+cfg80211_rtw_get_txpower() according to Linux version.
+
+Upstream: https://github.com/lwfinger/rtl8188eu/pull/464
+Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
+---
+ ioctl_cfg80211.c | 3 +++
+ 1 file changed, 3 insertions(+)
+
+diff --git a/ioctl_cfg80211.c b/ioctl_cfg80211.c
+index 270cfce..04434fa 100644
+--- a/ioctl_cfg80211.c
++++ b/ioctl_cfg80211.c
+@@ -3240,6 +3240,9 @@ static int cfg80211_rtw_set_txpower(struct wiphy *wiphy,
+ static int cfg80211_rtw_get_txpower(struct wiphy *wiphy,
+ #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 8, 0))
+ 	struct wireless_dev *wdev,
++#endif
++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 14, 0))
++	unsigned int link_id,
+ #endif
+ 	int *dbm)
+ {
+-- 
+2.39.5
+
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] Fix building with Linux 6.14

[Luca Ceresoli via buildroot]

Hello Giulio,

On Thu, 15 May 2025 22:37:39 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Add local patch pending upstream to fix build failure with Linux 6.14.
> 
> Fixes:
> https://autobuild.buildroot.org/results/065b9afc1c6f9f5561547b12171269adc8c12275
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

The Subject should have a "package/rtl8188eu: " prefix.

> diff --git a/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch b/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch
> new file mode 100644
> index 0000000000..a05a760d22
> --- /dev/null
> +++ b/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch
> @@ -0,0 +1,33 @@
> +From 0363681349f683050bc9a265db8310e8c4eb6534 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +Date: Thu, 15 May 2025 22:32:48 +0200
> +Subject: [PATCH] Fix build with Linux 6.14
> +
> +Commit:
> +https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7a53af85d3bbdbe06cd47b81a6d99a04dc0a3963
> +adds argument "unsigned int link_id" to get_tx_power(), so let's add it to
> +cfg80211_rtw_get_txpower() according to Linux version.
> +
> +Upstream: https://github.com/lwfinger/rtl8188eu/pull/464
> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> +---
> + ioctl_cfg80211.c | 3 +++
> + 1 file changed, 3 insertions(+)
> +
> +diff --git a/ioctl_cfg80211.c b/ioctl_cfg80211.c
> +index 270cfce..04434fa 100644
> +--- a/ioctl_cfg80211.c
> ++++ b/ioctl_cfg80211.c
> +@@ -3240,6 +3240,9 @@ static int cfg80211_rtw_set_txpower(struct wiphy *wiphy,
> + static int cfg80211_rtw_get_txpower(struct wiphy *wiphy,
> + #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 8, 0))
> + 	struct wireless_dev *wdev,
> ++#endif
> ++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 14, 0))
> ++	unsigned int link_id,

The patch looks OK otherwise, so with the subject line fixed you can
add:

+Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

However, as the upstream maintainer Larry Finger passed away last year
[1], I don't think those out of tree drivers will be maintained in the
future. Some fork might appear, but an option to seriously consider is
to just deprecate and then remove this package in Buildroot and
recommend using the rtl8xxxu driver that is in mainline Linux.
package/rtl8188eu/Config.in already recommends the mainline driver for
kernels since 3.12, which was released 12 years ago...

[1] https://lwn.net/Articles/979419/

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] Fix building with Linux 6.14

[Giulio Benetti]

Hi Luca,

On 5/16/25 09:05, Luca Ceresoli wrote:
> Hello Giulio,
> 
> On Thu, 15 May 2025 22:37:39 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> Add local patch pending upstream to fix build failure with Linux 6.14.
>>
>> Fixes:
>> https://autobuild.buildroot.org/results/065b9afc1c6f9f5561547b12171269adc8c12275
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> The Subject should have a "package/rtl8188eu: " prefix.

Oops, thank you for pointing. Just sent v2

>> diff --git a/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch b/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch
>> new file mode 100644
>> index 0000000000..a05a760d22
>> --- /dev/null
>> +++ b/package/rtl8188eu/0002-Fix-build-with-Linux-6.14.patch
>> @@ -0,0 +1,33 @@
>> +From 0363681349f683050bc9a265db8310e8c4eb6534 Mon Sep 17 00:00:00 2001
>> +From: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> +Date: Thu, 15 May 2025 22:32:48 +0200
>> +Subject: [PATCH] Fix build with Linux 6.14
>> +
>> +Commit:
>> +https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7a53af85d3bbdbe06cd47b81a6d99a04dc0a3963
>> +adds argument "unsigned int link_id" to get_tx_power(), so let's add it to
>> +cfg80211_rtw_get_txpower() according to Linux version.
>> +
>> +Upstream: https://github.com/lwfinger/rtl8188eu/pull/464
>> +Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> +---
>> + ioctl_cfg80211.c | 3 +++
>> + 1 file changed, 3 insertions(+)
>> +
>> +diff --git a/ioctl_cfg80211.c b/ioctl_cfg80211.c
>> +index 270cfce..04434fa 100644
>> +--- a/ioctl_cfg80211.c
>> ++++ b/ioctl_cfg80211.c
>> +@@ -3240,6 +3240,9 @@ static int cfg80211_rtw_set_txpower(struct wiphy *wiphy,
>> + static int cfg80211_rtw_get_txpower(struct wiphy *wiphy,
>> + #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 8, 0))
>> + 	struct wireless_dev *wdev,
>> ++#endif
>> ++#if (LINUX_VERSION_CODE >= KERNEL_VERSION(6, 14, 0))
>> ++	unsigned int link_id,
> 
> The patch looks OK otherwise, so with the subject line fixed you can
> add:
> 
> +Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> 
> However, as the upstream maintainer Larry Finger passed away last year
> [1], I don't think those out of tree drivers will be maintained in the
> future. 

Oh, I didn't know this. I'm very sorry about this :-/

> Some fork might appear, but an option to seriously consider is
> to just deprecate and then remove this package in Buildroot and
> recommend using the rtl8xxxu driver that is in mainline Linux.
> package/rtl8188eu/Config.in already recommends the mainline driver for
> kernels since 3.12, which was released 12 years ago...
> 
> [1] https://lwn.net/Articles/979419/

If we're going to use latest Linux kernel yes, but for older Linux
versions those are best drivers AFAIK.

Yes, we need to deal with this. I keep patching basically almost all
external rtlxxx drivers in Buildroot and not few of them are from
Larry Finger.

-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot