From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Guillaume Chaye <guillaume.chaye@zeetim.com>
Cc: buildroot@buildroot.org, Christopher McCrory <chrismcc@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package.
Date: Fri, 16 May 2025 21:06:25 +0200 [thread overview]
Message-ID: <20250516210625.00ec043d@windsurf> (raw)
In-Reply-To: <20250325134609.610846-1-guillaume.chaye@zeetim.com>
Hello Guillaume,
Some minor comments for this patch (which I could have fixed locally,
but I have plenty of comments on PATCH 2, so the series will anyway
need a new iteration).
First of all, please make sure version your series, and correctly. You
send v1, v2, v3 (two times), v4, then v6 (no v5) and then here you're
back with no version.
Small detail: don't add a full stop ("point final" in French) at the
end of the commit title.
On Tue, 25 Mar 2025 09:46:08 -0400
Guillaume Chaye <guillaume.chaye@zeetim.com> wrote:
> Some project like efitools requires host version of this package to build properly.
Please wrap your commit message to ~80 columns.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-05-16 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 13:46 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume Chaye
2025-03-25 13:46 ` [Buildroot] [PATCH 2/2] package/efitools: efitools is a set of utilities to manipulate efi variables Guillaume Chaye
2025-05-16 19:14 ` Thomas Petazzoni via buildroot
2025-05-16 19:06 ` Thomas Petazzoni via buildroot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-05 9:48 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
2024-09-05 12:18 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516210625.00ec043d@windsurf \
--to=buildroot@buildroot.org \
--cc=chrismcc@gmail.com \
--cc=guillaume.chaye@zeetim.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox