Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
Cc: Christopher McCrory <chrismcc@gmail.com>,
	Norbert Lange <nolange79@gmail.com>,
	Sen Hastings <sen@hastings.org>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package
Date: Thu, 5 Sep 2024 14:18:14 +0200	[thread overview]
Message-ID: <Ztmhhq922XUxjUP9@landeda> (raw)
In-Reply-To: <20240905094828.1313494-1-guillaume.chaye@zeetim.com>

Guillaume, All,

On 2024-09-05 11:48 +0200, Guillaume GC. Chaye spake thusly:
> Some project like efitools requires host version of this package to build properly.

Please wrap your commit logs t o72-char wide lines.

As is, this change will never be tested, because we have nothing in the
Buildroot tree that depends on host-perl-file-slurp. 

We ciurrently do not have efitools packaged in Buildroot. Are you
planning to do so? If so, then please include this change into a series
that adds efitools.

Also, I don't think there is a relation between this patch, and the
folowing one about systemd, so don't send tem as a series.

Regards,
Yann E. MORIN.

> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
> ---
>  package/perl-file-slurp/perl-file-slurp.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk
> index 0d4ab94034..7cada58070 100644
> --- a/package/perl-file-slurp/perl-file-slurp.mk
> +++ b/package/perl-file-slurp/perl-file-slurp.mk
> @@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md
>  PERL_FILE_SLURP_DISTNAME = File-Slurp
>  
>  $(eval $(perl-package))
> +$(eval $(host-perl-package))
> -- 
> 2.39.2
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-09-05 12:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  9:48 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
2024-09-05  9:48 ` [Buildroot] [PATCH 2/2] package/systemd: add efi support option Guillaume GC. Chaye
2024-09-05 12:04   ` Yann E. MORIN
2024-09-05 12:18 ` Yann E. MORIN [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-03-25 13:46 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume Chaye
2025-05-16 19:06 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ztmhhq922XUxjUP9@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=chrismcc@gmail.com \
    --cc=guillaume.chaye@zeetim.com \
    --cc=nolange79@gmail.com \
    --cc=sen@hastings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox