From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
Cc: Christopher McCrory <chrismcc@gmail.com>,
Norbert Lange <nolange79@gmail.com>,
Sen Hastings <sen@hastings.org>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/systemd: add efi support option
Date: Thu, 5 Sep 2024 14:04:58 +0200 [thread overview]
Message-ID: <ZtmeaiPGkdpfNW1T@landeda> (raw)
In-Reply-To: <20240905094828.1313494-2-guillaume.chaye@zeetim.com>
Guillsume, All,
On 2024-09-05 11:48 +0200, Guillaume GC. Chaye spake thusly:
> We need to compile systemd with -Defi=true flag to mount automatically efivarfs in /sys/firmware/efi/efivars
Please, wrap your commitlogs to 72 char-wide lines.
> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
> ---
> package/systemd/Config.in | 3 +++
> package/systemd/systemd.mk | 7 ++++++-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 345f08590e..d1ca6e7f85 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -161,6 +161,9 @@ config BR2_PACKAGE_SYSTEMD_BOOT_EFI_ARCH
> default "x64" if BR2_x86_64
> depends on BR2_PACKAGE_SYSTEMD_BOOT
>
> +config BR2_PACKAGE_SYSTEMD_EFI
> + bool "enable EFI support"
With this, when the user enables BR2_PACKAGE_SYSTEMD_BOOT but does not
enable BR2_PACKAGE_SYSTEMD_EFI, then -Defi=true is still passed, and
systemd still has EFI support. This is misleading, because the user sees
"enale EFI support" disabled.
But see below..
> config BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE
> bool "enable journal remote tools"
> select BR2_PACKAGE_LIBCURL
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 5dca8681bc..7b3eabbd0d 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -660,7 +660,12 @@ define SYSTEMD_INSTALL_BOOT_FILES
> endef
>
> else
> -SYSTEMD_CONF_OPTS += -Defi=false -Dbootloader=disabled
> +SYSTEMD_CONF_OPTS += -Dbootloader=disabled
> +ifeq ($(BR2_PACKAGE_SYSTEMD_EFI),y)
> +SYSTEMD_CONF_OPTS += -Defi=true
> +else
> +SYSTEMD_CONF_OPTS += -Defi=false
> +endif
> endif # BR2_PACKAGE_SYSTEMD_BOOT == y
The -Defi option should be moved outside the bootloader conditional
block altogether, and BR2_PACKAGE_SYSTEMD_BOOT should select
BR2_PACKAGE_SYSTEMD_EFI.
Regards,
Yann E. MORIN.
> SYSTEMD_FALLBACK_HOSTNAME = $(call qstrip,$(BR2_TARGET_GENERIC_HOSTNAME))
> --
> 2.39.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-09-05 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 9:48 [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
2024-09-05 9:48 ` [Buildroot] [PATCH 2/2] package/systemd: add efi support option Guillaume GC. Chaye
2024-09-05 12:04 ` Yann E. MORIN [this message]
2024-09-05 12:18 ` [Buildroot] [PATCH 1/2] package/perl-file-slurp: add host package Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtmeaiPGkdpfNW1T@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=chrismcc@gmail.com \
--cc=guillaume.chaye@zeetim.com \
--cc=nolange79@gmail.com \
--cc=sen@hastings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox