* [Buildroot] [PATCH] Kea: new package - kea version 2.6.2 @ 2025-04-26 7:50 Joseph Zikusooka (ZIK) 2025-05-17 9:50 ` Thomas Petazzoni via buildroot 0 siblings, 1 reply; 3+ messages in thread From: Joseph Zikusooka (ZIK) @ 2025-04-26 7:50 UTC (permalink / raw) To: buildroot; +Cc: Joseph Zikusooka (ZIK) Add Kea, an open-source Dynamic Host Configuration Protocol (DHCP) server developed by the Internet Systems Consortium (ISC). It's designed to provide dynamic IP address allocation and configuration for devices on a network. Kea is known for its modular architecture, allowing for easy extension and integration with other services. Supersedes: a015291dc94b5497ac1fd60a2e4cf84fe3c82cb5 --- package/kea/Config.in | 17 +++++++++++++++++ package/kea/kea.hash | 3 +++ package/kea/kea.mk | 22 ++++++++++++++++++++++ 3 files changed, 42 insertions(+) create mode 100644 package/kea/Config.in create mode 100644 package/kea/kea.hash create mode 100644 package/kea/kea.mk diff --git a/package/kea/Config.in b/package/kea/Config.in new file mode 100644 index 0000000000..1b3bbe2e50 --- /dev/null +++ b/package/kea/Config.in @@ -0,0 +1,17 @@ +config BR2_PACKAGE_KEA + + bool "kea" + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_MMU + select BR2_PACKAGE_BOOST + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_LOG4CPLUS + + help + DHCP implementation from Internet Systems Consortium, Inc. that features fully + functional DHCPv4, DHCPv6 and Dynamic DNS servers. + Both DHCP servers fully support server discovery, address assignment, renewal, + rebinding and release. The DHCPv6 server supports prefix delegation. Both + servers support DNS Update mechanism, using stand-alone DDNS daemon + + https://www.isc.org/kea diff --git a/package/kea/kea.hash b/package/kea/kea.hash new file mode 100644 index 0000000000..37cb4e19f4 --- /dev/null +++ b/package/kea/kea.hash @@ -0,0 +1,3 @@ +# Locally computed - sha256 +sha256 8a50b63103734b59c3b8619ccd6766d2dfee3f02e3a5f9f3abc1cd55f70fa424 kea-2.6.2.tar.gz +sha256 2768ea1cbc79ac048f0c34c5cb50cf7e7d4c13a83337ebfa147a700b876431d5 COPYING diff --git a/package/kea/kea.mk b/package/kea/kea.mk new file mode 100644 index 0000000000..d589d2c1c2 --- /dev/null +++ b/package/kea/kea.mk @@ -0,0 +1,22 @@ +################################################################################ +# +# kea +# +################################################################################ + +KEA_VERSION = 2.6.2 +KEA_SOURCE = kea-$(KEA_VERSION).tar.gz +KEA_SITE = https://dl.cloudsmith.io/public/isc/kea-2-6/raw/versions/$(KEA_VERSION) +KEA_LICENSE = MPL 2.0 +KEA_LICENSE_FILES = COPYING + +KEA_DEPENDENCIES = host-pkgconf openssl boost log4cplus + +KEA_CONF_OPTS = "--with-openssl=$(STAGING_DIR)/usr" +KEA_CONF_OPTS = "--with-log4cplus=$(STAGING_DIR)/usr" +#KEA_CONF_OPTS = "--with-boost-include=$(STAGING_DIR)/usr" + +KEA_INSTALL_STAGING = YES +KEA_INSTALL_TARGET = YES + +$(eval $(autotools-package)) -- 2.49.0 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] Kea: new package - kea version 2.6.2 2025-04-26 7:50 [Buildroot] [PATCH] Kea: new package - kea version 2.6.2 Joseph Zikusooka (ZIK) @ 2025-05-17 9:50 ` Thomas Petazzoni via buildroot 2025-05-17 10:42 ` Joseph Zikusooka 0 siblings, 1 reply; 3+ messages in thread From: Thomas Petazzoni via buildroot @ 2025-05-17 9:50 UTC (permalink / raw) To: Joseph Zikusooka (ZIK); +Cc: buildroot, Joseph Zikusooka (ZIK) Hello Joseph, Thanks for your contribution! See below a number of comments. On Sat, 26 Apr 2025 10:50:00 +0300 "Joseph Zikusooka (ZIK)" <josephzik@gmail.com> wrote: > Add Kea, an open-source Dynamic Host Configuration Protocol (DHCP) > server developed by the Internet Systems Consortium (ISC). > It's designed to provide dynamic IP address allocation and > configuration for devices on a network. Kea is known for its > modular architecture, allowing for easy extension and integration > with other services. > > Supersedes: a015291dc94b5497ac1fd60a2e4cf84fe3c82cb5 This is missing your Signed-off-by line, so unfortunately, we can't apply it. This "Supersedes:" line doesn't make sense, because a015291dc94b5497ac1fd60a2e4cf84fe3c82cb5 isn't a reference that is meaningful. Also, the commit title should be: package/kea: new package > package/kea/Config.in | 17 +++++++++++++++++ > package/kea/kea.hash | 3 +++ > package/kea/kea.mk | 22 ++++++++++++++++++++++ > 3 files changed, 42 insertions(+) You need to add an entry in the DEVELOPERS file. > diff --git a/package/kea/Config.in b/package/kea/Config.in > new file mode 100644 > index 0000000000..1b3bbe2e50 > --- /dev/null > +++ b/package/kea/Config.in > @@ -0,0 +1,17 @@ > +config BR2_PACKAGE_KEA > + This empty line shouldn't be there. > + bool "kea" > + depends on BR2_TOOLCHAIN_HAS_THREADS > + depends on BR2_USE_MMU Indicate in a comment why those dependencies are present. > + select BR2_PACKAGE_BOOST Boost also depends on BR2_INSTALL_LIBSTDCPP. > + select BR2_PACKAGE_OPENSSL > + select BR2_PACKAGE_LOG4CPLUS This one depends on a lot of stuff: depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::future So basically, you should have: depends on BR2_INSTALL_LIBSTDCPP # boost, log4cplus depends on BR2_USE_WCHAR # log4cplus, boost depends on BR2_TOOLCHAIN_HAS_THREADS # log4cplus, boost depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # log4cplus depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # log4cplus I'm not sure where your BR2_USE_MMU dependencies comes from. Maybe from the kea code itself? > + help > + DHCP implementation from Internet Systems Consortium, Inc. that features fully > + functional DHCPv4, DHCPv6 and Dynamic DNS servers. > + Both DHCP servers fully support server discovery, address assignment, renewal, > + rebinding and release. The DHCPv6 server supports prefix delegation. Both > + servers support DNS Update mechanism, using stand-alone DDNS daemon Please wrap at 72 columns. Run "make check-package" to check the coding style. > + https://www.isc.org/kea You also need a Config.in comment to explain the dependencies. Along the lines of: comment "kea needs a toolchain w/ C++, wchar, threads, gcc >= 4.8" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 comment "kea needs a toolchain not affected by GCC bug 64735" depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > diff --git a/package/kea/kea.mk b/package/kea/kea.mk > new file mode 100644 > index 0000000000..d589d2c1c2 > --- /dev/null > +++ b/package/kea/kea.mk > @@ -0,0 +1,22 @@ > +################################################################################ > +# > +# kea > +# > +################################################################################ > + > +KEA_VERSION = 2.6.2 > +KEA_SOURCE = kea-$(KEA_VERSION).tar.gz > +KEA_SITE = https://dl.cloudsmith.io/public/isc/kea-2-6/raw/versions/$(KEA_VERSION) > +KEA_LICENSE = MPL 2.0 > +KEA_LICENSE_FILES = COPYING > + > +KEA_DEPENDENCIES = host-pkgconf openssl boost log4cplus > + > +KEA_CONF_OPTS = "--with-openssl=$(STAGING_DIR)/usr" > +KEA_CONF_OPTS = "--with-log4cplus=$(STAGING_DIR)/usr" > +#KEA_CONF_OPTS = "--with-boost-include=$(STAGING_DIR)/usr" Comment lines are weird, if it's not needed, drop it. Also please write this like this: KEA_CONF_OPTS = \ --with-openssl=$(STAGING_DIR)/usr \ --with-log4cplus=$(STAGING_DIR)/usr > +KEA_INSTALL_STAGING = YES > +KEA_INSTALL_TARGET = YES KEA_INSTALL_TARGET = YES is definitely not needed, as it's the default. Why is KEA_INSTALL_STAGING = YES needed? Is kea installing some libraries? Could you fix those different issues, and come back with an updated patch? Make sure to name it [PATCH v2], and provide a changelog. See https://buildroot.org/downloads/manual/manual.html#submitting-patches for some good description on how to contribute. Thanks a lot! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] Kea: new package - kea version 2.6.2 2025-05-17 9:50 ` Thomas Petazzoni via buildroot @ 2025-05-17 10:42 ` Joseph Zikusooka 0 siblings, 0 replies; 3+ messages in thread From: Joseph Zikusooka @ 2025-05-17 10:42 UTC (permalink / raw) To: Thomas Petazzoni; +Cc: buildroot, Joseph Zikusooka (ZIK) [-- Attachment #1.1: Type: text/plain, Size: 5815 bytes --] Hi Thomas, Thank you very much for taking the time to review my patch and provide such detailed and helpful feedback. I truly appreciate your thorough comments and suggestions. I will address all the points you raised and update the patch accordingly. Once the necessary changes are made, I will submit a revised version. Thanks again, Joseph Zik On Sat, May 17, 2025 at 12:50 PM Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > Hello Joseph, > > Thanks for your contribution! See below a number of comments. > > On Sat, 26 Apr 2025 10:50:00 +0300 > "Joseph Zikusooka (ZIK)" <josephzik@gmail.com> wrote: > > > Add Kea, an open-source Dynamic Host Configuration Protocol (DHCP) > > server developed by the Internet Systems Consortium (ISC). > > It's designed to provide dynamic IP address allocation and > > configuration for devices on a network. Kea is known for its > > modular architecture, allowing for easy extension and integration > > with other services. > > > > Supersedes: a015291dc94b5497ac1fd60a2e4cf84fe3c82cb5 > > This is missing your Signed-off-by line, so unfortunately, we can't > apply it. > > This "Supersedes:" line doesn't make sense, because > a015291dc94b5497ac1fd60a2e4cf84fe3c82cb5 isn't a reference that is > meaningful. > > Also, the commit title should be: > > package/kea: new package > > > package/kea/Config.in | 17 +++++++++++++++++ > > package/kea/kea.hash | 3 +++ > > package/kea/kea.mk | 22 ++++++++++++++++++++++ > > 3 files changed, 42 insertions(+) > > You need to add an entry in the DEVELOPERS file. > > > diff --git a/package/kea/Config.in b/package/kea/Config.in > > new file mode 100644 > > index 0000000000..1b3bbe2e50 > > --- /dev/null > > +++ b/package/kea/Config.in > > @@ -0,0 +1,17 @@ > > +config BR2_PACKAGE_KEA > > + > > This empty line shouldn't be there. > > > + bool "kea" > > + depends on BR2_TOOLCHAIN_HAS_THREADS > > + depends on BR2_USE_MMU > > Indicate in a comment why those dependencies are present. > > > + select BR2_PACKAGE_BOOST > > Boost also depends on BR2_INSTALL_LIBSTDCPP. > > > + select BR2_PACKAGE_OPENSSL > > + select BR2_PACKAGE_LOG4CPLUS > > This one depends on a lot of stuff: > > depends on BR2_INSTALL_LIBSTDCPP > depends on BR2_USE_WCHAR > depends on BR2_TOOLCHAIN_HAS_THREADS > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11 > depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::future > > So basically, you should have: > > depends on BR2_INSTALL_LIBSTDCPP # boost, log4cplus > depends on BR2_USE_WCHAR # log4cplus, boost > depends on BR2_TOOLCHAIN_HAS_THREADS # log4cplus, boost > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # log4cplus > depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # log4cplus > > I'm not sure where your BR2_USE_MMU dependencies comes from. Maybe from > the kea code itself? > > > + help > > + DHCP implementation from Internet Systems Consortium, Inc. that > features fully > > + functional DHCPv4, DHCPv6 and Dynamic DNS servers. > > + Both DHCP servers fully support server discovery, address > assignment, renewal, > > + rebinding and release. The DHCPv6 server supports prefix > delegation. Both > > + servers support DNS Update mechanism, using stand-alone DDNS > daemon > > Please wrap at 72 columns. Run "make check-package" to check the coding > style. > > > + https://www.isc.org/kea > > You also need a Config.in comment to explain the dependencies. Along > the lines of: > > comment "kea needs a toolchain w/ C++, wchar, threads, gcc >= 4.8" > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ > !BR2_TOOLCHAIN_HAS_THREADS || > !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 > > comment "kea needs a toolchain not affected by GCC bug 64735" > depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735 > > > diff --git a/package/kea/kea.mk b/package/kea/kea.mk > > new file mode 100644 > > index 0000000000..d589d2c1c2 > > --- /dev/null > > +++ b/package/kea/kea.mk > > @@ -0,0 +1,22 @@ > > > +################################################################################ > > +# > > +# kea > > +# > > > +################################################################################ > > + > > +KEA_VERSION = 2.6.2 > > +KEA_SOURCE = kea-$(KEA_VERSION).tar.gz > > +KEA_SITE = > https://dl.cloudsmith.io/public/isc/kea-2-6/raw/versions/$(KEA_VERSION) > > +KEA_LICENSE = MPL 2.0 > > +KEA_LICENSE_FILES = COPYING > > + > > +KEA_DEPENDENCIES = host-pkgconf openssl boost log4cplus > > + > > +KEA_CONF_OPTS = "--with-openssl=$(STAGING_DIR)/usr" > > +KEA_CONF_OPTS = "--with-log4cplus=$(STAGING_DIR)/usr" > > +#KEA_CONF_OPTS = "--with-boost-include=$(STAGING_DIR)/usr" > > Comment lines are weird, if it's not needed, drop it. Also please write > this like this: > > KEA_CONF_OPTS = \ > --with-openssl=$(STAGING_DIR)/usr \ > --with-log4cplus=$(STAGING_DIR)/usr > > > +KEA_INSTALL_STAGING = YES > > +KEA_INSTALL_TARGET = YES > > KEA_INSTALL_TARGET = YES is definitely not needed, as it's the default. > > Why is KEA_INSTALL_STAGING = YES needed? Is kea installing some > libraries? > > Could you fix those different issues, and come back with an updated > patch? Make sure to name it [PATCH v2], and provide a changelog. See > https://buildroot.org/downloads/manual/manual.html#submitting-patches > for some good description on how to contribute. > > Thanks a lot! > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com > -- Joseph Zikusooka [-- Attachment #1.2: Type: text/html, Size: 7674 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-17 10:42 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-04-26 7:50 [Buildroot] [PATCH] Kea: new package - kea version 2.6.2 Joseph Zikusooka (ZIK) 2025-05-17 9:50 ` Thomas Petazzoni via buildroot 2025-05-17 10:42 ` Joseph Zikusooka
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox