[Buildroot] [PATCH 1/1] package/uboot-tools: remove absolute path of link source for fw_setenv

[Buildroot] [PATCH 1/1] package/uboot-tools: remove absolute path of link source for fw_setenv

[Kunihiko Hayashi]

For portability reason, it isn't preferable to include an absolute path
in the link to fw_printenv which is in the same directory as fw_setenv.

Fixes: 42646265d5dd ("package/uboot-tools: add fw_printenv to host uboot tools")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 package/uboot-tools/uboot-tools.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index d897a6bc17f4..1925047ccdcf 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -220,7 +220,7 @@ define HOST_UBOOT_TOOLS_INSTALL_CMDS
 	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(HOST_DIR)/bin/dumpimage
 	$(HOST_UBOOT_TOOLS_INSTALL_FIT_CHECK_SIGN)
 	$(INSTALL) -m 0755 -D $(@D)/tools/env/fw_printenv $(HOST_DIR)/bin/fw_printenv
-	ln -sf $(HOST_DIR)/bin/fw_printenv $(HOST_DIR)/bin/fw_setenv
+	ln -sf fw_printenv $(HOST_DIR)/bin/fw_setenv
 	$(HOST_UBOOT_TOOLS_INSTALL_ENVIMAGE)
 	$(HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT)
 endef
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/uboot-tools: remove absolute path of link source for fw_setenv

[Thomas Petazzoni via buildroot]

On Thu,  3 Apr 2025 13:47:47 +0900
Kunihiko Hayashi <hayashi.kunihiko@socionext.com> wrote:

> For portability reason, it isn't preferable to include an absolute path
> in the link to fw_printenv which is in the same directory as fw_setenv.
> 
> Fixes: 42646265d5dd ("package/uboot-tools: add fw_printenv to host uboot tools")
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  package/uboot-tools/uboot-tools.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/uboot-tools: remove absolute path of link source for fw_setenv

[Arnout Vandecappelle via buildroot]

On 03/04/2025 06:47, Kunihiko Hayashi wrote:
> For portability reason, it isn't preferable to include an absolute path
> in the link to fw_printenv which is in the same directory as fw_setenv.
> 
> Fixes: 42646265d5dd ("package/uboot-tools: add fw_printenv to host uboot tools")
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

  Applied to 2025.02.x, thanks.

  Regards,
  Arnout

> ---
>   package/uboot-tools/uboot-tools.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
> index d897a6bc17f4..1925047ccdcf 100644
> --- a/package/uboot-tools/uboot-tools.mk
> +++ b/package/uboot-tools/uboot-tools.mk
> @@ -220,7 +220,7 @@ define HOST_UBOOT_TOOLS_INSTALL_CMDS
>   	$(INSTALL) -m 0755 -D $(@D)/tools/dumpimage $(HOST_DIR)/bin/dumpimage
>   	$(HOST_UBOOT_TOOLS_INSTALL_FIT_CHECK_SIGN)
>   	$(INSTALL) -m 0755 -D $(@D)/tools/env/fw_printenv $(HOST_DIR)/bin/fw_printenv
> -	ln -sf $(HOST_DIR)/bin/fw_printenv $(HOST_DIR)/bin/fw_setenv
> +	ln -sf fw_printenv $(HOST_DIR)/bin/fw_setenv
>   	$(HOST_UBOOT_TOOLS_INSTALL_ENVIMAGE)
>   	$(HOST_UBOOT_TOOLS_INSTALL_BOOT_SCRIPT)
>   endef

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot