Re: [Buildroot] [PATCH 1/1] Makefile: include lifecycle scripts in build-time.log

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: mscdexdotexe via buildroot <buildroot@buildroot.org>
Cc: mscdexdotexe <mscdex@mscdex.net>
Subject: Re: [Buildroot] [PATCH 1/1] Makefile: include lifecycle scripts in build-time.log
Date: Fri, 30 May 2025 21:55:34 +0200	[thread overview]
Message-ID: <20250530215534.1d515afd@windsurf> (raw)
In-Reply-To: <CAPqAjCxGOApih6xj_6Nj-RUUsguzUjtLyp5qa6Zv4p9sw4NAWA@mail.gmail.com>

Hello Brian,

On Tue, 27 May 2025 00:21:25 -0400
mscdexdotexe via buildroot <buildroot@buildroot.org> wrote:

> This gives a more complete picture when using build-time.log
> to determine what is taking the most time.
> 
> Signed-off-by: Brian White <mscdex@mscdex.net>

Thanks for your patch. However, your From: doesn't match your
Signed-off-by: line, and your patch appears line-wrapped. Could you use
git send-email to send your patch, and make sure that your From:
matches your Signed-off-by: ?

Because otherwise the change looks good to me. I guess you are the
person you filled the related issue on Gitlab. If that's the case you
can also refer to ths Gitlab issue in the commit log, so that the
person merging your patch will remember to mark the Gitlab issue as
closed.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot