[Buildroot] [PATCH 1/1] Makefile: include lifecycle scripts in build-time.log

[Buildroot] [PATCH 1/1] Makefile: include lifecycle scripts in build-time.log

[mscdexdotexe via buildroot]

This gives a more complete picture when using build-time.log
to determine what is taking the most time.

Signed-off-by: Brian White <mscdex@mscdex.net>
---
 Makefile | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index c14023fd98..3291af90b7 100644
--- a/Makefile
+++ b/Makefile
@@ -587,10 +587,12 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(BR2_CONFIG)
 prepare: $(BUILD_DIR)/buildroot-config/auto.conf
        @$(foreach s, $(call qstrip,$(BR2_ROOTFS_PRE_BUILD_SCRIPT)), \
                $(call MESSAGE,"Executing pre-build script $(s)"); \
+               $(call step_time,start,pre-build,$(s))$(sep) \
                $(EXTRA_ENV) $(s) \
                        $(TARGET_DIR) \
                        $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS)) \
-                       $(call
qstrip,$(BR2_ROOTFS_PRE_BUILD_SCRIPT_ARGS))$(sep))
+                       $(call
qstrip,$(BR2_ROOTFS_PRE_BUILD_SCRIPT_ARGS))$(sep) \
+               $(call step_time,end,pre-build,$(s))$(sep))

 .PHONY: world
 world: target-post-image
@@ -807,10 +809,12 @@ endif # merged /usr

        $(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_BUILD_SCRIPT)), \
                @$(call MESSAGE,"Executing post-build script $(s)")$(sep) \
+               @$(call step_time,start,post-build,$(s))$(sep) \
                $(Q)$(EXTRA_ENV) $(s) \
                        $(TARGET_DIR) \
                        $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS)) \
-                       $(call
qstrip,$(BR2_ROOTFS_POST_BUILD_SCRIPT_ARGS))$(sep))
+                       $(call
qstrip,$(BR2_ROOTFS_POST_BUILD_SCRIPT_ARGS))$(sep) \
+               @$(call step_time,end,post-build,$(s))$(sep))

        touch $(TARGET_DIR)/usr

@@ -828,10 +832,12 @@ target-post-image: $(TARGETS_ROOTFS)
target-finalize staging-finalize
        $(Q)mkdir -p $(BINARIES_DIR)
        @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \
                $(call MESSAGE,"Executing post-image script $(s)"); \
+               $(call step_time,start,post-image,$(s))$(sep) \
                $(EXTRA_ENV) $(s) \
                        $(BINARIES_DIR) \
                        $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS)) \
-                       $(call
qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT_ARGS))$(sep))
+                       $(call
qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT_ARGS))$(sep) \
+               $(call step_time,end,post-image,$(s))$(sep))

 .PHONY: source
 source: $(foreach p,$(PACKAGES),$(p)-all-source)
-- 
2.43.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] Makefile: include lifecycle scripts in build-time.log

[Thomas Petazzoni via buildroot]

Hello Brian,

On Tue, 27 May 2025 00:21:25 -0400
mscdexdotexe via buildroot <buildroot@buildroot.org> wrote:

> This gives a more complete picture when using build-time.log
> to determine what is taking the most time.
> 
> Signed-off-by: Brian White <mscdex@mscdex.net>

Thanks for your patch. However, your From: doesn't match your
Signed-off-by: line, and your patch appears line-wrapped. Could you use
git send-email to send your patch, and make sure that your From:
matches your Signed-off-by: ?

Because otherwise the change looks good to me. I guess you are the
person you filled the related issue on Gitlab. If that's the case you
can also refer to ths Gitlab issue in the commit log, so that the
person merging your patch will remember to mark the Gitlab issue as
closed.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot