Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: buildroot@buildroot.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Olivier Benjamin <olivier.benjamin@bootlin.com>
Subject: Re: [Buildroot] [PATCH] package/linux-tools: perf: build with libtraceevent support when it is selected
Date: Thu, 26 Jun 2025 10:02:42 +0200	[thread overview]
Message-ID: <20250626100242.27ab1407@booty> (raw)
In-Reply-To: <20250625-perf_libtraceevent-v1-1-0bf7620bc6c9@bootlin.com>

Hi Alexis,

On Wed, 25 Jun 2025 22:54:01 +0200
Alexis Lothoré <alexis.lothore@bootlin.com> wrote:

> When trying to perform a custom uprobe recording on a target with perf
> built by buildroot, the recording step fails as perf can not record
> uprobes without libtraceevent support:
> 
>   $ perf probe -x linked_list insert_name index
>   Target program is compiled without optimization. Skipping prologue.
>   Probe on address 0x808 to force probing at the function entry.
> 
>   Added new event:
>     probe_linked_list:insert_name (on insert_name in /root/gdb/linked_list with index)
> 
>   perf is not linked with libtraceevent, to use the new probe you can use tracefs:
> 
>           cd /sys/kernel/tracing/
>           echo 1 > events/probe_linked_list/insert_name/enable
>           echo 1 > tracing_on
>           cat trace_pipe
>           Before removing the probe, echo 0 > events/probe_linked_list/insert_name/enable
>   $ perf record -e probe_linked_list:insert_name ./linked_list
>   event syntax error: 'probe_linked_list:insert_name'
>                        \___ unsupported tracepoint
> 
>   libtraceevent is necessary for tracepoint support
>   Run 'perf list' for a list of valid events
> 
>    Usage: perf record [<options>] [<command>]
>       or: perf record [<options>] -- <command> [<options>]
> 
>       -e, --event <event>   event selector. use 'perf list' to list available events
> 
> libtraceevent support for perf has been disabled with commit
> b4ab45a5c1db ("package/linux-tools: disable libtracevent detection")
> because there was no libtraceevent package in buildroot to replace the
> former libtraceevent removed from the kernel sources. Since then, commit
> 1474f1b34b17 ("package/libtraceevent: new package") has introduced a
> libtraceevent package. We can then expose again the possibility to build
> perf with libtraceevent support.
> 
> Make buildroot perf makefile detect if libtraceevent package has been
> enabled, and if so, allow to build perf with libtraceevent support.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
> To: buildroot@buildroot.org
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Cc: Olivier Benjamin <olivier.benjamin@bootlin.com>
> ---
> It is worth noting that there is a bug in perf makefile kernel that
> affects many kernel versions (up to 6.10) and that prevents perf from
> building correctly when enabling libtraceevent support (see 440cf77625e3
> ("perf: build: Setup PKG_CONFIG_LIBDIR for cross compilation") in
> linux).

Thanks for the research!

And apparently the mentioned commit was applied in 6.11 and not
backported to 6.10 and previous stable releases.

Shouldn't it be backported? This looks like a fix, doesn't it?

> Should the libtraceevent then be explicitely enabled by the
> user, rather than automatically enabling it when libtraceevent package
> is selected ?

Should the fix be backported to the currently-supported stable kernel
versions, I'd say we can automatically enable libtraceevent support.
Otherwise I'm not sure... Mentioning the issue and pointing to the fix
commit in the Kconfig help text is another option.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-06-26  8:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 20:54 [Buildroot] [PATCH] package/linux-tools: perf: build with libtraceevent support when it is selected Alexis Lothoré via buildroot
2025-06-26  8:02 ` Luca Ceresoli via buildroot [this message]
2025-06-26  8:46   ` Alexis Lothoré via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250626100242.27ab1407@booty \
    --to=buildroot@buildroot.org \
    --cc=alexis.lothore@bootlin.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=olivier.benjamin@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox