Re: [Buildroot] [PATCH] package/linux-tools: perf: build with libtraceevent support when it is selected

["Alexis Lothoré via buildroot" <buildroot@buildroot.org>]

Hi Luca,

>> It is worth noting that there is a bug in perf makefile kernel that
>> affects many kernel versions (up to 6.10) and that prevents perf from
>> building correctly when enabling libtraceevent support (see 440cf77625e3
>> ("perf: build: Setup PKG_CONFIG_LIBDIR for cross compilation") in
>> linux).
>
> Thanks for the research!
>
> And apparently the mentioned commit was applied in 6.11 and not
> backported to 6.10 and previous stable releases

Yes, you are right, my mistake.

> Shouldn't it be backported? This looks like a fix, doesn't it?

Indeed. The original author on kernel side did not bring any Fixes tag so
it may have slipped through the stable kernels, but I can try to submit it
for current stable/LTS kernels.

>> Should the libtraceevent then be explicitely enabled by the
>> user, rather than automatically enabling it when libtraceevent package
>> is selected ?
>
> Should the fix be backported to the currently-supported stable kernel
> versions, I'd say we can automatically enable libtraceevent support.
> Otherwise I'm not sure... Mentioning the issue and pointing to the fix
> commit in the Kconfig help text is another option.

Mentioning the kernel version fixing the issue in the KConfig help sounds
relevant, but maybe having the exact kernel commit only in the BR commit
description is enough ? If so, I can prepare a v2 with the updated Kconfig.

Thanks

Alexis

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot