From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: <buildroot@buildroot.org>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Romain Naour <romain.naour@gmail.com>
Subject: Re: [Buildroot] [RFC PATCH 1/2] package/Makefile.in: microblaze: enable -mxl-barrel-shift as default
Date: Tue, 1 Jul 2025 12:13:17 +0200 [thread overview]
Message-ID: <20250701121317.7792bf97@windsurf> (raw)
In-Reply-To: <20250701093020.371352-1-neal.frager@amd.com>
Hello Neal,
Thanks for working on this topic!
On Tue, 1 Jul 2025 10:30:19 +0100
Neal Frager <neal.frager@amd.com> wrote:
> +# microblaze arch atomic extensions require barrel shift
> +# instructions to be enabled, so make it default
> +ifeq ($(BR2_microblaze),y)
> +TARGET_CFLAGS += -mxl-barrel-shift
> +endif
Since this is a really important compiler flag for things to work
correctly, I believe we should add it to ARCH_TOOLCHAIN_WRAPPER_OPTS
instead of TARGET_CFLAGS, so that it gets encoded into the toolchain
wrapper, like we do in arch/arch.mk.arc to add -matomic on certain ARC
targets.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-07-01 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:30 [Buildroot] [RFC PATCH 1/2] package/Makefile.in: microblaze: enable -mxl-barrel-shift as default Neal Frager via buildroot
2025-07-01 9:30 ` [Buildroot] [RFC PATCH 2/2] package/gcc: microblaze atomic support Neal Frager via buildroot
2025-07-01 9:40 ` Frager, Neal via buildroot
2025-07-01 10:13 ` Thomas Petazzoni via buildroot [this message]
2025-07-27 15:05 ` [Buildroot] [RFC PATCH 1/2] package/Makefile.in: microblaze: enable -mxl-barrel-shift as default Frager, Neal via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250701121317.7792bf97@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=neal.frager@amd.com \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox