[Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Florian Larysch]

www.rscada.se has been offline for a long time, causing build failures.
However, there is an official[1] GitHub repo. This also seems to be
where new releases are happening rather than the old site.

Switch to git for fetching the source code. Unlike the tarball,
the repo only ships partial autotools files (Makefile.in is missing, for
example), so we need to do an autoreconf, which also requires a patch
for modern Automake versions.

[1] https://web.archive.org/web/20250122102111/http://www.rscada.se/libmbus/index.php

Fixes: https://autobuild.buildroot.org/results/11d/11d9e371033f7cdd3b24a9c1feb85b6aa921f96a
Signed-off-by: Florian Larysch <fl@n621.de>
---
 ...with-automake-1.11-and-should-work-w.patch | 28 +++++++++++++++++++
 package/libmbus/libmbus.hash                  |  2 +-
 package/libmbus/libmbus.mk                    |  3 +-
 3 files changed, 31 insertions(+), 2 deletions(-)
 create mode 100644 package/libmbus/0001-fix-build-error-with-automake-1.11-and-should-work-w.patch

diff --git a/package/libmbus/0001-fix-build-error-with-automake-1.11-and-should-work-w.patch b/package/libmbus/0001-fix-build-error-with-automake-1.11-and-should-work-w.patch
new file mode 100644
index 0000000000..fca78d1fe4
--- /dev/null
+++ b/package/libmbus/0001-fix-build-error-with-automake-1.11-and-should-work-w.patch
@@ -0,0 +1,28 @@
+From 991b26d2de1d91cddf994b724e3e4543d8cf6529 Mon Sep 17 00:00:00 2001
+From: Stefan Wahren <info@lategoodbye.de>
+Date: Thu, 4 Apr 2013 21:20:37 +0200
+Subject: [PATCH] fix build error with automake 1.11 and should work with automake 1.12 too
+
+Upstream: https://github.com/rscada/libmbus/commit/450ac7b9f4b1ddfe128b5334cf1855b0967153a3
+[Florian: Rebased to 0.8.0]
+Signed-off-by: Florian Larysch <fl@n621.de>
+---
+ configure.ac | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/configure.ac b/configure.ac
+index 461b616..d65df01 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -14,6 +14,8 @@ AM_INIT_AUTOMAKE([-Wall -Werror foreign])
+ AC_CONFIG_MACRO_DIR([m4])
+ 
+ AM_PROG_LIBTOOL
++# fix for automake 1.11 & 1.12
++m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
+ 
+ LDFLAGS="$LDFLAGS -version-info 0:8:0"
+ 
+-- 
+2.50.1
+
diff --git a/package/libmbus/libmbus.hash b/package/libmbus/libmbus.hash
index 493bab5820..f83c8460e0 100644
--- a/package/libmbus/libmbus.hash
+++ b/package/libmbus/libmbus.hash
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  9fca42592da0ba75df66c6f885a4dbfa916d23e65e3d1ce6e38d940d2a2719a4  libmbus-0.8.0.tar.gz
+sha256  9ae68426ba6ffb2818943741e3afa79448d7328446853added418a101b5ea53e  libmbus-0.8.0.tar.gz
 sha256  ea171a4ae443eca7186f564db2c3cc8b84c1ac343f227f92cd52ec6a948f4a74  COPYING
diff --git a/package/libmbus/libmbus.mk b/package/libmbus/libmbus.mk
index 61f797b5b9..4a27700570 100644
--- a/package/libmbus/libmbus.mk
+++ b/package/libmbus/libmbus.mk
@@ -5,9 +5,10 @@
 ################################################################################
 
 LIBMBUS_VERSION = 0.8.0
-LIBMBUS_SITE = http://www.rscada.se/public-dist
+LIBMBUS_SITE = $(call github,rscada,libmbus,$(LIBMBUS_VERSION))
 LIBMBUS_INSTALL_STAGING = YES
 LIBMBUS_LICENSE = BSD-3-Clause
 LIBMBUS_LICENSE_FILES = COPYING
+LIBMBUS_AUTORECONF = YES
 
 $(eval $(autotools-package))
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Thomas Petazzoni via buildroot]

Hello Florian,

On Fri, 25 Jul 2025 20:46:08 +0200
Florian Larysch <fl@n621.de> wrote:

> www.rscada.se has been offline for a long time, causing build failures.
> However, there is an official[1] GitHub repo. This also seems to be
> where new releases are happening rather than the old site.
> 
> Switch to git for fetching the source code. Unlike the tarball,
> the repo only ships partial autotools files (Makefile.in is missing, for
> example), so we need to do an autoreconf, which also requires a patch
> for modern Automake versions.
> 
> [1] https://web.archive.org/web/20250122102111/http://www.rscada.se/libmbus/index.php
> 
> Fixes: https://autobuild.buildroot.org/results/11d/11d9e371033f7cdd3b24a9c1feb85b6aa921f96a
> Signed-off-by: Florian Larysch <fl@n621.de>

Thanks a lot for the patch, which looks good. However, shouldn't we
also update the link in package/libmbus/Config.in?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Florian Larysch]

Hello Thomas,

thank you for taking a look at the patch!

On Mon, Jul 28, 2025 at 10:52:05PM +0200, Thomas Petazzoni wrote:
> However, shouldn't we also update the link in
> package/libmbus/Config.in?

I'm not sure. The libmbus repo still links to that page and when it was
working earlier this year, it seemed much more "official"/useful
(including examples and rendered documentation) than what e.g. the
README in the repo provides. I don't know how much hope there is for it
to come back, but if it does it would be the better place to point
somebody at.

Florian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Romain Naour via buildroot]

Hello Florian, Thomas, All,

Le 28/07/2025 à 23:20, Florian Larysch a écrit :
> Hello Thomas,
> 
> thank you for taking a look at the patch!
> 
> On Mon, Jul 28, 2025 at 10:52:05PM +0200, Thomas Petazzoni wrote:
>> However, shouldn't we also update the link in
>> package/libmbus/Config.in?
> 
> I'm not sure. The libmbus repo still links to that page and when it was
> working earlier this year, it seemed much more "official"/useful
> (including examples and rendered documentation) than what e.g. the
> README in the repo provides. I don't know how much hope there is for it
> to come back, but if it does it would be the better place to point
> somebody at.

Well, a working link is better than a broken one.
Actually there is a new release 0.9.0 from 2019 but if this package is not used
or updated it can be a candidate for removal.
Indeed, release 0.8.0 was released back in 2012.

[1] https://github.com/rscada/libmbus/releases/tag/0.9.0

Best regards,
Romain



> 
> Florian
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Florian Larysch]

Hello Romain,

On Sun, Aug 10, 2025 at 08:00:58PM +0200, Romain Naour via buildroot wrote:
> Well, a working link is better than a broken one.

Fair. I'll change it.

> Actually there is a new release 0.9.0 from 2019

Yeah I wanted to separate the build fix from the version bump so that
the former could be backported to stable releases. I was going to send
that after this got merged. But I can also batch up both changes in a
series if I'm going to respin it anyway if that's better?

> but if this package is not used or updated it can be a candidate for
> removal.

This feels like the kind of package that is going to have a number of
downstream users in Buildroot. Also, there has been some activity on the
master branch recently[1]. All in all I'd lean towards keeping it around
unless it causes further problems.

Florian

[1] https://github.com/rscada/libmbus/commits/master
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Romain Naour via buildroot]

Hello Florian,

Le 10/08/2025 à 20:17, Florian Larysch a écrit :
> Hello Romain,
> 
> On Sun, Aug 10, 2025 at 08:00:58PM +0200, Romain Naour via buildroot wrote:
>> Well, a working link is better than a broken one.
> 
> Fair. I'll change it.
> 
>> Actually there is a new release 0.9.0 from 2019
> 
> Yeah I wanted to separate the build fix from the version bump so that
> the former could be backported to stable releases. I was going to send
> that after this got merged. But I can also batch up both changes in a
> series if I'm going to respin it anyway if that's better?

If you also have a patch with the version bump, you can send both patches as a
series. This commit as patch 1/2 and the version bump as patch 2/2.

Patch 1/2 will go to master while patch 2/2 will go to next branch.

> 
>> but if this package is not used or updated it can be a candidate for
>> removal.
> 
> This feels like the kind of package that is going to have a number of
> downstream users in Buildroot. Also, there has been some activity on the
> master branch recently[1]. All in all I'd lean towards keeping it around
> unless it causes further problems.

Ok, feel free to add a new entry in DEVELOPERS file then.

I'll mark this patch as "Changes requested".

Thanks!

Best regards,
Romain


> 
> Florian
> 
> [1] https://github.com/rscada/libmbus/commits/master

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libmbus: switch to git repo

[Florian Larysch]

On Sun, Aug 24, 2025 at 04:41:16PM +0200, Romain Naour via buildroot wrote:
> Ok, feel free to add a new entry in DEVELOPERS file then.
> 
> I'll mark this patch as "Changes requested".

Okay, I'll respin the series and adopt the package.

Florian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot