Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: stefan.nickl@gmail.com
Cc: buildroot@buildroot.org, Aleksander Morgado <aleksander@aleksander.es>
Subject: Re: [Buildroot] [PATCH 1/1] package/modem-manager: Add option to enable AT commands via D-Bus
Date: Mon, 28 Jul 2025 23:01:57 +0200	[thread overview]
Message-ID: <20250728230157.132355e2@windsurf> (raw)
In-Reply-To: <20250724092439.675354-1-Stefan.Nickl@gmail.com>

Hello,

On Thu, 24 Jul 2025 11:24:39 +0200
stefan.nickl@gmail.com wrote:

> From: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

Thanks for the patch, looks good to me. I checked, this option doesn't
need any additional dependency, and is indeed a boolean option.

I have one very minor nit, see below.

> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 6990996a86..975a45902f 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -35,6 +35,12 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQRTR
>  	help
>  	  This option enables support for QRTR protocol
>  
> +config BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS
> +	bool "at-via-dbus support"
> +	help
> +	  This option enables support for issuing AT commands
> +	  over the D-Bus interface.

By putting this option here...

> +
>  comment "QRTR support needs a toolchain w/ headers >= 4.15"
>  	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15

... you have made this Config.in comment go farther away from the
BR2_PACKAGE_MODEM_MANAGER_LIBQRTR option it is related to. Could you
keep the Config.in comment close to BR2_PACKAGE_MODEM_MANAGER_LIBQRTR?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-07-28 21:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  9:24 [Buildroot] [PATCH 1/1] package/modem-manager: Add option to enable AT commands via D-Bus stefan.nickl
2025-07-28 21:01 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250728230157.132355e2@windsurf \
    --to=buildroot@buildroot.org \
    --cc=aleksander@aleksander.es \
    --cc=stefan.nickl@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox