[Buildroot] [PATCH 1/1] package/modem-manager: Add option to enable AT commands via D-Bus

[Buildroot] [PATCH 1/1] package/modem-manager: Add option to enable AT commands via D-Bus

[stefan.nickl]

From: Stefan Nickl <Stefan.Nickl@gmail.com>

Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>
---
 package/modem-manager/Config.in        | 6 ++++++
 package/modem-manager/modem-manager.mk | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index 6990996a86..975a45902f 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -35,6 +35,12 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQRTR
 	help
 	  This option enables support for QRTR protocol
 
+config BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS
+	bool "at-via-dbus support"
+	help
+	  This option enables support for issuing AT commands
+	  over the D-Bus interface.
+
 comment "QRTR support needs a toolchain w/ headers >= 4.15"
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15
 
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index 932c163175..899e3071a5 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -48,6 +48,12 @@ else
 MODEM_MANAGER_CONF_OPTS += -Dqrtr=false
 endif
 
+ifeq ($(BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS),y)
+MODEM_MANAGER_CONF_OPTS += -Dat_command_via_dbus=true
+else
+MODEM_MANAGER_CONF_OPTS += -Dat_command_via_dbus=false
+endif
+
 ifeq ($(BR2_PACKAGE_SYSTEMD),y)
 MODEM_MANAGER_DEPENDENCIES += systemd
 MODEM_MANAGER_CONF_OPTS += \
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/modem-manager: Add option to enable AT commands via D-Bus

[Thomas Petazzoni via buildroot]

Hello,

On Thu, 24 Jul 2025 11:24:39 +0200
stefan.nickl@gmail.com wrote:

> From: Stefan Nickl <Stefan.Nickl@gmail.com>
> 
> Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>

Thanks for the patch, looks good to me. I checked, this option doesn't
need any additional dependency, and is indeed a boolean option.

I have one very minor nit, see below.

> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 6990996a86..975a45902f 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -35,6 +35,12 @@ config BR2_PACKAGE_MODEM_MANAGER_LIBQRTR
>  	help
>  	  This option enables support for QRTR protocol
>  
> +config BR2_PACKAGE_MODEM_MANAGER_ATVIADBUS
> +	bool "at-via-dbus support"
> +	help
> +	  This option enables support for issuing AT commands
> +	  over the D-Bus interface.

By putting this option here...

> +
>  comment "QRTR support needs a toolchain w/ headers >= 4.15"
>  	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_15

... you have made this Config.in comment go farther away from the
BR2_PACKAGE_MODEM_MANAGER_LIBQRTR option it is related to. Could you
keep the Config.in comment close to BR2_PACKAGE_MODEM_MANAGER_LIBQRTR?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot